[Freeciv-Dev] [bug #21894] Crash in is_my_zoc()

2014-04-10 Thread Jacob Nevins 
Update of bug #21894 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => jtn
 Open/Closed:Open => Closed 

___

Follow-up Comment #5:

No problem. Thanks for the fix; now committed. 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21894] Crash in is_my_zoc()

2014-04-10 Thread pepeto 
Follow-up Comment #3, bug #21894 (project freeciv):

I cannot commit this before next week... That's why I didn't set it assigned
to me.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21894] Crash in is_my_zoc()

2014-04-09 Thread Jacob Nevins 
Follow-up Comment #2, bug #21894 (project freeciv):

I consider this a critical bug fix patch
, since it
shows up almost immediately in many new games. Do you intend to commit it
soon?

If I don't hear, I intend to commit this myself.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21894] Crash in is_my_zoc()

2014-04-05 Thread Jacob Nevins 
Follow-up Comment #1, bug #21894 (project freeciv):

This crash shows up readily in a new game -- pressing 'G' on one of your first
workers is often enough to provoke it, for me (I presume because there's
plenty of unknown terrain around).

The attached patch makes the crash go away, for me.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21894] Crash in is_my_zoc()

2014-04-05 Thread pepeto 
URL:
  

 Summary: Crash in is_my_zoc()
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 05 avril 2014 12:15:08 CEST
Category: general
Severity: 4 - Important
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r24748
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

When trying a simple city attack, I experimented a segfault in is_my_zoc(). It
looks like this has been added with the implementation of patch #4597.

Attached test savegame and a fix which works for me.


Program received signal SIGSEGV, Segmentation fault.
0x0061af38 in is_my_zoc (pplayer=0x175c850, ptile0=)
at unit.c:1710
1710if (terrain_has_flag(tile_terrain(ptile), TER_NO_ZOC)) {
(gdb) bt full
#0  0x0061af38 in is_my_zoc (pplayer=0x175c850, ptile0=)
at unit.c:1710
_dummy_x = 
ptiledummy_y = 27
ptile_index = 
ptile_start = 
dummy_y = 
ptile_dummy_x = 49
_start_dummy_x = 48
_startdummy_y = 28
ptile = 0x18eea38
__FUNCTION__ = "is_my_zoc"
#1  0x0063a51d in pf_normal_node_init (pfnm=0x271ed20, node=0x2743760,

ptile=0x18f04b0) at path_finding.c:300
[...]
(gdb) print *ptile
$2 = {index = 2155, continent = 0, extras = {
vec = "\000\000\000\000\000\000\000"}, resource_valid = false, 
  resource = 0x0, terrain = 0x0, units = 0x193e5a0, worked = 0x0, owner = 0x0,

  extras_owner = 0x0, claimer = 0x0, label = 0x0, spec_sprite = 0x0}





___

File Attachments:


---
Date: sam. 05 avril 2014 12:15:08 CEST  Name: is_my_zoc.diff  Size: 626 o  
By: pepeto


---
Date: sam. 05 avril 2014 12:15:08 CEST  Name:
freeciv-T-Y-4000-manual.sav.gz  Size: 23 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev