[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace

2014-07-08 Thread Jacob Nevins
Update of bug #22281 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22281

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace

2014-07-07 Thread anonymous
Follow-up Comment #5, bug #22281 (project freeciv):

Thanks! On reflection, a Courthouse is indeed redundant (according to the
dictionary meaning of the word) in the presence of a Palace. I'm ok though if
the city production UI doesn't tell me that.

___

Reply to this item at:

  http://gna.org/bugs/?22281

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace

2014-07-06 Thread anonymous
URL:
  http://gna.org/bugs/?22281

 Summary: Help should show Courthouse has no effect in
presence of Palace
 Project: Freeciv
Submitted by: None
Submitted on: Sun 06 Jul 2014 11:15:30 AM UTC
Category: docs
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: kaza...@gmail.com
 Open/Closed: Open
 Release: 2.4.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

Regarding the default/classic ruleset (and other relevant rulesets), I think
it's best that the Help docs for the Courthouse state that it has no effect in
the presence of the Palace, and that the Help docs for the Palace state that
it has the corruption-busting effects of the Courthouse. This saves someone
from building a Courthouse in the capital and then wondering why nothing has
changed. For a while I thought the game was broken (unlikely I know), but the
effects.ruleset file eventually cleared away the confusion. Still, one
shouldn't have to go through the ruleset files to find out about gameplay
rules.




___

Reply to this item at:

  http://gna.org/bugs/?22281

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace

2014-07-06 Thread Jacob Nevins
Follow-up Comment #1, bug #22281 (project freeciv):

Hm, yes, that could be clearer.

Also the Palace help could state explicitly that Palace means your capital
can't be incited to revolt, to contrast with the Courthouse's increase in
incite cost.

(This is also a useful example of the notion of redundant buildings being
discussed in patch #4885, bug #21992 etc. You might kind of want Courthouse to
be marked as redundant in the UI in non-Democracy governments, but:
* Redundancy logic does not know that No_Incite trumps Incite_Cost_Pct, and
probably shouldn't.
* In a Democracy, the Courthouse would do something useful (Make_Content) even
in your capital. Should that count as redundant? One day it could be useful
without the set of buildings in the city changing.
** You could probably trick the current logic into displaying it as redundant
by expressing the Democracy requirement as negated reqs for all the other
governments. (Gross.)
I suspect that it won't be possible for the engine to always infer redundancy
in the way we'd want from the building effects. But making ruleset authors
write their own consider this building redundant / not redundant if these
requirements are met, which the engine can't check, is also ugly and
error-prone. Hm.)

___

Reply to this item at:

  http://gna.org/bugs/?22281

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace

2014-07-06 Thread anonymous
Follow-up Comment #2, bug #22281 (project freeciv):

Yep, unless the Palace incorporates all the abilities of a Courthouse
(including its ability to be built in multiple cities), the Courthouse
shouldn't be marked as redundant in the UI even if the Palace is around. The
Palace can move after all, and what is currently a capital city may no longer
be so. Adam Smith helps in keeping a capital Courthouse standing.

It's just that there could be a note regarding the interactions between Palace
and Courthouse in the Help docs. Autogenerating the docs from effects.ruleset
is probably better (but more work).

___

Reply to this item at:

  http://gna.org/bugs/?22281

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace

2014-07-06 Thread Jacob Nevins
Update of bug #22281 (project freeciv):

  Status:None = In Progress
 Assigned to:None = jtn

___

Follow-up Comment #3:

 It's just that there could be a note regarding the interactions 
 between Palace and Courthouse in the Help docs.
Agreed; working on it.

(Aside: in the civ1 ruleset, Courthouse only affects corruption, and *is*
marked as redundant in the capital. Also, the help is full of lies; fixing
that too.)

___

Reply to this item at:

  http://gna.org/bugs/?22281

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22281] Help should show Courthouse has no effect in presence of Palace

2014-07-06 Thread Jacob Nevins
Update of bug #22281 (project freeciv):

  Status: In Progress = Ready For Test 
 Planned Release: = 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #4:

* Explicitly noted that capital can't be incited in Palace help.
* Also noted other diplomat bonuses that weren't mentioned.
* civ1 claimed all sorts of effects for its Courthouses which weren't in the
rules, which have only a corruption effect. This civ1 manual
http://www.civfanatics.com/civ1/manual/civ1_man.htm supports that, so I've
fixed the docs.
* civ2 and multiplayer help didn't mention the effects on waste; fixed.
** (civ1 also has a waste benefit to Palace, but the ruleset has no waste, so
I didn't mention it.)
* civ2civ3 Courthouse description didn't mention its effects on food waste.
Palace neither. Also, remove claims that some governments don't suffer
distance-based waste, as it's a bit more complicated than that.

(file #21300, file #21301)
___

Additional Item Attachment:

File name: trunk-S2_5-help-courthouse-vs-palace.patch Size:12 KB
File name: S2_4-help-courthouse-vs-palace.patch Size:10 KB


___

Reply to this item at:

  http://gna.org/bugs/?22281

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev