[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Follow-up Comment #15, bug #22381 (project freeciv): (FWIW, the original description of this change I wrote for release notes before it was reverted: Units can now attack out of cities on non-native terrain regardless of whether their class has the AttFromNonNative flag. For instance, land units can now attack out of ocean cities in the Alien ruleset.) ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Update of bug #22381 (project freeciv): Planned Release:2.6.0, 2.5.0 = 2.6.0 ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Follow-up Comment #13, bug #22381 (project freeciv): Raised bug #22794 to resolve whether this should be reverted or modified. Please discuss / make proposals there. ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Update of bug #22381 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Follow-up Comment #2, bug #22381 (project freeciv): _ For the source tile in unit_attack_unit_at_tile_result(), changing to can_exist_at_tile() would be better._ Another benefit of testing for can exist is that it becomes consistent with spy actions. ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Follow-up Comment #3, bug #22381 (project freeciv): That the source tile isn't checking can_exist_at_tile() now is an oversight (and a bug). I'm unsure of the right solution for the destination tile though. Should the source bug just be fixed, and we can discuss the destination more? Should can_exist_at_tile() be refactored so that there is another function that includes everything by the safety test that can be called from can_exist_at_tile(), and that used, so everything is a single commit? Is there a narrative reason UTYF_TRIREME units should not attack unsafe terrains? ( I almost added a patch for this as soon as it was raised, but suddenly became uncertain regarding these questions, so commented instead). As for consistency with spy actions: I strongly believe we need to determine the right answer, and then have that apply in both situations (ignoring facilities for ruleset flexibility that may permit ruleset authors to adjust this), rather than that we ought make this change for the value of consistency (that the current actions implementation happens to be right means that I actually want consistency, just not for the sake of consistency). Unfortuntately, I don't have capacity to think about this deeply currently, so can't help that much (and would be happy with the conclusion of anyone else who is able to think about it sooner). ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Follow-up Comment #4, bug #22381 (project freeciv): _Should the source bug just be fixed, and we can discuss the destination more?_ I think that is a good idea. I raised patch #4984 for discussing that issue. I could start working on this bug today (unless you already have started). _As for consistency with spy actions: I strongly believe we need to determine the right answer, and then have that apply in both situations_ Agreed. (This is why patch #4894 still is In Progress) ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Update of bug #22381 (project freeciv): Status: In Progress = None Assigned to:sveinung = None ___ Follow-up Comment #6: I wrote the source patch on Tuesday, but discarded it :) Please feel free to do it, as I won't have time to test it properly until this weekend, at the soonest. A strategy involving patch #4984 seems a reasonable plan (and provides proper semantic separation between the bugfix and the potential behaviour change). ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
URL: http://gna.org/bugs/?22381 Summary: Inconsistent nativity limits on source tile for regular attacks Project: Freeciv Submitted by: sveinung Submitted on: Tue 22 Jul 2014 12:18:46 PM UTC Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The function unit_attack_unit_at_tile_result() will check if the source tile is native to the attacking unit. The function unit_move_to_tile_test() will check if the attacking unit can exist at the source tile. A tile is native to a unit if its terrain is native or it has an extra that makes it native. A unit can exist on a tile if it (has a city AND (the unit's class has the flag BuildAnywhere OR an adjacent tile is native OR the city is part of a city channel)) OR (the tile is native unless (the units type has the flag Trireme AND the tile's terrain don't have the flag UnsafeCoast)). A comment in unit_move_to_tile_test() indicates that can exist is intentional and preferred. ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks
Follow-up Comment #1, bug #22381 (project freeciv): This is a bit complicated. For the source tile in unit_attack_unit_at_tile_result(), changing to can_exist_at_tile() would be better. For the destination tile, we may need a new test (or to refactor the existing ones), because UTYF_TRIREME units that can attack non-native should be able to attack units in cities on unsafe terrains (but not advance to them if they are successful, and their unit class advances on attack). ___ Reply to this item at: http://gna.org/bugs/?22381 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
