[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-08-02 Thread Marko Lindqvist
Update of bug #22404 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22404

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-31 Thread pepeto
Follow-up Comment #3, bug #22404 (project freeciv):

 If my original patch is to be used, it should be changed at
 least to initialize with 0.0 instead of 0 and drop
 assignment of 0.0 from default case.

I would be happy with your solution then.


___

Reply to this item at:

  http://gna.org/bugs/?22404

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-30 Thread pepeto
Follow-up Comment #1, bug #22404 (project freeciv):

IIRC, my original plan was to initialize this variable in the switch
statement. case 0 should have = instead of +=, and case 1,2,3,4 should
have it initialized. Else, there is no sense to set it explicitly for the
default case.


___

Reply to this item at:

  http://gna.org/bugs/?22404

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-30 Thread Marko Lindqvist
Follow-up Comment #2, bug #22404 (project freeciv):

I see at least three ways one could argue to be the right way to do this. I
don't have strong opinion about this. Do you want to implement the patch some
certain way? If my original patch is to be used, it should be changed at least
to initialize with 0.0 instead of 0 and drop assignment of 0.0 from
default case.

___

Reply to this item at:

  http://gna.org/bugs/?22404

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-29 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?22404

 Summary: tech_upkeep uninitialized in player_tech_upkeep()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 30 Jul 2014 12:02:33 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

We add (+=) to uninitialized value of tech_upkeep in player_tech_upkeep()

Fix attached.




___

File Attachments:


---
Date: Wed 30 Jul 2014 12:02:33 AM EEST  Name: TechUpkeepInit.patch  Size: 544B
  By: cazfi

http://gna.org/bugs/download.php?file_id=21585

___

Reply to this item at:

  http://gna.org/bugs/?22404

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev