[Freeciv-Dev] [bug #22847] "reset" in server/commands.c

[pepeto]

Update of bug #22847 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22847] "reset" in server/commands.c

[David Lowe]

Follow-up Comment #5, bug #22847 (project freeciv):

> Does some client allow you to configure this?

This is probably easier to control at the level of the text editor.  Certainly
TextWrangler, which i use, has preferences for three different kinds of line
endings, stripping trailing white space, etc.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22847] "reset" in server/commands.c

[Frank]

Follow-up Comment #4, bug #22847 (project freeciv):

When I look in voting.c it has LF, while commands.c has CRLF. 

svn proplist server/voting.c reports no properties. 
svn proplist server/commands.c reports svn:eol-style (and two other
properties).

svn propget svn:eol-style server/commands.c says native. Sigh. 

svn propset svn:eol-style LF -R . 

svn propget svn:eol-style server/commands.c says LF. Better.

Okay, now those diffs should be able to preserve trailing white space at least
when I say so.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22847] "reset" in server/commands.c

[Marko Lindqvist]

Follow-up Comment #3, bug #22847 (project freeciv):

> If I use my UNIX settings to preserve Tabs and trailing white
> space ALL lines are changed from CRLF to LF.

If you want to work with LF, you should get svn client that checkouts
svn:eol-style=native files that way. Unfortunately I don't know if that's even
possible (does MinGW svn checkout using CRLF or LF? Does some client allow you
to configure this?)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22847] "reset" in server/commands.c

[Frank]

Follow-up Comment #2, bug #22847 (project freeciv):

If I use my UNIX settings to preserve Tabs and trailing white space ALL lines
are changed from CRLF to LF. 

In theory I could create a FREECIV macro preserving Tabs and trailing white
space for CRLF everywhere, but switching line ending styles per file can't be
a good idea.

Demo diff with all lines using LF attached for comparison, with all lines
changed from CRLF to LF the trailing white space is of course also lost. 

(file #22739)
___

Additional Item Attachment:

File name: commands.c.patch   Size:67 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22847] "reset" in server/commands.c

[pepeto]

Update of bug #22847 (project freeciv):

  Status:None => In Progress
 Assigned to:None => pepeto 

___

Follow-up Comment #1:

> Does that mean that 'reset default' is actually not the default?

_default_ is not the default. Actually the value _default_ indicates we want
to reset the settings to their server default value (maybe it could be clearer
in the help text). So the default may be either _ruleset_ if the game is not
started yet or _game_ if it has started.

> The attached diff also removes trailing white space in three lines

Don't touch lines you are not working on. CodingStyle claims that you should
"not re-indent areas of code you are not modifying or creating". I think this
comment is right for trailing spaces too. It makes the historical researches
harder (e.g. svn/git blame).


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22847] "reset" in server/commands.c

[Frank]

URL:
  

 Summary: "reset" in server/commands.c
 Project: Freeciv
Submitted by: dunnoob
Submitted on: Wed 22 Oct 2014 04:12:49 UTC
Category: docs
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Old: SYN_ORIG_("reset"),
New: SYN_ORIG_("reset [game|ruleset|script|default]"),

Background, the "reset" description in manual2.html created by
`freeciv-manual` does not match other commands with parameters.  When I tested
`reset` without parameters it resulted in a server message "guessing 'reset
ruleset'" (or similar).  Does that mean that 'reset default' is actually *not*
the default?

The attached diff also removes trailing white space in three lines; 100%
certified *untested*.



___

File Attachments:


---
Date: Wed 22 Oct 2014 04:12:49 UTC  Name: commands.c.patch  Size: 1kB   By:
dunnoob



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev