[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread mir3x 
Update of bug #25349 (project freeciv):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread mir3x 
Update of bug #25349 (project freeciv):

Priority:  5 - Normal => 9 - Immediate  
  Status:  Ready For Test => Fixed  
 Assigned to:None => mir3x  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread Marko Lindqvist 
Follow-up Comment #5, bug #25349 (project freeciv):

v2 version of the patch works. Please commit as emergency build fix.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread mir3x 
Follow-up Comment #4, bug #25349 (project freeciv):

Ok that one will do it right.

(file #29534)
___

Additional Item Attachment:

File name: qt_signed_overflow_v2.patchSize:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread Marko Lindqvist 
Follow-up Comment #3, bug #25349 (project freeciv):

Doesn't help here.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread mir3x 
Update of bug #25349 (project freeciv):

  Status:None => Ready For Test 
 Contains string changes:None => No 

___

Follow-up Comment #2:

Patch should make that warning go away ( couldnt reproduce that, so not 100%
sure)

(file #29533)
___

Additional Item Attachment:

File name: qt_signed_overflow.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread mir3x 
Follow-up Comment #1, bug #25349 (project freeciv):

THis must be caused by patch #8033, Ill investigate.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread Marko Lindqvist 
Update of bug #25349 (project freeciv):

 Planned Release: => 2.6.0-beta1, 3.0.0 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25349] hud_units::update_actions() compile failure

2016-12-01 Thread Marko Lindqvist 
URL:
  

 Summary: hud_units::update_actions() compile failure
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 01 Dec 2016 02:03:39 PM EET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 
 Contains string changes: None

___

Details:

This is new since yesterday (crosser nightly failed first time last night)

  CXX  hudwidget.lo
In file included from
/usr/include/x86_64-linux-gnu/qt5/QtGui/qkeysequence.h:44:0,
 from
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qaction.h:43,
 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QAction:1,
 from ../../../../src/client/gui-qt/hudwidget.cpp:19:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h: In member function ‘void
hud_units::update_actions(unit_list*)’:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:994:47: error: assuming
signed overflow does not occur when assuming that (X - c) <= X is always true
[-Werror=strict-overflow]
 { return i < s.d->size ? s.d->data()[i] : 0; }
   ^
cc1plus: all warnings being treated as errors





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev