[Freeciv-Dev] [patch #1404] log module

[pepeto]

Update of patch #1404 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1404] log module

[Matthias Pfafferodt]

Follow-up Comment #3, patch #1404 (project freeciv):

> I doubt your changes in the space numbers in the comments are really
useful.

It was something that did catch my eye and then a simple search & replace ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1404] log module

[pepeto]

Follow-up Comment #2, patch #1404 (project freeciv):

Thanks for the fixes.  I doubt your changes in the space numbers in the
comments are really useful.  But I will probably commit them too.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1404] log module

[Matthias Pfafferodt]

Follow-up Comment #1, patch #1404 (project freeciv):

I looked into this patch to understand its impact to the log city map patch
(patch #1226). Doing this I found one missing LOGLEVEL_FERRY_STATS in
./ai/aiferry.c. After that I checked all calls to this function - no more
occurrences found. I also did a search & replace for double spaces within the
changed parts of the code.

Due to the size of the patch I will only attach the changes compared to the
original patch.


(file #7659)
___

Additional Item Attachment:

File name: log2.patch Size:15 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1404] log module

[pepeto]

URL:
  

 Summary: log module
 Project: Freeciv
Submitted by: pepeto
Submitted on: dimanche 10.01.2010 à 16:32
Category: general
Priority: 1 - Later
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

Some observations in the current implementation:
* freelog() messages always compute all arguments, even if it won't be
displayed to the screen.
* The --debug option is not flexible, it overwrite the previous one.
* "4:file" doesn't work if the level is different of LOG_DEBUG.

What this patch changes:
* freelog(loglevel) renamed log_fatal(), log_error(), log_normal(),
log_verbose() and log_debug().
* Those macros don't compute the arguments if they won't display them.
* log_debug() really doesn't have any effect when not configured with
--enable-debug.
* The --debug allows many levels based on the location of the call of the log
macro (file + line) when configured with --enable-debug.
* RETURN[_VAL]_IF_FAIL[_MSG]() renamed log_assert[_ret][_val][_msg]().




___

File Attachments:


---
Date: dimanche 10.01.2010 à 16:32  Name: trunk_log.diff.bz2  Size: 116 ko  
By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev