[Freeciv-Dev] [patch #1552] Load script state last in loading savegame

2010-03-28 Thread Ulrik Sverdrup

Update of patch #1552 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1552] Load script state last in loading savegame

2010-03-27 Thread pepeto

Follow-up Comment #2, patch #1552 (project freeciv):

> Is it ok to check this in to 2.2 as a bug fix?

Yes, this is a bug.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1552] Load script state last in loading savegame

2010-03-27 Thread Ulrik Sverdrup

Follow-up Comment #1, patch #1552 (project freeciv):

Is it ok to check this in to 2.2 as a bug fix?

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1552] Load script state last in loading savegame

2010-03-25 Thread Ulrik Sverdrup

Update of patch #1552 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => englabenny 


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1552] Load script state last in loading savegame

2010-03-22 Thread Ulrik Sverdrup

URL:
  

 Summary: Load script state last in loading savegame
 Project: Freeciv
Submitted by: englabenny
Submitted on: måndag 2010-03-22 den 19:54
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Saving script state saves references to cities, players, units etc by
reference to the secfile path 'code.vars'. When we load script state,
the game data is wholly incomplete, and loading of cities and units
fail.

On savegame load, the scenario code part is evaluated (function
definitions and toplevel code, such as signal handlers), then the vars
part is evaluated to restore script variables, possibly references to
cities and players (and other api types). For this to work we must
load the script state after the rest of the game has been set up.



___

File Attachments:


---
Date: måndag 2010-03-22 den 19:54  Name:
0001-Load-script-state-last-in-loading-savegame.patch  Size: 2 kB   By:
englabenny



___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev