[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-25 Thread Matthias Pfafferodt
Update of patch #1616 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-18 Thread Ulrik Sverdrup
Follow-up Comment #8, patch #1616 (project freeciv): Before committing, please add to api_actions_create_player after variable declarations: SCRIPT_CHECK_ARG_NIL(username, 1, string, NULL) the Script API must all check their assumptions and make sure (the best they can) that wrong arguments

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-18 Thread Matthias Pfafferodt
Update of patch #1616 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #9: updated version of the patch; changes * add check for the arguments as mentioned in comment

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-17 Thread Matthias Pfafferodt
Follow-up Comment #3, patch #1616 (project freeciv): updated patch; changes: * return a bool value (success) * use Nation_Type (file #8998) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-17 Thread Ulrik Sverdrup
Follow-up Comment #4, patch #1616 (project freeciv): Sorry, I think the API function must return the player object. There is no reliable way to find the player otherwise in all cases (username vs name etc?). Also player vs. nil is tells the success information as well.

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-17 Thread Matthias Pfafferodt
Follow-up Comment #5, patch #1616 (project freeciv): OK; no problem to add this again. As your current lua script did this I tried to do it the easy way ... ___ Reply to this item at: http://gna.org/patch/?1616

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-17 Thread Matthias Pfafferodt
Follow-up Comment #6, patch #1616 (project freeciv): Sorry, I think the API function must return the player object. Done. (file #9000) ___ Additional Item Attachment: File name: 20100417-06.1-trunk-add-create_player-lua-function.patch

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-17 Thread Ulrik Sverdrup
Follow-up Comment #7, patch #1616 (project freeciv): Thanks great. everything should be in place in the API to implement Sea Land newcomers now. I'll test this now. ___ Reply to this item at: http://gna.org/patch/?1616

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-14 Thread Matthias Pfafferodt
Follow-up Comment #1, patch #1616 (project freeciv): add the possibility to select a nation (file #8969) ___ Additional Item Attachment: File name: 20100414-06-trunk-add-create_player-lua-function.patch Size:12 KB

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-14 Thread Ulrik Sverdrup
Follow-up Comment #2, patch #1616 (project freeciv): It works well on testing (except not returning the player, but you can get the player variable back from other places of course). A comment on a very small thing: in the api_actions.[ch] files, all type names use the API typedefs, Nation_Type

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-11 Thread Matthias Pfafferodt
URL: http://gna.org/patch/?1616 Summary: add create_player lua function Project: Freeciv Submitted by: syntron Submitted on: Sonntag 11.04.2010 um 15:47 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1616] add create_player lua function

2010-04-11 Thread Matthias Pfafferodt
Update of patch #1616 (project freeciv): Depends on: = patch #1574 ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht