[Freeciv-Dev] [patch #1616] add create_player lua function
Update of patch #1616 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #8, patch #1616 (project freeciv): Before committing, please add to api_actions_create_player after variable declarations: SCRIPT_CHECK_ARG_NIL(username, 1, string, NULL) the Script API must all check their assumptions and make sure (the best they can) that wrong arguments can't crash freeciv. The above will make an argument error if called with a 'nil' name. The '1' is because the argument error is for argument 1, expected type is 'string'. See other api_actions.c functions for examples. (I think we added these macros after your first draft of this patch). ___ Reply to this item at: http://gna.org/patch/?1616 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Update of patch #1616 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #9: updated version of the patch; changes * add check for the arguments as mentioned in comment #8 (file #9011) ___ Additional Item Attachment: File name: 20100418-05-trunk-add-create_player-lua-function.patch Size:12 KB ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #3, patch #1616 (project freeciv): updated patch; changes: * return a bool value (success) * use Nation_Type (file #8998) ___ Additional Item Attachment: File name: 20100417-06-trunk-add-create_player-lua-function.patch Size:11 KB ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #4, patch #1616 (project freeciv): Sorry, I think the API function must return the player object. There is no reliable way to find the player otherwise in all cases (username vs name etc?). Also player vs. nil is tells the success information as well. ___ Reply to this item at: http://gna.org/patch/?1616 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #7, patch #1616 (project freeciv): Thanks great. everything should be in place in the API to implement Sea Land newcomers now. I'll test this now. ___ Reply to this item at: http://gna.org/patch/?1616 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #1, patch #1616 (project freeciv): add the possibility to select a nation (file #8969) ___ Additional Item Attachment: File name: 20100414-06-trunk-add-create_player-lua-function.patch Size:12 KB ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #2, patch #1616 (project freeciv): It works well on testing (except not returning the player, but you can get the player variable back from other places of course). A comment on a very small thing: in the api_actions.[ch] files, all type names use the API typedefs, Nation_Type instead of struct nation_type. ___ Reply to this item at: http://gna.org/patch/?1616 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
URL: http://gna.org/patch/?1616 Summary: add create_player lua function Project: Freeciv Submitted by: syntron Submitted on: Sonntag 11.04.2010 um 15:47 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: syntron Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: with help from Ulrik Sverdrup englabenny (see patch #1574) ___ File Attachments: --- Date: Sonntag 11.04.2010 um 15:47 Name: 20100411-06-trunk-add-create_player-lua-function.patch Size: 7kB By: syntron http://gna.org/patch/download.php?file_id=8913 ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Update of patch #1616 (project freeciv): Depends on: = patch #1574 ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
