[Freeciv-Dev] [patch #1701] Reduce the minimum width of the city report dialogue
Update of patch #1701 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1701 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1701] Reduce the minimum width of the city report dialogue
Follow-up Comment #1, patch #1701 (project freeciv): this patch results in an error for me: make[4]: Entering directory `/home/matthias/data/git/freeciv.git/client/gui-gtk-2.0' /bin/sh ../../libtool --preserve-dup-deps --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I./../include -I../../utility -I../../common -I../../common/aicore -I./../agents -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DLOCALEDIR=\/usr/local/share/locale\ -DDEFAULT_DATA_PATH=\.:data:~/.freeciv/2.3:/usr/local/share/freeciv\ -DDEFAULT_SAVES_PATH=\\ -DDEFAULT_SCENARIO_PATH=\.:data/scenario:~/.freeciv/scenarios:/usr/local/share/freeciv/scenario\ -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Werror -Werror -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wnested-externs -Wl,--no-add-needed -g -O2 -MT cityrep.lo -MD -MP -MF .deps/cityrep.Tpo -c -o cityrep.lo cityrep.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I./../include -I../../utility -I../../common -I../../common/aicore -I./../agents -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DLOCALEDIR=\/usr/local/share/locale\ -DDEFAULT_DATA_PATH=\.:data:~/.freeciv/2.3:/usr/local/share/freeciv\ -DDEFAULT_SAVES_PATH=\\ -DDEFAULT_SCENARIO_PATH=\.:data/scenario:~/.freeciv/scenarios:/usr/local/share/freeciv/scenario\ -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Werror -Werror -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wnested-externs -Wl,--no-add-needed -g -O2 -MT cityrep.lo -MD -MP -MF .deps/cityrep.Tpo -c cityrep.c -o cityrep.o cc1: warnings being treated as errors cityrep.c: In function ‘create_city_report_dialog’: cityrep.c:1139: error: passing argument 1 of ‘gtk_label_set_ellipsize’ from incompatible pointer type make[4]: *** [cityrep.lo] Error 1 make[4]: Leaving directory `/home/matthias/data/git/freeciv.git/client/gui-gtk-2.0' make[3]: *** [all] Error 2 line 1139 is the new function call: gtk_label_set_ellipsize(city_total_buy_cost_label, PANGO_ELLIPSIZE_START); Does the call needs some GTK macro? ___ Reply to this item at: http://gna.org/patch/?1701 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1701] Reduce the minimum width of the city report dialogue
Follow-up Comment #2, patch #1701 (project freeciv): Well, it works without any macro for me (both on Gentoo with gkt+-2.18.9 and on Ubuntu with gtk+-2.18.3), but then it works with the GTK_LABEL() macro too (just tested), so try that one. Also, please note that I've only tested this on the 2.2 branch, so it might conflict with some other change in trunk. If this doesn't help I'll have to investigate that. (file #9300) ___ Additional Item Attachment: File name: freeciv-2.2.1-reduce-science-help-checkbox-width-v2.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?1701 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1701] Reduce the minimum width of the city report dialogue
Follow-up Comment #3, patch #1701 (project freeciv): I think file #9300 is the diff for patch #1689. I will now test this patch with the macro. There should be no other change interfering with this. ___ Reply to this item at: http://gna.org/patch/?1701 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1701] Reduce the minimum width of the city report dialogue
Update of patch #1701 (project freeciv): Status:None = Ready For Test Assigned to:None = syntron Planned Release: = 2.3.0 ___ Follow-up Comment #4: The attached patch includes the macro GTK_LABEL() for city_total_buy_cost_label and it is compiling! Now we have to decide if gtk+-2.6 is OK ... Could you please check if it is working correctly in trunk? For me the number of selected columns force scrolling. (file #9305) ___ Additional Item Attachment: File name: 20100612-07-trunk-patch-1701-Reduce-the-minimum-width-of-the-city-re.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?1701 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1701] Reduce the minimum width of the city report dialogue
Follow-up Comment #5, patch #1701 (project freeciv): Sorry, it appear I managed to attach the wrong file, but no harm done, as you managed to create it yourself, based on my description. Anyway, I applied your patch on a fresh trunk checkout, and tested the result (on my desktop, but in a forced 1024x575 px window thus emulating my netbook), and it does work as intended. The default selection of displayed columns does force the *list* to scroll in order to fit in the *tab*, but the *tab* is not so wide that it forces the entire *window* to scroll. ___ Reply to this item at: http://gna.org/patch/?1701 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1701] Reduce the minimum width of the city report dialogue
URL: http://gna.org/patch/?1701 Summary: Reduce the minimum width of the city report dialogue Project: Freeciv Submitted by: jon_severinsson Submitted on: fredag 2010-06-11 den 14:58 Category: client-gtk-2.0 Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: This is an additional patch in my series intended to improve the gtk gui on netbook sized displays. The city report dialogue is fine when first opened, but once a city producing anything is selected, a Total Buy Cost: %d label will make it way to wide, and thus force scrolling. This patch will case this label to be ellipsized (eg ...Cost: %d) if it won't fit without forcing scrolling. Fixing this required the use of gtk_label_set_ellipsize(), which was introduced in Gtk+ 2.6. As such this patch will also increase the minimum Gtk+ version from 2.4 to 2.6, but as 2.6 was released over six (6) years ago, I don't think this is a problem. ___ File Attachments: --- Date: fredag 2010-06-11 den 14:58 Name: freeciv-2.2.1-reduce-city-report-minimum-width.patch Size: 3 kB By: jon_severinsson http://gna.org/patch/download.php?file_id=9296 ___ Reply to this item at: http://gna.org/patch/?1701 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
