[Freeciv-Dev] [patch #1983] Cleanup for 'enum' options
Update of patch #1983 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1983 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1983] Cleanup for 'enum' options
Follow-up Comment #2, patch #1983 (project freeciv): After this patch, I noticed that file #10365 from bug #16708 is loading differently on my machine: it's now coming out with the map taller than it is wide, and giving some warnings. Looking at the savefile, I think should *always* have been tall -- xsize is 48 and ysize is 64. But in old versions of trunk it loads as wide. Bizarre. I don't know why this is. Savegames from S2_2 load fine (but I don't have any others from trunk in savegame2 format to try). Probably it just means that some savefiles generated by medium-old versions of trunk are a bit dubious, and we shouldn't worry about it. I'm mentioning the behaviour mainly in case it puzzles anyone else. While staring at the patch to work out what could possibly have caused this, I noticed that it incidentally fixes a bug in setting_bool_str_to_bool(), which was using a function pointer from the wrong part of a union. This could have been causing widespread, possibly machine-dependent carnage with loading boolean server options, I guess. I think the bug was introduced by r17554, patch #1726, 2010-07-10. Perhaps this could explain the behaviour I'm seeing above by some complicated chain of events I haven't worked out. ___ Reply to this item at: http://gna.org/patch/?1983 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1983] Cleanup for 'enum' options
Follow-up Comment #3, patch #1983 (project freeciv): Probably it just means that some savefiles generated by medium-old versions of trunk are a bit dubious, and we shouldn't worry about it. I'm mentioning the behaviour mainly in case it puzzles anyone else. Yes, I changed how it saves/load enum values into the savegame, so old trunk savegame may load strangely. While staring at the patch to work out what could possibly have caused this, I noticed that it incidentally fixes a bug in setting_bool_str_to_bool(), which was using a function pointer from the wrong part of a union. I doubt this makes problem. Sorry if I didn't comment all that I changed. There were many bugs and weak implementation. And there are still some that I am trying to fix. ___ Reply to this item at: http://gna.org/patch/?1983 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1983] Cleanup for 'enum' options
Follow-up Comment #4, patch #1983 (project freeciv): While staring at the patch to work out what could possibly have caused this, I noticed that it incidentally fixes a bug in setting_bool_str_to_bool(), which was using a function pointer from the wrong part of a union. This could have been causing widespread, possibly machine-dependent carnage with loading boolean server options, I guess. I think the bug was introduced by r17554, patch #1726, 2010-07-10. Perhaps this could explain the behaviour I'm seeing above by some complicated chain of events I haven't worked out. I don't know if it is the cause of this bug but it is a bug nevertheless; I will create a patch for it. ___ Reply to this item at: http://gna.org/patch/?1983 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1983] Cleanup for 'enum' options
Follow-up Comment #5, patch #1983 (project freeciv): Sorry, I wasn't clear; pepeto has already fixed it. (Unless I've missed a different bug?) ___ Reply to this item at: http://gna.org/patch/?1983 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1983] Cleanup for 'enum' options
URL: http://gna.org/patch/?1983 Summary: Cleanup for 'enum' options Project: Freeciv Submitted by: pepeto Submitted on: jeudi 23.09.2010 à 18:27 Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: Split the value descriptions into 2 strings. One for the long compatibility string, and a second to describe to the user (translated). After applying this patch, this will need a capability string update. ___ File Attachments: --- Date: jeudi 23.09.2010 à 18:27 Name: trunk_option_enum_cleanup.diff Size: 45 ko By: pepeto http://gna.org/patch/download.php?file_id=10418 ___ Reply to this item at: http://gna.org/patch/?1983 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1983] Cleanup for 'enum' options
Update of patch #1983 (project freeciv): Depends on: = patch #1982 ___ Reply to this item at: http://gna.org/patch/?1983 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
