[Freeciv-Dev] [patch #2286] AI module directory structure
Follow-up Comment #8, patch #2286 (project freeciv): Attached patch (committed immediately) fixes up POTFILES.in after this. (file #13234) ___ Additional Item Attachment: File name: trunk-default-ai-potfiles.diff Size:0 KB ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
Update of patch #2286 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
Update of patch #2286 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #5: One has to svn mv all .c and .h files from ai/ to ai/default/ and then apply attached patch to build default ai from those moved sources. (file #13117) ___ Additional Item Attachment: File name: DefAiInOwnDir.diff Size:3 KB ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
Follow-up Comment #4, patch #2286 (project freeciv): Even when code has been refactored so that there is clean module interface between server common code and default ai, default ai is not modular internally. It's not trivial to take some part of it as common ai code that does not depend (call functions) on remaining parts. So, I'm even more convinced than before that next step as soon as remaining direct calls from server common code are weeded out, is to move all current default ai code to ai/default directory and to default ai module. Once we reach that point, we can consider this ticket finished. I'm not against later refactoring of the code so that some parts of the code are again moved from default ai module to common ai code. I'm just saying that it requires refactoring = work = time, and meanwhile we can have default ai as real module only by moving all the code to that module. ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
Follow-up Comment #2, patch #2286 (project freeciv): Patch moving default and stub AIs to their own subdirectories. In addition to this patch one has to mv defaultai.[c|h] to ai/default/ and stubai.c to ai/stub/ (file #11793) ___ Additional Item Attachment: File name: AiModSubdirs_2286.diff Size:3 KB ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
Update of patch #2286 (project freeciv): Depends on: = patch #2285 ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
URL: http://gna.org/patch/?2286 Summary: AI module directory structure Project: Freeciv Submitted by: cazfi Submitted on: Sat 08 Jan 2011 01:39:22 PM EET Category: ai Priority: 5 - Normal Status: None Privacy: Public Assigned to: cazfi Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: Following discussion on patch #1819, ai directory structure should be adjusted. It should be remembered that there could be separate AI module projects not part of Freeciv source tree at all. Here we, of course, discuss only those modules (if there ever is more than one) that live in official Freeciv project. If there ever is only one real AI module in our tree, current situation (all code in ai/) would suffice. For more modules, and maybe cleaner even for one module situation, there could be module specific subdirectories under AI. At first phase all code that belongs to loadable module should go to its subdirectory, and code for library linked to server should remain in ai/ root. In my opinion goal should be that there is no code in ai/ root, i.e, no AI specific code linked to server. There is already server/advisors directory for code that can help all players. As code reorganization continues, current code from ai/ root should be moved to default ai module specific subdirectory, i.e, to loadable module. Anyway, as I think we agree on first step, I can prepare patch for that. ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
Follow-up Comment #1, patch #2286 (project freeciv): For more modules, and maybe cleaner even for one module situation, there could be module specific subdirectories under AI. At first phase all code that belongs to loadable module should go to its subdirectory, and code for library linked to server should remain in ai/ root. In my opinion goal should be that there is no code in ai/ root, i.e, no AI specific code linked to server. There is already server/advisors directory for code that can help all players. As code reorganization continues, current code from ai/ root should be moved to default ai module specific subdirectory, i.e, to loadable module. I think that is a good idea! Without loadable modules, the default AI is build as a lib using the files in ./ai. Else the modules are build (one of them is the default ai) using special files in the corresponding subdirectory (i.e. ./ai/ai-default, ./ai/ai-stub or ./ai/ai-lua). ___ Reply to this item at: http://gna.org/patch/?2286 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
