[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Marko Lindqvist]

Update of patch #3726 (project freeciv):

 Planned Release:   2.5.0 =>


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Marko Lindqvist]

Update of patch #3726 (project freeciv):

 Assigned to:   cazfi => None   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Marko Lindqvist]

Follow-up Comment #5, patch #3726 (project freeciv):

Could you produce new version of this patch to go in before S2_5 branching in
a month?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Marko Lindqvist]

Follow-up Comment #4, patch #3726 (project freeciv):

save_command() should cmd_reply(C_FAIL) when appropriate and return FALSE in
such a case.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Davide Baldini]

Follow-up Comment #3, patch #3726 (project freeciv):

[ Ending piece - "browser authonomously submitted the post before I completed
it" ]

...

I could complete the return value's climbing chain of function up to
handle_stdin_input_real(), making things logically cleaner.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Davide Baldini]

Follow-up Comment #2, patch #3726 (project freeciv):

In its current state, the proposed patch doesn't touch how the save functions
behave, and it just reports upwards in the functions chain whether a failure
has been detected.
Such report emerges up to save_command() in form of return value, and there it
can be checked. The value is not returned back to handle_stdin_input_real()
too, because it's not actually needed, and because the patch was taken off
Greatturn, which fork()s save_command() to speed up the saving time and hence
it can pass no value back to handle_stdin_input_real().

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Marko Lindqvist]

Follow-up Comment #1, patch #3726 (project freeciv):

Reading the patch alone (not checking existing context from sources) it seems
that even after noticed failure you still continue to try to do everything
inside that particular function as if everything succeeded. At least executing
secfile_save() after secfile creation has already failed seems like wrong
thing to do.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Marko Lindqvist]

Update of patch #3726 (project freeciv):

Priority: 3 - Low => 5 - Normal 
 Assigned to:None => cazfi  
 Planned Release: => 2.5.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

[Davide Baldini]

URL:
  

 Summary: Booleanize all save functions for savegame v2
 Project: Freeciv
Submitted by: davide_at_debian
Submitted on: Thu 21 Feb 2013 04:16:25 AM GMT
Category: general
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Booleanize the structure of functions below save_command() for savegame
version 2.

Currently, failures to save the game are only textually reported to users but
are not treated by the server, which is bad for automated, self-managed
servers running 24/7, such as Longturn, Greatturn and similar.

This patch intercepts all save failures along the functions chain beneath
save_command(), and makes a boolean available to let the machine check the
result.

Since when such save failures occur (various assert fails) they usually
compromise any other future saves too, Greatturn uses this to automatically
revert the game to the last functioning savefile, 10 minutes back.

Other case usage for this could be a Lua handle to send a warning email to the
server operator, etc.



___

File Attachments:


---
Date: Thu 21 Feb 2013 04:16:25 AM GMT  Name: save_booleanized.patch  Size: 6kB
  By: davide_at_debian



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev