Update of patch #3869 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #1, patch #3869 (project freeciv):
README.rulesets has list of units that ruleset format restrictions require to
be of certain move type. Assuming that this patch is sufficient to make
non-land-moving partisans possible, they should be removed from that listing.
Follow-up Comment #2, patch #3869 (project freeciv):
Thanks for pointing that out: I was so concerned about not attempting to place
Land-moving partisans on non-native Land terrain that I completely missed that
this also enabled non-land-moving partisans. Updated patch attached.
(file #17811)
Update of patch #3869 (project freeciv):
Status:None = Ready For Test
Assigned to:None = cazfi
Planned Release: = 2.3.5, 2.4.0, 2.5.0
Follow-up Comment #4, patch #3869 (project freeciv):
There's two ways to solve the prior bug: either backport this patch
(potentially allowing non-Land partisans), or add a nativity check in addition
to the terrain class check. Which do you prefer? I'm tempted to add both
checks, because it
Follow-up Comment #5, patch #3869 (project freeciv):
Two checks version has also the *benefit* of not allowing non-Land partisans -
introducing those would be bordercase of breaking ruleset format freeze (if
someone then creates ruleset with non-Land partisans, it wouldn't work with
older
Follow-up Comment #6, patch #3869 (project freeciv):
Excellent! I like something that benefits not only me (saves lots of time),
but also benefits all the users (no confusion about potential ruleset
incompatibility). Attached are the S2_3 and S2_4 patches: identical aside
from offsets.
(file
URL:
http://gna.org/patch/?3869
Summary: Place partisans based on nativity
Project: Freeciv
Submitted by: persia
Submitted on: Mon 22 Apr 2013 09:28:49 AM JST
Category: general
Priority: 5 - Normal
