[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-25 Thread Marko Lindqvist
Update of patch #4077 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #10, patch #4077 (project freeciv): Update to compile on top of current SVN. (file #18719) ___ Additional Item Attachment: File name: action_enablers_base.patch Size:28 KB

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #8, patch #4077 (project freeciv): Address review comments. (file #18713) ___ Additional Item Attachment: File name: action_enablers.patch Size:46 KB ___

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #9, patch #4077 (project freeciv): I just uploaded the wrong patch. Here is the correct one. (file #18716) ___ Additional Item Attachment: File name: action_enablers.patch Size:28 KB

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-17 Thread Sveinung Kvilhaugsvik
Follow-up Comment #7, patch #4077 (project freeciv): Read the pathc, not tested yet. Thank you for your reviews. (I see that I need to work more on my ability to spot spelling mistakes and style mistakes) Looks promising I'm glad to hear it. I found some nitpicking I probably won't be able

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-16 Thread Marko Lindqvist
Follow-up Comment #4, patch #4077 (project freeciv): Is untested code preferred over ignoring the secondary clients? Code that compiles is better than one that doesn't. Much of the code is identical enough between the clients that you can relatively safely do changes identical to ones you

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-16 Thread Marko Lindqvist
Follow-up Comment #5, patch #4077 (project freeciv): Regarding Xaw-client: it too has actions.[ch] module. Either one of the actions.[ch] modules (header files at least) needs to be renamed. I think it's the xaw one, despite being there first. Common code should take presedence in using common

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-16 Thread Marko Lindqvist
Follow-up Comment #6, patch #4077 (project freeciv): Read the pathc, not tested yet. Looks promising, though I found some nitpicking: - As you touch the code blocks in clients by moving them, you could and should fix the style: if(xxx) single_line(); - if (xxx) { single_line(); } - There

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-08 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4077 Summary: action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit Project: Freeciv Submitted by: sveinung Submitted on: Thu 08 Aug 2013 07:45:19 PM GMT

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-08 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4077 (project freeciv): Forgot to mention: the changes to the Xaw isn't tested as it compiles but won't start (no matter if this patch is applied or not). ___ Reply to this item at:

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-08 Thread Marko Lindqvist
Follow-up Comment #2, patch #4077 (project freeciv): Forgot to mention: the changes to the Xaw isn't tested as it compiles but won't start (no matter if this patch is applied or not). Starts here without the patch (not tested with the patch). Though old xaw-client still relies on server

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-08 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #4077 (project freeciv): Actually, our commit rules wouldn't require us to make changes to secondary clients even to keep them compiling. Is untested code preferred over ignoring the secondary clients? ___