[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-12 Thread Sveinung Kvilhaugsvik 
Update of patch #4169 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Sveinung Kvilhaugsvik 
Update of patch #4169 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Marko Lindqvist 
Follow-up Comment #2, patch #4169 (project freeciv):

> Change SDL2 even if it won't compile (no matter if this patch
> is applied or not).

You mean there's a compilation bug, or that you don't have SDL2 libraries to
build it against?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Marko Lindqvist 
Follow-up Comment #3, patch #4169 (project freeciv):

Anyway, your patch does not break sdl2-client compilation here. And
functionality cannot be tested as sdl2-client still misses even proper
initialization code.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #4, patch #4169 (project freeciv):

> Anyway, your patch does not break sdl2-client compilation here.
Thank you for testing it for me, Marko.

>  You mean there's a compilation bug, or that you don't have SDL2 libraries
to build it against?
Yes. See bug #21125.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-10 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #1, patch #4169 (project freeciv):

New version. Changes:
 * change qt, gtk2 and sdl as well. SDL had already merged spy vs city and
diplomat vs city. Change SDL2 even if it won't compile (no matter if this
patch is applied or not).
 * gtk2, gtk3, sdl: blank out the potential targets before starting like the
qt client does.
 * use an array for the different potential targets. Limit it to one unit and
one city.

(file #18957)
___

Additional Item Attachment:

File name: merge_spy_gui_menues.patch Size:68 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4169] Generate the spy action dialog action by action.

2013-09-09 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Generate the spy action dialog action by action.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 09 Sep 2013 10:43:13 PM GMT
Category: client
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Generate the spy action dialog action by action in stead of all at once in
three different places.

This proof of concept version is only for the gtk3 client.
 * Only show an action if it is enabled like the qt client and the SDL client
does. This makes them less discoverable. One the other hand the number of
actions can increase without overloading the user.
 * Generate spy vs city actions, diplomat vs city actions and spy/diplomat vs
unit in the same dialog.




___

File Attachments:


---
Date: Mon 09 Sep 2013 10:43:13 PM GMT  Name: merge_spy_gui_menues.patch  Size:
15kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev