[Freeciv-Dev] [patch #4799] Unhardcode IgWall
Update of patch #4799 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4799 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4799] Unhardcode IgWall
Follow-up Comment #4, patch #4799 (project freeciv): - Changes needed to stub ruleset (file #21147) ___ Additional Item Attachment: File name: IgWallRm-4.patch.bz2 Size:6 KB ___ Reply to this item at: http://gna.org/patch/?4799 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4799] Unhardcode IgWall
Follow-up Comment #2, patch #4799 (project freeciv): This patch would benefit also from an update to doc/README.effects, removing the IgWall comment from the Defend_Bonus explanation. ___ Reply to this item at: http://gna.org/patch/?4799 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4799] Unhardcode IgWall
Follow-up Comment #3, patch #4799 (project freeciv): - Updated to apply against curretn svn HEAD - Updated README.effects (file #21116) ___ Additional Item Attachment: File name: IgWallRm-3.patch.bz2 Size:6 KB ___ Reply to this item at: http://gna.org/patch/?4799 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4799] Unhardcode IgWall
Update of patch #4799 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: - Removed Howitzer flag, effects use UnitType requirement instead. Updated static unit texts as they don't get the flag releated help. (file #21097) ___ Additional Item Attachment: File name: IgWallRm-2.patch.bz2 Size:6 KB ___ Reply to this item at: http://gna.org/patch/?4799 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4799] Unhardcode IgWall
URL: http://gna.org/patch/?4799 Summary: Unhardcode IgWall Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 05:46:54 AM EEST Category: general Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Attached patch removes IgWall unit type flag. It has never been very clean implementation in that it causes unit to ignore *any* kind of Defend_Bonus effects, with no way of ruleset author to affect that. Since we have UnitFlag requirement type and user defined unit type flags, it's much better to implement this kind of ruleset features as negated (not present) requirements for the defense bonus effects. In addition to removing the IgWall -flag from the engine, attached patch adds Howitzer user defined flag to rulesets having IgWall Howitzer. I'm going to change that to next version of the patch, though. As there's just one unit type where it applies, it's better to use UnitType requirement directly than UnitFlag. ___ File Attachments: --- Date: Fri 13 Jun 2014 05:46:54 AM EEST Name: IgWallRm.patch.bz2 Size: 6kB By: cazfi http://gna.org/patch/download.php?file_id=20993 ___ Reply to this item at: http://gna.org/patch/?4799 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
