[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

[Emmet Hikory]

Update of patch #4934 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

[Emmet Hikory]

Follow-up Comment #2, patch #4934 (project freeciv):

Conveniently the same patch applies, builds, and runs for all targeted
branches.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

[Marko Lindqvist]

Update of patch #4934 (project freeciv):

 Planned Release:   2.6.0 => 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #1:

We've committed other recent low-risk (i.e. all but unit/city hash rewrite)
optimizations to stable branches too. 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

[Emmet Hikory]

URL:
  

 Summary: Use macros for uclass_index() and utype_class()
 Project: Freeciv
Submitted by: persia
Submitted on: Sat 12 Jul 2014 04:32:21 PM JST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: persia
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

In testing patch #4933, I noticed nearly 3% of calls seemed to be to
uclass_index() or utype_class().  Replacing these with macros seems to remove
at least this much runtime from execution entirely.  Oddly, in one autogame, I
saved 10% "user" time (as measured by time(1)), with the same autogame result,
which is too much improvement to be explained by this patch, making me worry
I've done something wrong with the macro conversion (although other tests
showed improvements more in line with expectations).



___

File Attachments:


---
Date: Sat 12 Jul 2014 04:32:21 PM JST  Name:
use-macros-for-uclass_index-and-utype_class.patch  Size: 3kB   By: persia



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev