[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Update of bug #21151 (project freeciv):

 Planned Release:   2.4.1,2.5.0,2.6.0 =>


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Follow-up Comment #8, bug #21151 (project freeciv):

Patch for freed player color issue attached to bug #21116.

Don't know for sure if it's fix the reported crash.

> However, I'm generally uneasy about enumerating tilesets through 
> tileset_read_toplevel() -- it's documented as having side-effects
> [...]
I've split this concern into a new bug #21263.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Follow-up Comment #7, bug #21151 (project freeciv):

Bug #21074 might be another report of a crash related to the local options
dialog (it's not entirely clear).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Update of bug #21151 (project freeciv):

 Planned Release: => 2.4.1,2.5.0,2.6.0  

___

Follow-up Comment #6:

I think I've got it.

The options dialog calls get_tileset_list() to get the list of tilesets. The
first time it's called (which is not until the option dialog is opened for the
first time), it repeatedly calls tileset_read_toplevel() and tileset_free() on
a local struct tileset.

tileset_free() itself calls tileset_player_free(), but on the *global* tileset
rather than the local t. That's clearly a bug, and fixing it fixes the
assertion-failures-and-black-background symptom for me.

However, I'm generally uneasy about enumerating tilesets through
tileset_read_toplevel() -- it's documented as having side-effects, and whether
or not those comments are correct, it certainly calls
set_city_names_font_sizes() which has global side-effects. Dunno whether
that's best considered a bug in tileset_read_toplevel().

(I don't know if any of this has any bearing on the crash originally reported.
I haven't spotted a way this fault can cause badness like a NULL pointer
dereference.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Follow-up Comment #5, bug #21151 (project freeciv):

(from chrisk on freeciv-dev)

>> Is it possible that this was the option you'd changed when you 
>> did the "save -> crash"?
> Yes, this is very much possible.
> Christian

In other news, if I have solid colour configured, it immediately goes black
with assertion failures when I just *open* the local settings dialog. That's
deeply fishy.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Follow-up Comment #4, bug #21151 (project freeciv):

Ah, my confusion is caused by it making a difference whether I change the
option via View > Options > Local client (troublesome), or via the View menu
(works fine). Interesting.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Follow-up Comment #3, bug #21151 (project freeciv):

> A quick test with 2.4.0 readily reproduces this assertion 
> failure, and all players' units have black background -- so 
> this option does seem to be broken. 
Well, I *could* reproduce it -- turning on the option after starting the
client with it off, or even turning it off and on again after starting with it
on, readily showed this symptom. But now (after a recompile) I can't reproduce
it at all.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Christian Knoke]

please feed into gna

On Sun, Nov 03, 2013 at 02:58:03PM +0100, Jacob Nevins wrote:
> Follow-up Comment #2, bug #21151 (project freeciv):
> 
> I think this assertion failure can only occur if the client has "Solid unit
> background color" (solid_color_behind_units) set.
> 
> A quick test with 2.4.0 readily reproduces this assertion failure, and all
> players' units have black background -- so this option does seem to be
> broken.
> 
> Is it possible that this was the option you'd changed when you did the "save
> -> crash"?

Yes, this is very much possible.

Christian

-- 
* Christian Knoke (mobil)  *  http://cknoke.de*

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Follow-up Comment #2, bug #21151 (project freeciv):

I think this assertion failure can only occur if the client has "Solid unit
background color" (solid_color_behind_units) set.

A quick test with 2.4.0 readily reproduces this assertion failure, and all
players' units have black background -- so this option does seem to be
broken.

Is it possible that this was the option you'd changed when you did the "save
-> crash"?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Follow-up Comment #1, bug #21151 (project freeciv):

> I append a logfile, which contains, connected or not, a lot of 
> ...
> 1: in fill_sprite_array() [tilespec.c::4554]: assertion
't->sprites.player[player_index(owner)].background != NULL' failed.
Interesting. I suspect it's not related to your other symptom, but I wonder if
it's related to bug #21116?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[Christian Knoke]

Update of bug #21151 (project freeciv):

 Release: => 2.4.0  


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] bug #21151 2.4.0 GTK2 client crash on save local options

[Jacob Nevins]

Christian Knoke writes:
> Think this one didn't make it to the list (why?):
> http://gna.org/bugs/index.php?21151

I saw it, as did the list archive:

Maybe you didn't see it because you are in the From: line?

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] bug #21151 2.4.0 GTK2 client crash on save local options

[Christian Knoke]

Hello.

Think this one didn't make it to the list (why?):

http://gna.org/bugs/index.php?21151

quote:

Hello,

GTK2 client self-compiled frpm svn on i386

Start client, new game, start, local options, save -> crash

I append a logfile, which contains, connected or not, a lot of

1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/
1: in fill_sprite_array() [tilespec.c::4554]: assertion
't->sprites.player[player_index(owner)].background != NULL' failed.
1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/
1: in fill_sprite_array() [tilespec.c::4554]: assertion
't->sprites.player[player_index(owner)].background != NULL' failed.
1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/
1: in fill_sprite_array() [tilespec.c::4554]: assertion
't->sprites.player[player_index(owner)].background != NULL' failed.
1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/

Christian 

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21151] 2.4.0 GTK2 client crash on save local options

[anonymous]

URL:
  

 Summary: 2.4.0 GTK2 client crash on save local options
 Project: Freeciv
Submitted by: None
Submitted on: Fr 20 Sep 2013 18:33:01 UTC
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: chr...@cknoke.de
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Hello,

GTK2 client self-compiled frpm svn on i386

Start client, new game, start, local options, save -> crash

I append a logfile, which contains, connected or not, a lot of

1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/
1: in fill_sprite_array() [tilespec.c::4554]: assertion
't->sprites.player[player_index(owner)].background != NULL' failed.
1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/
1: in fill_sprite_array() [tilespec.c::4554]: assertion
't->sprites.player[player_index(owner)].background != NULL' failed.
1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/
1: in fill_sprite_array() [tilespec.c::4554]: assertion
't->sprites.player[player_index(owner)].background != NULL' failed.
1: in fill_sprite_array() [tilespec.c::4554]: Bitte berichten Sie diese
Fehlermeldung unter http://gna.org/projects/freeciv/

Christian




___

File Attachments:


---
Date: Fr 20 Sep 2013 18:33:01 UTC  Name: freeciv.log.bz2  Size: 19kB   By:
None



___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev