<URL: http://bugs.freeciv.org/Ticket/Display.html?id=17436 >

On 1/22/07, Egor Vyscrebentsov <[EMAIL PROTECTED]> wrote:
>
> > On 1/19/07, Marko Lindqvist wrote:
> > >  handle_nation_select_req() always marks players previous nation
> > > available. This is not right when nation is not changed, but only
> > > leader name or sex. player_set_nation() sets nation->player correctly,
> > > so handle_nation_select_req() should not directly touch it at all.
>
> >-  if (old_nation != NO_NATION_SELECTED) {
> >-    old_nation->player = NULL;
> >-  }
>
> Shouldn't it be
>
>   if ((old_nation != new_nation) && (old_nation != NO_NATION_SELECTED)) {
>     old_nation->player = NULL;
>   }
>
> ? (Otherwise it seemed to me that nation will not be freed...)

 player_set_nation() takes care of that too.


 - ML



_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to