Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/20/07, Daniel Markstedt [EMAIL PROTECTED] wrote: Or we could use my Pirate nation. Agreed, the effect would be slightly humorous. But so is having Conestoga wagons in the year 4000 BC. ;) We cannot currently control which barbarian player gets which nation. But once we do, Pirates will be good name for sea barbarians. Meanwhile I don't think it a big problem that Pirates might be land barbarian and Barbarians sea barbarians. So I'm all for naming another barbarian nation Pirates. :-) Just noticed code comment suggesting about Raiders and Barbarians. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have two barbarian players but only one nation which they share. This means that nation-player points to one of them, but for another pplayer-nation-player != pplayer. This causes problems. We definitely need to have two separate barbarian nations. For S2_1 adding ruleset for another barbarian nation is sufficient, but in trunk code should be changed so that it doesn't even accept same nation for both barbarian players. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have two barbarian players but only one nation which they share. This means that nation-player points to one of them, but for another pplayer-nation-player != pplayer. This causes problems. We definitely need to have two separate barbarian nations. For S2_1 adding ruleset for another barbarian nation is sufficient, but in trunk code should be changed so that it doesn't even accept same nation for both barbarian players. - ML Do the two nations have to have different names? ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Daniel Markstedt [EMAIL PROTECTED] wrote: On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have two barbarian players but only one nation which they share. This means that nation-player points to one of them, but for another pplayer-nation-player != pplayer. This causes problems. We definitely need to have two separate barbarian nations. For S2_1 adding ruleset for another barbarian nation is sufficient, but in trunk code should be changed so that it doesn't even accept same nation for both barbarian players. Do the two nations have to have different names? Unless freeciv refuses to load two nations with the same name, they can have same name. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Daniel Markstedt [EMAIL PROTECTED] wrote: On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have two barbarian players but only one nation which they share. This means that nation-player points to one of them, but for another pplayer-nation-player != pplayer. This causes problems. We definitely need to have two separate barbarian nations. For S2_1 adding ruleset for another barbarian nation is sufficient, but in trunk code should be changed so that it doesn't even accept same nation for both barbarian players. Do the two nations have to have different names? Unless freeciv refuses to load two nations with the same name, they can have same name. - ML Or we could use my Pirate nation. Agreed, the effect would be slightly humorous. But so is having Conestoga wagons in the year 4000 BC. ;) http://bugs.freeciv.org/Ticket/Display.html?id=18430 ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Daniel Markstedt [EMAIL PROTECTED] wrote: Or we could use my Pirate nation. Agreed, the effect would be slightly humorous. But so is having Conestoga wagons in the year 4000 BC. ;) We cannot currently control which barbarian player gets which nation. But once we do, Pirates will be good name for sea barbarians. Meanwhile I don't think it a big problem that Pirates might be land barbarian and Barbarians sea barbarians. So I'm all for naming another barbarian nation Pirates. :-) - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev