Re: [Freeciv-Dev] (PR#39368) pregame: aifill and vote

2007-05-16 Thread Pepeto _ 

http://bugs.freeciv.org/Ticket/Display.html?id=39368 >

I made a new patch...

--- 12954/server/stdinhand.c2007-05-14 10:32:22.0 +0200
+++ test/server/stdinhand.c 2007-05-16 10:33:46.0 +0200
@@ -3457,8 +3457,10 @@
 return FALSE;
   }

-  if (caller
+  if (server_state != PRE_GAME_STATE
+  && caller
   && caller->player
+  && !caller->observer /* don't allow observers to ask votes */
   && !check
   && caller->access_level == ALLOW_INFO
   && commands[cmd].level == ALLOW_CTRL) {

_
Personnalisez votre Messenger avec Live.com 
http://www.windowslive.fr/livecom/

--- 12954/server/stdinhand.c	2007-05-14 10:32:22.0 +0200
+++ test/server/stdinhand.c	2007-05-16 10:33:46.0 +0200
@@ -3457,8 +3457,10 @@
 return FALSE;
   }
 
-  if (caller 
+  if (server_state != PRE_GAME_STATE
+  && caller
   && caller->player
+  && !caller->observer /* don't allow observers to ask votes */
   && !check
   && caller->access_level == ALLOW_INFO
   && commands[cmd].level == ALLOW_CTRL) {

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39368) pregame: aifill and vote

2007-05-14 Thread Pepeto _ 

http://bugs.freeciv.org/Ticket/Display.html?id=39368 >




>From: "Per I. Mathisen" <[EMAIL PROTECTED]>
>Reply-To: [EMAIL PROTECTED]
>To: [EMAIL PROTECTED]
>Subject: Re: [Freeciv-Dev] (PR#39368) pregame: aifill and vote
>Date: Mon, 14 May 2007 05:08:16 -0700
>
>
>http://bugs.freeciv.org/Ticket/Display.html?id=39368 >
>
>On Mon, 14 May 2007, Pepeto _ wrote:
> > In pregame, you can create votes, but you cannot use /vote. And more, if 
>you
> > The vote passes before it exists :)
> > I don't know if the main problem is you can ask vote in pregame
>
>You should not be able to ask for a vote in pregame in 2.1 or trunk.
>
>- Per
>
>

Then apply the second part of the patch. It forbids too observer to ask 
votes while the game is running.

_
Ten :  Messenger en illimité sur votre mobile !  
http://mobile.live.fr/messenger/ten/



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39368) pregame: aifill and vote

2007-05-14 Thread Per I. Mathisen 

http://bugs.freeciv.org/Ticket/Display.html?id=39368 >

On Mon, 14 May 2007, Pepeto _ wrote:
> In pregame, you can create votes, but you cannot use /vote. And more, if you
> The vote passes before it exists :)
> I don't know if the main problem is you can ask vote in pregame

You should not be able to ask for a vote in pregame in 2.1 or trunk.

   - Per



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev