Re: [Freeciv-Dev] [patch #2912] Update of the Filipino nation

2011-08-22 Thread patrick kelle
But isn't that exactly what I did?
Or do you want any other living leader to be added?

patrick


On Sun, Aug 21, 2011 at 3:13 AM, Daniel Markstedt markst...@gmail.com wrote:
 We allow two living leaders per nation: one of each sex. All official
 nation related guidelines are documented in doc/README.nations - a
 recommended read!

 Daniel

 On Sat, Aug 20, 2011 at 1:10 AM, patrick kelle
 patrick.kell...@gmail.com wrote:
 I was not aware of that fact.
 When I did my work I took the German nation as reference and it
 includes Angela Merkel which is still pretty alive.
 We surly could add Corazon Aquino in any way. If you want the other
 two removed say so and I can make a new patch.
 On a later update I also wanted to add terrain details for the cities
 as for example in the German nation.


 patrick


 On Sat, Aug 20, 2011 at 4:22 AM, Daniel Markstedt
 no-reply.invalid-addr...@gna.org wrote:

 Update of patch #2912 (project freeciv):

                Category:                    None = rulesets
             Assigned to:                    None = mixcoatl

    ___

 Follow-up Comment #1:

 Patch looks good.

 Just one comment: The two added leaders are both living persons as well as
 active politicians. We have a history in the Freeciv project to try to limit
 the inclusion of such leaders. Would it make sense to add someone like say
 Corazon Aquino instead?

    ___

 Reply to this item at:

  http://gna.org/patch/?2912

 ___
  Message sent via/by Gna!
  http://gna.org/





___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [patch #2912] Update of the Filipino nation

2011-08-20 Thread patrick kelle
I was not aware of that fact.
When I did my work I took the German nation as reference and it
includes Angela Merkel which is still pretty alive.
We surly could add Corazon Aquino in any way. If you want the other
two removed say so and I can make a new patch.
On a later update I also wanted to add terrain details for the cities
as for example in the German nation.


patrick


On Sat, Aug 20, 2011 at 4:22 AM, Daniel Markstedt
no-reply.invalid-addr...@gna.org wrote:

 Update of patch #2912 (project freeciv):

                Category:                    None = rulesets
             Assigned to:                    None = mixcoatl

    ___

 Follow-up Comment #1:

 Patch looks good.

 Just one comment: The two added leaders are both living persons as well as
 active politicians. We have a history in the Freeciv project to try to limit
 the inclusion of such leaders. Would it make sense to add someone like say
 Corazon Aquino instead?

    ___

 Reply to this item at:

  http://gna.org/patch/?2912

 ___
  Message sent via/by Gna!
  http://gna.org/



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [patch #2912] Update of the Filipino nation

2011-08-20 Thread Daniel Markstedt
We allow two living leaders per nation: one of each sex. All official
nation related guidelines are documented in doc/README.nations - a
recommended read!

Daniel

On Sat, Aug 20, 2011 at 1:10 AM, patrick kelle
patrick.kell...@gmail.com wrote:
 I was not aware of that fact.
 When I did my work I took the German nation as reference and it
 includes Angela Merkel which is still pretty alive.
 We surly could add Corazon Aquino in any way. If you want the other
 two removed say so and I can make a new patch.
 On a later update I also wanted to add terrain details for the cities
 as for example in the German nation.


 patrick


 On Sat, Aug 20, 2011 at 4:22 AM, Daniel Markstedt
 no-reply.invalid-addr...@gna.org wrote:

 Update of patch #2912 (project freeciv):

                Category:                    None = rulesets
             Assigned to:                    None = mixcoatl

    ___

 Follow-up Comment #1:

 Patch looks good.

 Just one comment: The two added leaders are both living persons as well as
 active politicians. We have a history in the Freeciv project to try to limit
 the inclusion of such leaders. Would it make sense to add someone like say
 Corazon Aquino instead?

    ___

 Reply to this item at:

  http://gna.org/patch/?2912

 ___
  Message sent via/by Gna!
  http://gna.org/




___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev