Re: [Freecol-developers] 0.11.4

2015-08-04 Thread Michael T. Pope
On Mon, 3 Aug 2015 21:28:15 +0200 win...@genial.ms wrote: >>[who knows what the current active unit is?] > Well IGC does not know, it asks (Swing)GUI (which routes that to MapViewer) I think this is overstating the case. IGC calls getActiveUnit in three places: 1. saveGame, because the active uni

Re: [Freecol-developers] 0.11.4

2015-08-03 Thread winter
Hi, > Gesendet: Montag, 03. August 2015 um 12:26 Uhr > Von: "Michael T. Pope" > An: "FreeCol Developers" > Betreff: Re: [Freecol-developers] 0.11.4 > > [Resending to the list, where it should have gone first time, sorry > wintertime] > NP. There ha

Re: [Freecol-developers] 0.11.4

2015-08-03 Thread Michael T. Pope
[Resending to the list, where it should have gone first time, sorry wintertime] On Sat, 1 Aug 2015 14:56:52 +0200 win...@genial.ms wrote: > Btw., I was not happy how your fix did hide the appearance of BR#2806, > as it would just wrongly display the end of turn message instead of the > empty state

Re: [Freecol-developers] 0.11.4

2015-08-01 Thread winter
Hi, > Gesendet: Samstag, 01. August 2015 um 12:57 Uhr > Von: "Michael T. Pope" > An: "FreeCol Developers" > Betreff: Re: [Freecol-developers] 0.11.4 > > On Fri, 31 Jul 2015 19:22:22 +0200 > win...@genial.ms wrote: > > When I saw the diff I sudde

Re: [Freecol-developers] 0.11.4

2015-08-01 Thread Michael T. Pope
On Fri, 31 Jul 2015 19:22:22 +0200 win...@genial.ms wrote: > > Related to this I have just put in the fix for the second race in BR#2867, > > which simplifies the InfoPanel in MOVE_UNITS_MODE (git.1728101). This has > > probably caused more cases of a blank InfoPanel, which will need fixing as > >

Re: [Freecol-developers] 0.11.4

2015-07-31 Thread winter
Hi, > With respect to the setActiveUnit untangling, I looked at git.b8c21dc > where the colony popup went away. I think a case was missed, so I put it > back, > and dropped as many setSelectedTile calls as possible (git.8394732). I might have overlooked it, as I did not think code was relying o

Re: [Freecol-developers] 0.11.4

2015-07-31 Thread Michael T. Pope
On Wed, 29 Jul 2015 18:23:02 +0200 win...@genial.ms wrote: > - I'd like to move some bits and pieces of code between controllers > and gui classes, to get a clearer separation of responsibilities. With respect to the setActiveUnit untangling, I looked at git.b8c21dc where the colony popup went awa

Re: [Freecol-developers] 0.11.4

2015-07-30 Thread Michael T. Pope
On Wed, 29 Jul 2015 18:23:02 +0200 win...@genial.ms wrote: > I saw we have no git tags. I think its customary to do a > git tag -a v0.11.4 I no longer bother with tags. They seem like an old habit from when vcs branching was expensive. I just keep a branch around: git checkout -b 0.11.4 ; git

Re: [Freecol-developers] 0.11.4

2015-07-29 Thread winter
Hi, > The FreeCol 0.11.4 commit has been made (git.ecbc3b7) but the release > upload is stuck at sourceforge. Nevertheless feel free to push on > with anything we have postponed until after release[1]. Hopefully the > download directory will be live by this time tommorow, at which point > I will

[Freecol-developers] 0.11.4

2015-07-29 Thread Michael T. Pope
The FreeCol 0.11.4 commit has been made (git.ecbc3b7) but the release upload is stuck at sourceforge. Nevertheless feel free to push on with anything we have postponed until after release[1]. Hopefully the download directory will be live by this time tommorow, at which point I will upload the web