Re: [Freecol-developers] Joining the developers

2014-04-16 Thread Petr Fišer
I guess I could try to look into BR#2670 during the weekend. Regards, Petr 2014-04-16 14:01 GMT+02:00 Michael T. Pope : > On Wed, 16 Apr 2014 07:04:02 +0200 > Michael Vehrs wrote: >> >- some form of the popup-goes-behind-the-main-window fail, or other >> > lossage that is probably in th

Re: [Freecol-developers] Joining the developers

2014-04-16 Thread Michael T. Pope
On Wed, 16 Apr 2014 07:04:02 +0200 Michael Vehrs wrote: > >- some form of the popup-goes-behind-the-main-window fail, or other > > lossage that is probably in the Java libraries > > At work, I recently switched from Windows XP to Windows 7, and I have > noticed dialog windows opening be

Re: [Freecol-developers] Joining the developers

2014-04-15 Thread Michael Vehrs
On 04/16/2014 04:21 AM, Michael T. Pope wrote: > On Tue, 15 Apr 2014 19:21:37 +0200 > Petr Fišer wrote: >> Glad to help. >> And don't worry about the credit, I don't care about it. :) > No worries. I'd fix it but git is resistant to changing commit messages... > > This is probably a good point to

Re: [Freecol-developers] Joining the developers

2014-04-15 Thread Michael T. Pope
On Tue, 15 Apr 2014 19:21:37 +0200 Petr Fišer wrote: > Glad to help. > And don't worry about the credit, I don't care about it. :) No worries. I'd fix it but git is resistant to changing commit messages... This is probably a good point to comment on the release status. I have been working on t

Re: [Freecol-developers] Joining the developers

2014-04-15 Thread Petr Fišer
Glad to help. And don't worry about the credit, I don't care about it. :) Regards, Petr 2014-04-15 11:27 GMT+02:00 Michael T. Pope : > > On Mon, 14 Apr 2014 22:42:58 +0200 > Petr Fišer wrote: > > Specification looks good to me but I dont understand this: > > > > > made-from="model.goods.food">

Re: [Freecol-developers] Joining the developers

2014-04-15 Thread Michael T. Pope
On Mon, 14 Apr 2014 22:42:58 +0200 Petr Fišer wrote: > Specification looks good to me but I dont understand this: > > made-from="model.goods.food"> > > > > Why is there made-from="model.goods.food" when in the other spec. file is: > > > > > Good catch. That is clearly wrong, t

Re: [Freecol-developers] Joining the developers

2014-04-15 Thread Petr Fišer
Hi, I got it working. Tested it on three games. The indians now don't get any horses unless they receive them as a gift / win them in war / through trade. When sufficient number of horses is present, they breed them. In effect, the fix is similar to the if(...) continue; cycle but now, I believe,

Re: [Freecol-developers] Joining the developers

2014-04-14 Thread Petr Fišer
Ok, I dug into IndianSettlement and found what was happening. Sorry for the previous patch. :D Specification looks good to me but I dont understand this: Why is there made-from="model.goods.food" when in the other spec. file is: ? Anyway I think that still is not what is causin

Re: [Freecol-developers] Joining the developers

2014-04-14 Thread Petr Fišer
I kind of expected that gaining horses on the first contact won't be accepted. :) No problem, I can remove that behavior easily. The problem with production was that original code: List goodsList = spec.getGoodsTypeList(); for (GoodsType g : goodsList) { addGoods(g.getStoredAs(), getTotalProduc

Re: [Freecol-developers] Joining the developers

2014-04-13 Thread Michael T. Pope
On Sun, 13 Apr 2014 20:38:01 +0200 Petr Fišer wrote: > To mitigate the situation, I modified server controller the way > that every time there is FIRST contact of European > nation with natives, the natives gain two horses in their capital. Then the > breeding starts doing its job like I previousl

Re: [Freecol-developers] Joining the developers

2014-04-13 Thread Petr Fišer
Hi guys, I patched up the horses bug (#2684). Philosophy of the bugfix: The indians were gaining horses out of nowhere, because ServerIndianSettlement treated them like any other resource. This led into gaining even 10-15 horses each turn. Now horses are skipped in this step and bred with respect

Re: [Freecol-developers] Joining the developers

2014-03-06 Thread Petr Fišer
Thanks for the hints. I'm on it :) 2014-03-05 22:15 GMT+01:00 Michael T. Pope : > On Wed, 5 Mar 2014 20:17:33 +0100 > Petr Fišer wrote: > > I was playing the game for a while and currently I'd like to contribute > to > > the project. > > Contributors are always welcome. Getting started as a Fr

Re: [Freecol-developers] Joining the developers

2014-03-05 Thread Michael T. Pope
On Wed, 5 Mar 2014 20:17:33 +0100 Petr Fišer wrote: > I was playing the game for a while and currently I'd like to contribute to > the project. Contributors are always welcome. Getting started as a FreeCol contributor is summarized at http://www.freecol.org/how-to-contribute.html. > Is it possi

[Freecol-developers] Joining the developers

2014-03-05 Thread Petr Fišer
Hi guys, I was playing the game for a while and currently I'd like to contribute to the project. Is it possible that I would start with bugfixing something? The one of the bugs - #2684 - looks particularly interesting to me (for a start). Regards, Petr -