Re: [Freecol-developers] test fail

2017-09-11 Thread David Lewis
Updates to the current threads... - The language now reflects that the alarm value is a percentage of a tenth the total value of goods being exchanged in a trade. - Builds for the Mac app are now (finally) working. I'm one step closer to getting nightly/weekend builds published to Github. Stay tu

Re: [Freecol-developers] test fail

2017-09-09 Thread David Lewis
I see what you're saying, and valid points. I'm trying to figure out how to work that in, because if it's a percentage based on total price of goods, then a value above 10 is quite a significant change in native alarm. i.e.: goods with a value of 1064 * .01 * 10 = 106, on a single load of cargo, th

Re: [Freecol-developers] test fail

2017-09-08 Thread Michael T. Pope
On Fri, 08 Sep 2017 17:44:48 + David Lewis wrote: > Yes, I agree, so what I did was change it to a 100th... > > + final int alarmBonus = -Math.round(price * 0.001f * getGame(). > getSpecification() > + .getInteger(GameOptions.ALARM_BONUS_SELL)); > Meaning that if the price of goods is 1064 *

Re: [Freecol-developers] test fail

2017-09-08 Thread David Lewis
Yes, I agree, so what I did was change it to a 100th... + final int alarmBonus = -Math.round(price * 0.001f * getGame(). getSpecification() + .getInteger(GameOptions.ALARM_BONUS_SELL)); Meaning that if the price of goods is 1064 * .001 * 40 (%) = (round) 43 Old value was: 1064/50 = 21. Probably me

Re: [Freecol-developers] test fail

2017-09-07 Thread Michael T. Pope
On Thu, 07 Sep 2017 14:50:32 + David Lewis wrote: > Can you review the open pull requests and if they look good let me know so > I can merge them? I am a bit backlogged ATM, but did have a quick look the other day. There were several issues with the gifts one, but the real showstopper there i

Re: [Freecol-developers] test fail

2017-09-07 Thread David Lewis
Pretty sure it was as a result of the earlier error. So it may be fixed now. I'll take a look. Can you review the open pull requests and if they look good let me know so I can merge them? Thanks! David On Thu, Sep 7, 2017, 4:43 AM Michael T. Pope wrote: > On Thu, 31 Aug 2017 23:24:03 + > D

Re: [Freecol-developers] test fail

2017-09-07 Thread Michael T. Pope
On Thu, 31 Aug 2017 23:24:03 + David Lewis wrote: > Current ant task dist is failing because of: > > installer-translations: > > [java] Could not find net.sf.freecol.tools.InstallerTranslations. Make > sure you have it in your classpath Should be fixed. > freecol-git/build.xml:352: c

Re: [Freecol-developers] test fail

2017-08-31 Thread David Lewis
Travis CI is a hosted continuous integration platform that is free for all open source projects hosted on Github. With just a file called .travis.yml containing some information about our project, we can trigger automated builds with every change to our code base in the master branch, other branche

Re: [Freecol-developers] test fail

2017-08-31 Thread Michael T. Pope
On Thu, 31 Aug 2017 17:30:15 + David Lewis wrote: > Yeah, the tests need a lot of love. I enabled the simpleMove test purely > for the sake of using the client helper tests. Although those should be > their own tests, I am still learning the system, so haven't created a > client test yet. I a

Re: [Freecol-developers] test fail

2017-08-31 Thread David Lewis
Travis is currently only failing on 2 tests, it can't find the sound mixer. Likely because it's a container. -- David [junit] Testcase: testSound(net.sf.freecol.common.sound.SoundTest): FAILED [junit] Could not construct sound player: Mixer unavailable. [junit] junit.framework.Asser

Re: [Freecol-developers] test fail

2017-08-31 Thread David Lewis
Yeah, the tests need a lot of love. I enabled the simpleMove test purely for the sake of using the client helper tests. Although those should be their own tests, I am still learning the system, so haven't created a client test yet. At the moment I'm cleaning up and fixing the build.xml file (creati

Re: [Freecol-developers] test fail

2017-08-31 Thread Michael T. Pope
On Thu, 31 Aug 2017 00:24:31 + David Lewis wrote: > That's odd... it succeeds on my local machine and local build machines > (docker containers), and succeeds on the Travis CI build servers (each run > `ant test`)... > > There are 2 tests that fail on the remote build nodes: mixer isn't > ava

Re: [Freecol-developers] test fail

2017-08-30 Thread David Lewis
That's odd... it succeeds on my local machine and local build machines (docker containers), and succeeds on the Travis CI build servers (each run `ant test`)... https://travis-ci.org/FreeCol/freecol/branches There are 2 tests that fail on the remote build nodes: mixer isn't available on build nod

Re: [Freecol-developers] test fail

2017-08-30 Thread Michael T. Pope
On Wed, 30 Aug 2017 19:10:08 +0930 "Michael T. Pope" wrote: > I just did some play testing... To clarify, I wrote this to David, but mucked up the send. Cheers, Mike Pope pgpvASQ1lteBM.pgp Description: OpenPGP digital signature --