[Freedos-kernel] Re: kernel/kernel fatfs.c,1.52,1.53 proto.h,1.50,1.51 memmgr.c,1.27,1.28

2004-03-22 Thread Eric Auer
Hi, about add_far() pointer normalization: I think it would be better to normalize earlier. If you have a pointer, you normally have a pointer to a STRUCTURE. If the end of the structure ends up with an offset 0x then having the POINTER normalized is not enough. So how do you check the SIZE

Re: [Freedos-kernel] Re: kernel/kernel fatfs.c,1.52,1.53 proto.h,1.50,1.51 memmgr.c,1.27,1.28

2004-03-22 Thread Bart Oldeman
On Mon, 22 Mar 2004, Eric Auer wrote: Hi, about add_far() pointer normalization: I think it would be better to normalize earlier. If you have a pointer, you normally have a pointer to a STRUCTURE. If the end of the structure ends up with an offset 0x then having the POINTER normalized is

Re: [Freedos-kernel] Re: kernel/kernel fatfs.c,1.52,1.53 proto.h,1.50,1.51 memmgr.c,1.27,1.28

2004-03-22 Thread Arkady V.Belousov
Hi! 22--2004 14:23 [EMAIL PROTECTED] (Bart Oldeman) wrote to [EMAIL PROTECTED]: BO add_far is only used at a few select places where we want to have the BO offset part as low as possible. Nothing to do with structures but BO everything to do with potentially large file reads, with read chunk, BO

Re: [Freedos-kernel] Re: kernel/kernel fatfs.c,1.52,1.53 proto.h,1.50,1.51 memmgr.c,1.27,1.28

2004-03-22 Thread tom ehlert
Hello Arkady, AVB Then rename add_far into normalize_ptr and remove misleading. noone is going to rename functions because you don't like the names. AVB Also, AVB I may offer next code to always perform normalization: It's there for some specific purpose. AVB (BTW, is protection AVB from

Re: [Freedos-kernel] Re: kernel/kernel fatfs.c,1.52,1.53 proto.h,1.50,1.51 memmgr.c,1.27,1.28

2004-03-22 Thread Bart Oldeman
On Mon, 22 Mar 2004, tom ehlert wrote: AVB (BTW, is protection AVB from wrapping HMA pointer into IVT by replacing wrapping into start of HMA AVB worth of code?) a working kernel is worth a lot of code (even if you don't see the reason immediately) HANDS OFF THE KERNEL, please. in the end