On Mon, 8 Mar 2004 00:21:41 +0000 (GMT), Bart Oldeman wrote:

Hmm. Further testing seems to reveal that this whole bit isn't valid, as
"findfirst" is not the same as a "dir"!

ie. this whole bit needs to be deleted.

/* Lixing Yuan Patch */
    if (bAllowWildcards)        /* for find first */
    {
      if (*filename != '\0')
        return DE_FILENOTFND;
      memset(fcbname, '?', FNAME_SIZE + FEXT_SIZE);
      return nDirCnt;
    }
    else

it's nowhere documented that c:\dir\ implies c:\dir\*.*
msdos 7.10 returns cy,ax=3 for c:\dir\ (where freedos makes that
c:\dir\*.*) and cy,ax=12 for c:\dir (unless the
dir attribute is in cx -- same as freedos).

"." in itself doesn't matter -- it matters what is in the truename (in
this case c:\ as you have in the comment which indeed does not have a
directory entry but using 12 instead of 3 here -- well I never quite
understood the *exact* differences between 2, 3 and 12 for findfirst,
RBIL doesn't document that very well).

Lucho, can you confirm?

Well, I was tempted to remove the whole code chunk too! And I agree with your thoughts above. But why was this patch introduced by Lixing Juan on 31 May 2000 under the maintainance of James Tabor in the first place? This is a question I can't answer. So I suggest we just comment it out with #if 0 / #endif for now, and I'm copying this message to the lastly specified address of Lixing. He was active with FreeDOS last year so I hope he listens and answers my question :)


Lucho


------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ Freedos-kernel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-kernel

Reply via email to