Re: [Freedos-user] slicer-0.17 error code #2

[Darik Horn]

> I went with gzip first because it’s small and 8086 compatible. But now that 
> it does at least one, it could easily have others added. Like maybe (bz2, 
> p7zip, etc). It wouldn’t take much to add them.

The new gzip feature is likely optimal, especially for 16bit+1meg
machines.  I've done a few more experiments with repacking the floppy
installer and intend to post results later.


___
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user

Re: [Freedos-user] slicer-0.17 error code #2

[Jerome Shidel]

Hi,

> On Dec 16, 2021, at 1:49 PM, Darik Horn  wrote:
> 
> NB: https://gitlab.com/DOSx86/slicer/-/merge_requests/1
> 
> There seems to be a related bug with /e and /i handling, which are
> no-ops on my test machine.

Could be. 

Originally, those switches we designed for mostly creating an archive. I do 
recall thinking it would be nice to have for extraction. However, I’m working 
on so many things now and over the last few years, I don’t recall how much work 
or testing I did to support that. I may have just though “that would be nice, 
but it can wait”. I honestly don’t recall if those do anything on extraction 
right now.  

One such “it can wait until later” involves the pass-through compression. NLS 
file 
https://github.com/shidel/fd-nls/blob/1684a5dfc06bab972e5774917e0e93af4ab7335c/slicer/nls/SLICER.EN#L143
 

 entry it is meant to support more than just gzip.  I went with gzip first 
because it’s small and 8086 compatible. But now that it does at least one, it 
could easily have others added. Like maybe (bz2, p7zip, etc). It wouldn’t take 
much to add them. I just don’t really have the time to do it.  

There are tons of improvements it could use. 

:-)

Jerome


> 
> 
> ___
> Freedos-user mailing list
> Freedos-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freedos-user

___
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user

Re: [Freedos-user] slicer-0.17 error code #2

[Darik Horn]

NB: https://gitlab.com/DOSx86/slicer/-/merge_requests/1

There seems to be a related bug with /e and /i handling, which are
no-ops on my test machine.


___
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user

Re: [Freedos-user] slicer-0.17 error code #2

[Jerome Shidel]

> On Dec 15, 2021, at 7:05 PM, Darik Horn  wrote:
> 
>> Please post a bug report at https://gitlab.com/DOSx86/slicer
> 
> NB:  https://gitlab.com/DOSx86/slicer/-/issues/1
> 
> 
>>> On DOSBox-X, slicer will fail on random files in a way that looks like a 
>>> race condition.
>> 
>> Under the same situation?
> 
> Yes.

Ok. 

Yep, It probably just needs a test put in at 279 
 
before trying to decompress the non-existing, not extracted file.

:-)


> 
> ___
> Freedos-user mailing list
> Freedos-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freedos-user

___
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user

Re: [Freedos-user] slicer-0.17 error code #2

[Darik Horn]

> Please post a bug report at https://gitlab.com/DOSx86/slicer

NB:  https://gitlab.com/DOSx86/slicer/-/issues/1


>> On DOSBox-X, slicer will fail on random files in a way that looks like a 
>> race condition.
>
> Under the same situation?

Yes.


___
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user

Re: [Freedos-user] slicer-0.17 error code #2

[Jerome Shidel]

Hi Darik

> On Dec 15, 2021, at 5:11 PM, Darik Horn  wrote:
> 
> Hi,
> 
> In FreeDOS 1.3 RC5, the new slicer handles file overwrites inconsistently in 
> interactive mode.  Reproduce the bug by doing this:
> 
>   C:\> SLICER /x /f \SLICES\FREEDOS.SAF /g * /O OUT
>   ...
>   Overwrite BIN\FDINST.EXE, (N)o/(Y)es? N
>   
>   gzip: EGA\BIN\ID583S8Q.GZ: not in gzip format
>   FATAL ERROR: error code #2, unspecified error with "EGA\BIN\ID583S8Q.GZ"
> 
> Expected behavior is that SLICER skips the current file and finishes the 
> extraction.
> 
> SLICER behaves as expected on a "Y" input, or in non-interactive mode with 
> the /o switch.
> 
> The given glob expresses the bug on the first call.  If slicer is invoked 
> with a smaller category like "/g Network", then the bug happens on the second 
> call.
> 
> On FreeDOS 1.3 RC5, slicer will always return error code #2 in the same place.

Error 2, means file not found. 

I think I may know what is happening. The addition of pass-thru compression 
support for gzip was added a couple days prior to release of RC5. And was only 
tested in automatic overwrite mode. What I think is probably happening is that 
after you tell it no, it still is trying to pass a non-extracted file to gzip 
which reports an error and extraction stops. I’ll need to look into it. Please 
post a bug report at https://gitlab.com/DOSx86/slicer 
 or on the FreeDOS GitLab Archive at 
https://gitlab.com/FreeDOS/archiver/slicer 
 . That way I don’t forget to take 
care of the issue.

> On DOSBox-X, slicer will fail on random files in a way that looks like a race 
> condition.

Under the same situation?

Jerome

___
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user

[Freedos-user] slicer-0.17 error code #2

[Darik Horn]

Hi,

In FreeDOS 1.3 RC5, the new slicer handles file overwrites inconsistently
in interactive mode.  Reproduce the bug by doing this:

C:\> SLICER /x /f \SLICES\FREEDOS.SAF /g * /O OUT
...
Overwrite BIN\FDINST.EXE, (N)o/(Y)es? N

gzip: EGA\BIN\ID583S8Q.GZ: not in gzip format
FATAL ERROR: error code #2, unspecified error with "EGA\BIN\ID583S8Q.GZ"

Expected behavior is that SLICER skips the current file and finishes the
extraction.

SLICER behaves as expected on a "Y" input, or in non-interactive mode with
the /o switch.

The given glob expresses the bug on the first call.  If slicer is invoked
with a smaller category like "/g Network", then the bug happens on the
second call.

On FreeDOS 1.3 RC5, slicer will always return error code #2 in the same
place.

On DOSBox-X, slicer will fail on random files in a way that looks like a
race condition.
___
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user