[Freedreno] [PATCH 4/6] drm/msm/rd: allow adding addition msg to top of dump

For faults or hangs, it is nice to be able to include a bit more information. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- drivers/gpu/drm/msm/msm_drv.h | 3 ++- drivers/gpu/drm/msm/msm_gpu.c | 2 +- drivers/gpu/drm/msm/msm_rd.c | 15 +-- 3 files changed, 16 insertions

[Freedreno] [PATCH 0/6] drm/msm: GPU debugging enhancements

something useable out of the currently discussed SVM patches. Rob Clark (6): drm/msm: show task cmdline in gpu recovery messages drm/msm: add special _get_vaddr_active() for cmdstream dumps drm/msm: split rd debugfs file drm/msm/rd: allow adding addition msg to top of dump drm/msm: preserve

Re: [Freedreno] freedreno 3D test cases output display

On Wed, Dec 20, 2017 at 1:16 AM, priyanka more wrote: > > Hi, > > I'm working on freedreno 3D test cases, I'm new in this. > I've executed the few test cases on i.mx53 QSRB. > I just want to know the output display of 3D test cases: test-es2gears.c > test-vertex.c

Re: [Freedreno] [PATCH] drm/msm/gpu: Increase the pm runtime autosuspend for 5xx

On Mon, May 7, 2018 at 6:47 PM, Jordan Crouse wrote: > Experimentation shows that resuming power quickly after suspending > ends up forcing a system hang for unknown reasons on 5xx targets. > To avoid cycling the power too much (especially during init) > turn up the

Re: [Freedreno] [[RFC]DPU PATCH 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On Fri, Apr 27, 2018 at 3:02 AM, <spa...@codeaurora.org> wrote: > On 2018-04-27 08:43, Rob Herring wrote: >> >> On Wed, Apr 25, 2018 at 08:46:13PM -0400, Rob Clark wrote: >>> >>> On Wed, Apr 25, 2018 at 7:45 PM, Stephen Boyd <swb...@chromium.org> >&

Re: [Freedreno] [PATCH] gpu: drm: msm: Change return type to vm_fault_t

On Sun, Jun 17, 2018 at 11:40 PM, Souptick Joarder wrote: > On Thu, May 31, 2018 at 11:29 PM, Jordan Crouse > wrote: >> On Mon, May 28, 2018 at 12:38:41PM +0530, Souptick Joarder wrote: >>> On Mon, May 21, 2018 at 10:59 PM, Souptick Joarder >>> wrote: >>> > Use new return type vm_fault_t for

Re: [Freedreno] [[DPU]PATCH] drm/msm/dsi: move the API setting PLL src to modeset_init()

On Tue, Jun 26, 2018 at 11:55 AM, Doug Anderson wrote: > Hi, > > On Mon, Jun 25, 2018 at 9:45 PM, Sandeep Panda wrote: >> From: Abhinav Kumar >> >> Setting the DSI PLL src in probe doesn't provide the clock >> driver sufficient time to reclaim unused clock resources >> from coreboot resulting

Re: [Freedreno] [[DPU]PATCH] drm/msm/dsi: move the API setting PLL src to modeset_init()

On Wed, Jun 27, 2018 at 2:48 PM, Doug Anderson wrote: > Hi, > > On Tue, Jun 26, 2018 at 10:27 AM, Rob Clark wrote: >> On Tue, Jun 26, 2018 at 11:55 AM, Doug Anderson >> wrote: >>> Hi, >>> >>> On Mon, Jun 25, 2018 at 9:45 PM, San

Re: [Freedreno] [DPU PATCH 2/5] drm/msm/dpu: enable cursor plane for primary crtc

On Wed, Jun 20, 2018 at 12:29 PM, wrote: > On 2018-06-20 19:18, Rob Clark wrote: >> >> On Wed, Jun 20, 2018 at 8:50 AM, Sravanthi Kollukuduru >> wrote: >>> >>> Reserve one DMA pipe as cursor plane and also, update crtc >>> support of cursor

Re: [Freedreno] [RFC 0/4] drm/msm: GPU crash state

On Fri, Jan 5, 2018 at 5:11 PM, Jordan Crouse wrote: > On Fri, Jan 05, 2018 at 06:32:22PM +, Chris Wilson wrote: >> Quoting Jordan Crouse (2018-01-05 18:00:17) >> > This is a request for comment on code to store and dump a GPU state >> > a hang with inspiration from

[Freedreno] [pull] drm/msm: msm-next for 4.16

vice() by name matching Nicolas Dechesne (2): drm/msm: update adreno firmware path in MODULE_FIRMWARE drm/msm: add missing MODULE_FIRMWARE declarations Prakash Kamliya (1): drm/msm: fix leak in failed get_pages Rob Clark (1): drm/msm: free kstrdup'd cmdline drivers/gpu/dr

Re: [Freedreno] [PATCH 2/2] drm/msm/adreno: fix nvmem related link error

On Mon, Jan 15, 2018 at 11:14 AM, Arnd Bergmann wrote: > When NVMEM is configured as a loadable module, and adreno > is built-in, we get a link failure: > > drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_gpu_init': > a5xx_gpu.c:(.text+0x15cc): undefined reference to

Re: [Freedreno] [PATCH 4/8] drm/msm/gpu: Convert the GPU show function to use the GPU state

On Thu, Feb 8, 2018 at 12:31 PM, Jordan Crouse wrote: > Convert the existing GPU show function to use the GPU state to > dump the information rather than reading it directly from the hardware. > This will require an additional step to capture the state before > dumping it

Re: [Freedreno] [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

On Tue, Feb 13, 2018 at 4:10 AM, Tomasz Figa wrote: > Hi Vivek, > > Thanks for the patch. Please see my comments inline. > > On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam > wrote: >> While handling the concerned iommu, there should not be a >> need

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

- > Jeykumar Sankaran (9): > dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding > dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU > drm: Core changes > drm/msm: add DPU DRM driver

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

On Tue, Feb 13, 2018 at 7:02 PM, Jordan Crouse wrote: > On Tue, Feb 13, 2018 at 02:18:13PM -0500, Sean Paul wrote: >> Hi dri-devel, >> Qualcomm has been working for the past few weeks on forward porting their >> downstream drm driver from 4.14 to mainline. Please consider

Re: [Freedreno] [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

On Tue, Feb 13, 2018 at 8:59 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Wed, Feb 14, 2018 at 3:03 AM, Rob Clark <robdcl...@gmail.com> wrote: >> On Tue, Feb 13, 2018 at 4:10 AM, Tomasz Figa <tf...@chromium.org> wrote: >>> Hi Vivek, >>> >>&g

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

On Tue, Feb 13, 2018 at 3:00 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Tue, Feb 13, 2018 at 2:18 PM, Sean Paul <seanp...@chromium.org> wrote: >> Hi dri-devel, >> Qualcomm has been working for the past few weeks on forward porting their >> downstream drm dri

Re: [Freedreno] [RFT PATCH] drm/msm: Trigger fence completion from GPU

On Wed, Feb 14, 2018 at 1:46 AM, Bjorn Andersson wrote: > Interrupt commands causes the CP to trigger an interrupt as the command > is processed, regardless of the GPU being done processing previous > commands. This is seen by the interrupt being delivered before the >

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

On Wed, Feb 14, 2018 at 3:30 AM, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Rob, > > On 13 February 2018 at 20:00, Rob Clark <robdcl...@gmail.com> wrote: >> On Tue, Feb 13, 2018 at 2:18 PM, Sean Paul <seanp...@chromium.org> wrote: >>> Qualco

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

On Wed, Feb 14, 2018 at 1:17 PM, jsanka <jsa...@codeaurora.org> wrote: > > > On 2/13/2018 12:00 PM, Rob Clark wrote: >> >> On Tue, Feb 13, 2018 at 2:18 PM, Sean Paul <seanp...@chromium.org> wrote: >>> >>> Hi dri-devel, >>> Qualcom

Re: [Freedreno] [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

On Wed, Feb 14, 2018 at 11:09 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Thu, Feb 15, 2018 at 1:12 AM, Rob Clark <robdcl...@gmail.com> wrote: >> On Wed, Feb 14, 2018 at 10:48 AM, Jordan Crouse <jcro...@codeaurora.org> >> wrote: >>> On Wed, Feb 14, 2

[Freedreno] [PATCH 3/4] drm/msm/mdp5: Use the new private_obj state

lock alredy taken. - References to "mdp5_get_state()" are replaced with mdp5_get_global_state(). This acquires glob_state_lock and uses drm_atomic_get_private_obj_state() to create a new duplicated state. Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Rob Clark

[Freedreno] [PATCH 4/4] drm/msm: Don't subclass drm_atomic_state anymore

his state within drm_atomic_state itself using the private objects. Remove the infrastructure that allowed subclassing of drm_atomic_state in the driver. Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- drivers/gpu/drm/m

[Freedreno] [PATCH 2/4] drm/msm/mdp5: Add global state as a private atomic object

around it. These will be removed later once we mdp5_global_state is put to use everywhere. Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 79 drivers/gpu

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

On Wed, Feb 14, 2018 at 2:08 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Wed, Feb 14, 2018 at 1:17 PM, jsanka <jsa...@codeaurora.org> wrote: >> On 2/13/2018 12:00 PM, Rob Clark wrote: >>> >>> - It looks like, as was the case with

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove unused code and move the header

off-by: Jordan Crouse <jcro...@codeaurora.org> Thanks, Reviewed-by: Rob Clark <robdcl...@gmail.com> > --- > drivers/gpu/drm/msm/dp/dp_parser.h | 2 +- > drivers/gpu/drm/msm/dpu_io_util.c | 154 > ++--- > .../linu

Re: [Freedreno] [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format

lt;seanp...@chromium.org> Reviewed-by: Rob Clark <robdcl...@gmail.com> > --- > drivers/gpu/drm/drm_mipi_dsi.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 688c8a

Re: [Freedreno] [PATCH RESEND 10/10] drm/msm: Restore msm_atomic_check hook

On Wed, Feb 21, 2018 at 10:18 AM, Sean Paul wrote: > Somehow this got lost, put it back. We might want to re-evaluate whether > this is actually necessary, but for now let's actually use the thing. > > Signed-off-by: Sean Paul we might need this

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_plane_state->defer_prepare_fb

. And when that ever gets re-introduced, I hope we can avoid the need for transitions, since it does seem to introduce a lot more complexity. Reviewed-by: Rob Clark <robdcl...@gmail.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 65 --- > drivers/gp

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

On Fri, Feb 23, 2018 at 5:31 PM, wrote: > The bitmaps in drm_hdmi_info dont seem to be exposed to userspace. > > Our mode selection logic is in userspace at the moment which means its > better userspace knows which modes support what. > > If we decide to move mode

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > Have we considered hiding writeback behind a client cap instead? It is kinda *almost* unneeded, since the connector reports itself as disconnected. I'm not sure what the reason was to drop the cap, but I think it

Re: [Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

On Fri, Feb 23, 2018 at 11:30 AM, Sean Paul <seanp...@chromium.org> wrote: > On Fri, Feb 23, 2018 at 08:17:54AM -0500, Rob Clark wrote: >> In a way, based on the original writeback patch from Jilai Wang, but a >> lot has shifted around since then. >> >>

[Freedreno] [RFC 0/4] drm/msm/mdp5: writeback connector support

out-fences for writeback connectors Rob Clark (2): drm/msm/mdp5: add config for writeback pipes drm/msm/mdp5: writeback support Documentation/gpu/drm-kms.rst | 9 + drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_atomic.c | 229 ++- d

[Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

In a way, based on the original writeback patch from Jilai Wang, but a lot has shifted around since then. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 23 +- drivers/gpu/drm/msm/dis

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 9:00 AM, Liviu Dudau <liviu.du...@arm.com> wrote: > Hi Rob, > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: >> From: Brian Starkey <brian.star...@arm.com> >> >> Writeback connectors represent writeback engines which c

Re: [Freedreno] [DPU PATCH 2/5] drm/msm/dpu: enable cursor plane for primary crtc

On Wed, Jun 20, 2018 at 8:50 AM, Sravanthi Kollukuduru wrote: > Reserve one DMA pipe as cursor plane and also, update crtc > support of cursor in crtc_init. hmm, mdp5 in 820 had real cursor planes in hw, did these go away? If so I guess DMA plane is best candidate for cursor.. BR, -R > >

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

On Thu, Aug 2, 2018 at 7:24 PM, Kees Cook wrote: > On Fri, Jun 29, 2018 at 2:20 PM, Jordan Crouse wrote: >> On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote: >>> In the quest to remove all stack VLA usage from the kernel[1], this >>> switches to using a kasprintf()ed buffer. Return

[Freedreno] [resend][pull] drm/msm: msm-next for 4.19

m/disp/dpu: Mark a handful of functions as static Rajesh Yadav (3): drm/msm/dsi: initialize postdiv_lock before use for 10nm pll drm/msm/mdp5: subclass msm_mdss for mdp5 drm/msm: rework vblank event handling in dpu_crtc Rob Clark (1): drm/msm/mdp5: fix missing CTL flush Se

[Freedreno] [pull] drm/msm: msm-next for 4.19

m/msm/mdp5: subclass msm_mdss for mdp5 drm/msm: rework vblank event handling in dpu_crtc Rob Clark (1): drm/msm/mdp5: fix missing CTL flush Sean Paul (5): drm/msm: Move wait_for_vblanks into mdp complete_commit() hooks drm/msm: Clean up dangling atomic_wq drm/msm: dpu:

Re: [Freedreno] [PATCH 0/5] drm/msm/dpu: Remove dead code

On Thu, Jul 26, 2018 at 4:30 PM, Jordan Crouse wrote: > I made a silly little script that looked at the defined symbols > in nm and then looked to see if other files in the module used > those symbols and if they didn't they were either candidates > for removal or to be made static. This is the

Re: [Freedreno] [PATCH v3 03/19] drm: add msm compressed format modifiers

uses compressed format >>> to optimize BW across multiple IP's. This change adds >>> needed modifier support in drm for a simple 4x4 tile >>> based compressed variants of base formats. >>> >>> Changes in v3: >>> - Removed duplicate entry

Re: [Freedreno] [PATCH] drm/msm/adreno/a6xx: Set the GPU frequency after turning on the GMU

On Fri, Aug 3, 2018 at 5:06 PM Jordan Crouse wrote: > > Set the correct initial GPU frequency on the GMU just after turning on > or resetting the GMU so it doesn't keep running at a horribly slow > speed. > > Signed-off-by: Jordan Crouse *much* better :-) Te

Re: [Freedreno] [PATCH 08/13] drm/msm/gpu: Rearrange the code that collects the task during a hang

On Thu, Jul 12, 2018 at 3:48 PM Chris Wilson wrote: > > Quoting Jordan Crouse (2018-07-12 19:59:25) > > Do a bit of cleanup to prepare for upcoming changes to pass the > > hanging task comm and cmdline to the crash dump function. > > > > Signed-off-by: Jordan Crouse > > --- > >

[Freedreno] [pull] drm/msm: msm-fixes for 4.19

Hi Dave, A couple small fixes for v4.19. I have a 2nd optional follow-up PR that I'll send on top of this which adds a6xx support. See the following PR for details. The following changes since commit a7663a79343658f9362dc0655f1a06723c7014e3: dt-bindings: msm/disp: Add bindings for

[Freedreno] [pull] drm/msm: msm-next++ for 4.19

re bringing up the hardware drm/msm: Add A6XX device support Rob Clark (1): drm/msm: update generated headers drivers/gpu/drm/msm/Makefile |3 + drivers/gpu/drm/msm/adreno/a2xx.xml.h | 57 +- drivers/gpu/drm/msm/adreno/a3xx.xml.h |

Re: [Freedreno] [v7 PATCH 0/5] Add support for Adreno a6xx

On Mon, Aug 6, 2018 at 1:35 PM Jordan Crouse wrote: > > This is an initial version of support for the Adreno a6xx GPU family starting > with the a630 from the sdm845 SoC. This code is ahead of much of the sdm845 > code that would be needed to actually bring up a device and it is also in > advance

Re: [Freedreno] db820: smmu clocks issue in kernel

On Tue, Aug 14, 2018 at 9:00 AM Pradeep Reddy wrote: > > Hi Archit, > > I have enabled splash screen (penguin) in bootloader with fastboot oem > select-display-panel hdmi. Kernel crashes during boot. I identified that > there is issue with below two smmu clocks. > static struct clk_branch

Re: [Freedreno] [PATCH] drm: Convert to using %pOFn instead of device_node.name

On Mon, Aug 27, 2018 at 9:53 PM Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Gustavo Padovan > Cc: Maarten Lankhorst > Cc: Sean Paul > Cc: David Airli

Re: [Freedreno] [PATCH 04/21] drm: add msm compressed format modifiers

On Mon, Jul 9, 2018 at 1:31 PM, Sean Paul wrote: > From: Jeykumar Sankaran > > Qualcomm Snapdragon chipsets uses compressed format > to optimize BW across multiple IP's. This change adds > needed modifier support in drm for a simple 4x4 tile > based compressed variants of base formats. > >

Re: [Freedreno] [PATCH 21/21] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file

On Mon, Jul 9, 2018 at 2:35 PM, Sean Paul wrote: > On Mon, Jul 09, 2018 at 12:07:11PM -0600, Rob Herring wrote: >> On Mon, Jul 9, 2018 at 11:40 AM Sean Paul wrote: >> > >> > Signed-off-by: Sean Paul >> > --- >> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 194 +++ >> > 1

Re: [Freedreno] [PATCH 05/13] drm: Add put callback for the coredump printer

On Thu, Jul 12, 2018 at 2:59 PM, Jordan Crouse wrote: > Add a put function for the coredump printer to bypass printf() > for constant strings for a speed boost. s/put/puts/ (and in the $subject) BR, -R > > v2: Add EXPORT_SYMBOL for _drm_puts_coredump > Signed-off-by: Jordan Crouse > --- >

[Freedreno] [PATCH] drm/msm/mdp5: fix missing CTL flush

pen it would paper over the bug, since the first plag flip would flush out the state to the hardware. The issue could be reproduced with, for example, modetest (without the '-v' argument). Fixes: f9cb8d8d836e drm/msm/mdp5: rework CTL START signal handling Signed-off-by: Rob Clark --- drivers/gpu/drm/

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

gt;>> >>>> On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: >>>>> >>>>> Hi, >>>>> >>>>> On 04/04/2018 08:58 AM, Daniel Vetter wrote: >>>>>> >>>>>> On Wed, Apr 4, 2018 at 12

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 6:21 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: >> > Add an atomic helper to implement dirtyfb support. This is needed to

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

> Hi, >> > > >> > > On 04/04/2018 08:58 AM, Daniel Vetter wrote: >> > > > On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark <robdcl...@gmail.com> wrote: >> > > > > Add an atomic helper to implement dirtyfb support. This is needed

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst <maarten.lankho...@linux.intel.com> wrote: > Op 04-04-18 om 12:21 schreef Daniel Vetter: >> On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >>> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: &

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst <maarten.lankho...@linux.intel.com> wrote: > Op 04-04-18 om 13:37 schreef Rob Clark: >> On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst >> <maarten.lankho...@linux.intel.com> wrote: >>> Op 04-04-18 om 12:21 sch

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 8:16 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Apr 04, 2018 at 07:40:32AM -0400, Rob Clark wrote: >> On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter <dan...@ffwll.ch> wrote: >> > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellst

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 1:41 PM, Noralf Trønnes <nor...@tronnes.org> wrote: > > > Den 04.04.2018 00.42, skrev Rob Clark: >> >> Add an atomic helper to implement dirtyfb support. This is needed to >> support DSI command-mode panels with x11 userspace (ie. w

Re: [Freedreno] apq8016 : 4.14 kernel dsi bridge/panel not working

I'm not sure if this is any way related to (since you mentioned regression btwn 4.9 and 4.14): https://lists.freedesktop.org/archives/dri-devel/2018-April/172152.html given the mention of working when resume from suspend, I might suggest to try disabling bootloader enabling the display (ie. for

Re: [Freedreno] [VERY RFC 0/2] iommu: optionally skip attaching to a DMA domain

On Wed, Apr 11, 2018 at 2:55 PM, Jordan Crouse wrote: > I've been struggling with a problem for a while and I haven't been able to > come > up with a clean solution. Rob convinced me to stop complaining and do > _something_ and hopefully this can spur a good discussion. >

Re: [Freedreno] [PATCH v3 0/8] freedreno: a2xx improvements

hey aren't! > So the commit id in 1/8 was wrong all the time. > > Pushed as: b8fb7978e7ae106d0d11d0b238ab2ba2d4dd9d43. > >> Reviewed-by: Rob Clark <robdcl...@gmail.com> > > Thanks! > > Regards, > Wladimir ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v3 0/8] freedreno: a2xx improvements

stream kernel for old snadragon devices, so I think it is ok to ignore that. If the rnndb bits are merged already, then: Reviewed-by: Rob Clark <robdcl...@gmail.com> (and if not ping me, I might have overlooked some patches..) > Wladimir J. van der Laan (8): > freedreno: a2xx: Upd

[Freedreno] [pull] drm/msm: msm-next for 4.17

Bethencourt (1): drm/msm/mdp5: Fix trailing semicolon Rob Clark (9): drm/msm: add a5xx specific debugfs drm/msm: add sudo flag to submit ioctl drm/msm: rename mdp->disp drm/msm: strip out msm_fence_cb drm/msm/dsi: fix direct caller of msm_gem_free_obj

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Thu, Mar 1, 2018 at 3:37 PM, wrote: > On 2018-03-01 07:27, Sean Paul wrote: >> >> On Wed, Feb 28, 2018 at 08:07:00PM -0800, jsa...@codeaurora.org wrote: >>> >>> On 2018-02-28 11:19, Sean Paul wrote: >>> > Moving further towards switching fully to the the atomic helpers,

Re: [Freedreno] [pull] drm/msm: fixes for 4.17

On Wed, Apr 25, 2018 at 2:55 PM, Rob Clark <robdcl...@gmail.com> wrote: > Hi Dave, > > A few fixes for 4.17.. thanks to Sean for helping pull together some > of the display related fixes while I was off in compute-land. > > The follow

Re: [Freedreno] [[RFC]DPU PATCH 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On Wed, Apr 25, 2018 at 7:45 PM, Stephen Boyd wrote: > Quoting Sandeep Panda (2018-04-19 10:56:06) >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. >> >> Changes in v1: >> - Rephrase the dt-binding descriptions to be more inline with existing >>bindings

Re: [Freedreno] [PATCH 1/3] lib/string: Pass the input gfp flags to kmalloc

Thanks, I've pushed 2 and 3 to msm-next, since these should probably go in a -fixes pr for 4.20 This one, you might want to resend w/ --cc-cmd=./scripts/get_maintainer.pl so that it gets seen by someone who could apply it fwiw, I use git config sendemail.cccmd './scripts/get_maintainer.pl -i'

[Freedreno] [PATCH] drm/msm: fix handling of cmdstream offset

buffers in the command Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_rd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c index cca933458439..0c2c8d2c631f 100644 --- a/drivers/gpu/drm/msm/msm_rd.c +++ b/drivers

Re: [Freedreno] [PATCH v3] ir3_compiler/nir: fix imageSize() for buffer-backed images

> > v2: Pre-compute and submit the log2 of the image format's bpp as shader > constant instead of emitting the LOG2 instruction in code. (Rob Clark) > > v3: Use ffs (find-first-bit) helper for computing log2 (Ilia Mirkin) Reviewed-by: Rob Clark >

[Freedreno] [PATCH] drm/msm/gpu: add submit flag to hint which buffers should be dumped

a MSM_SUBMIT_BO_DUMP flag so userspace can indicate buffers that contain cmdstream (or are otherwise important to dump). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 5 - drivers/gpu/drm/msm/msm_rd.c | 13 ++--- include/uapi/drm/msm_drm.h | 5 - 3 files

Re: [Freedreno] [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov wrote: > > On Thu, 25 Oct 2018 at 10:32, Eric Engestrom wrote: > > > > On Tuesday, 2018-10-23 10:49:26 -0400, > > mesa-dev-boun...@lists.freedesktop.org wrote: > > > In the pursuit of lowering driver overhead, it became clear that some > > > amount

Re: [Freedreno] [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

On Tue, Oct 30, 2018 at 1:34 PM Emil Velikov wrote: > > On Tue, 30 Oct 2018 at 17:19, Rob Clark wrote: > > On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov > > wrote: > > > > > > NOTE: if bisecting a build error takes you hear, try a clean build. > > >

Re: [Freedreno] [PATCH] iommu: arm-smmu: Set SCTLR.HUPCF bit

On Tue, Nov 13, 2018 at 1:32 AM Will Deacon wrote: > > On Fri, Nov 09, 2018 at 01:01:55PM -0500, Rob Clark wrote: > > On Mon, Oct 29, 2018 at 3:09 PM Will Deacon wrote: > > > On Thu, Sep 27, 2018 at 06:46:07PM -0400, Rob Clark wrote: > > > > We seem to need t

Re: [Freedreno] [PATCH] iommu: arm-smmu: Set SCTLR.HUPCF bit

On Mon, Oct 29, 2018 at 3:09 PM Will Deacon wrote: > > On Thu, Sep 27, 2018 at 06:46:07PM -0400, Rob Clark wrote: > > We seem to need to set either this or CFCFG (stall), otherwise gpu > > faults trigger problems with other in-flight transactions from the > > GP

Re: [Freedreno] [PATCH 01/13] drm/msm: Track GPU fences with idr

On Mon, Oct 1, 2018 at 3:04 PM Jordan Crouse wrote: > > On Mon, Oct 01, 2018 at 06:01:33PM +0530, Sharat Masetty wrote: > > Track the GPU fences created at submit time with idr instead of the ring > > the sequence number. This helps with easily changing the underlying > > fence to something we

[Freedreno] [PATCH] iommu: arm-smmu: Set SCTLR.HUPCF bit

not what we want for GPU). Signed-off-by: Rob Clark --- So I hit this issue a long time back on 820 (msm8996) and at the time I solved it with a patch that enabled CFCFG. And it resurfaced more recently on sdm845. But at the time CFCFG was rejected, iirc because of concern that it would cause

Re: [Freedreno] [PATCH v2 1/2] drm/msm: Fix A6XX support for opp-level

s On Wed, Jan 16, 2019 at 1:46 PM Douglas Anderson wrote: > > The bindings for Qualcomm opp levels changed after being Acked but > before landing. Thus the code in the GPU driver that was relying on > the old bindings is now broken. > > Let's change the code to match the new bindings by

Re: [Freedreno] [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path

On Fri, Jan 18, 2019 at 1:06 PM Doug Anderson wrote: > > Hi, > > On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse wrote: > > > > Try to get the interconnect path for the GPU and vote for the maximum > > bandwidth to support all frequencies. This is needed for performance. > > Later we will want to

[Freedreno] [pull] drm/msm: drm-msm-fixes-2018-01-22 for 5.0

): drm/msm: Add __printf verification Jordan Crouse (2): drm/msm/gpu: Remove hardcoded interrupt name drm/msm: drop interrupt-names Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (1): drm/msm: honor GPU_READONLY flag .../devicetree

[Freedreno] [pull] drm/msm: msm-next for 4.21

o.h static inline functions Mamta Shukla (1): drm: msm: Use DRM_DEV_* instead of dev_* Matthias Kaehlcke (1): dt-bindings: msm/dsi: Add ref clock for PHYs Rob Clark (5): drm/msm: update generated headers drm/msm/gpu: add submit flag to hint which buffers should be dumped

Re: [Freedreno] [PATCH] drm/msm: fix arm64 build error

On Mon, Dec 10, 2018 at 3:56 PM Arnd Bergmann wrote: > > The new a200 GPU MMU support fails to build on arm64 because > of a conflicting macro name: > > drivers/gpu/drm/msm/msm_gpummu.c:17: error: "VA_START" redefined [-Werror] > #define VA_START SZ_16M > > In file included from

Re: [Freedreno] [PATCH 4/4] drm/msm: bump UAPI version

On Fri, Nov 30, 2018 at 10:36 AM Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 4:31 PM Rob Clark wrote: > > > > On Fri, Nov 30, 2018 at 10:12 AM Arnd Bergmann wrote: > > > > > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: >

Re: [Freedreno] [PATCH 2/4] drm/msm: rework GEM_INFO ioctl

On Fri, Nov 30, 2018 at 10:14 AM Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: > > > > > - > > -#define MSM_INFO_FLAGS (MSM_INFO_IOVA) > > +/* Get or set GEM buffer info. The requested value can be passed > > + * directly

Re: [Freedreno] [PATCH 4/4] drm/msm: bump UAPI version

On Fri, Nov 30, 2018 at 10:12 AM Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/msm_drv.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > >

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

On Thu, Nov 29, 2018 at 10:54 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 09:42:50AM -0500, Rob Clark wrote: > > Maybe the thing we need to do is just implement a blacklist of > > compatible strings for devices which should skip the automatic > > iommu/dma h

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

On Thu, Nov 29, 2018 at 10:53 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 09:25:43AM -0500, Rob Clark wrote: > > > As I told you before: hell no. If you spent the slightest amount of > > > actually trying to understand what you are doing here you'd know this

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

On Thu, Nov 29, 2018 at 12:24 PM Tomasz Figa wrote: > > [CC Marek] > > On Thu, Nov 29, 2018 at 9:09 AM Daniel Vetter wrote: > > > > On Thu, Nov 29, 2018 at 5:57 PM Christoph Hellwig wrote: > > > > > > Note that one thing I'd like to avoid is exposing these funtions directly > > > to drivers, as

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

On Thu, Nov 29, 2018 at 10:57 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 03:43:50PM +0100, Daniel Vetter wrote: > > Yeah we had patches to add manual cache management code to drm, so we > > don't have to abuse the dma streaming api anymore. Got shouted down. > > Abusing the dma

Re: [Freedreno] [RESEND PATCH v3] drm/msm: Move fence put to where failure occurs

On Tue, Dec 4, 2018 at 11:56 AM Robert Foss wrote: > > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss > Reviewed-by: Chris Wilson >

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

On Thu, Dec 6, 2018 at 8:38 PM Christoph Hellwig wrote: > > On Fri, Nov 30, 2018 at 10:46:04AM +0100, Daniel Vetter wrote: > > > Being able to dip into CMA and maybe iommu coalescing if we want to > > > get fancy is indeed the only reason for this API. If we just wanted > > > to map pages we

Re: [Freedreno] [PATCH] drm/msm/a6xx: Add support for an interconnect path

er if it would be appropriate and/or possible to merge this > with the generic interconnect patches and with his blessing I would like to > renew that request. This should merge cleanly against tip of tree and it would > be nice to get this support in at the same time that the base patches go

Re: [Freedreno] [PATCH v2 3/9] drm/msm/mdp4: add lcdc-align-lsb flag to control lane alignment

On Wed, Nov 21, 2018 at 8:55 PM Jonathan Marek wrote: > > Controls which of the 8 lanes are used for 6 bit color. > > Signed-off-by: Jonathan Marek > --- > .../gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 22 --- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git

Re: [Freedreno] [PATCH v2 5/9] drm/msm: add headless gpu device (for imx5)

On Wed, Nov 21, 2018 at 8:55 PM Jonathan Marek wrote: > > This patch allows using drm/msm without qcom display hardware. This is > especially useful for iMX5 hardware, which has a a2xx GPU but uses the > imx-drm driver for display. > > Signed-off-by: Jonathan Marek > --- > v2: added commit

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

On Mon, Dec 3, 2018 at 7:45 AM Robin Murphy wrote: > > Hi Rob, > > On 01/12/2018 16:53, Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

On Mon, Dec 3, 2018 at 7:45 AM Robin Murphy wrote: > > Hi Rob, > > On 01/12/2018 16:53, Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

On Thu, Nov 29, 2018 at 9:14 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 07:33:15PM +0530, Vivek Gautam wrote: > > dma_map_sg() expects a DMA domain. However, the drm devices > > have been traditionally using unmanaged iommu domain which > > is non-dma type. Using dma mapping APIs

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

On Thu, Nov 29, 2018 at 9:25 AM Rob Clark wrote: > > On Thu, Nov 29, 2018 at 9:14 AM Christoph Hellwig wrote: > > > > On Thu, Nov 29, 2018 at 07:33:15PM +0530, Vivek Gautam wrote: > > > dma_map_sg() expects a DMA domain. However, the drm devices > > > hav

Re: [Freedreno] [PATCH] drm/msm: Only add available components

yeah, that seems like a reasonable thing to do Reviewed-by: Rob Clark > --- > > drivers/gpu/drm/msm/msm_drv.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index b1577e960889..0b82

<    1   2   3   4   5   6   7   8   9   10   >