Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

On 2018-04-04 15:56, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: MSM display controller hardware (DPU) has an inbuilt RSC block which can control power resources and bus bandwidth voting based on frame timing parameters w/o DPU driver intervention. In

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Op 04-04-18 om 13:37 schreef Rob Clark: > On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst > wrote: >> Op 04-04-18 om 12:21 schreef Daniel Vetter: >>> On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: On Tue, Apr 03, 2018 at 06:42:23PM -0400,

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: Add an atomic helper to implement dirtyfb support. This is

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: > On 04/04/2018 10:43 AM, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: > > > Hi, > > > > > > On 04/04/2018 08:58 AM, Daniel Vetter wrote: > > > > On Wed, Apr 4, 2018 at 12:42 AM, Rob

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: > Add an atomic helper to implement dirtyfb support. This is needed to > support DSI command-mode panels with x11 userspace (ie. when we can't > rely on pageflips to trigger a flush to the panel). > > To signal to the driver that the

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: > MSM display controller hardware (DPU) has an inbuilt RSC block > which can control power resources and bus bandwidth voting > based on frame timing parameters w/o DPU driver intervention. > In absence of RSC HW, DPU driver controls

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 6:21 AM, Daniel Vetter wrote: > On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: >> > Add an atomic helper to implement dirtyfb support. This is needed to >> > support DSI

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: >> On 04/04/2018 10:43 AM, Daniel Vetter wrote: >> > On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: >> > > Hi, >> > > >> > > On 04/04/2018

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Op 04-04-18 om 12:21 schreef Daniel Vetter: > On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: >>> Add an atomic helper to implement dirtyfb support. This is needed to >>> support DSI command-mode panels with x11

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst wrote: > Op 04-04-18 om 12:21 schreef Daniel Vetter: >> On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >>> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: Add an atomic helper to

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

On 2018-04-05 01:51, Sean Paul wrote: On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: MSM display controller hardware (DPU) has an inbuilt RSC block which can control power resources and bus bandwidth voting based on frame timing parameters w/o DPU driver intervention. In absence

Re: [Freedreno] [DPU PATCH 1/3] drm/msm: Fix uninitialized use of prefill_lines

On 2018-04-03 01:40, Sean Paul wrote: prefill_lines initialization was removed in da61c67cdec4, but it's still being used :( Fixes: da61c67cdec4 drm/msm: remove hw rotation support Cc: Jeykumar Sankaran Signed-off-by: Sean Paul Reviewed-by:

Re: [Freedreno] [PATCH 2/5] arm64:dts:sdm845: Add support for GPU LLCC

On 4/4/2018 2:52 AM, Jordan Crouse wrote: On Fri, Mar 23, 2018 at 12:49:48PM +0530, Sharat Masetty wrote: Add client side bindings required for the GPU to use the last level system cache. Also add a register range in the GPU CX domain. Reviewed-by: Jordan Crouse

Re: [Freedreno] [DPU PATCH 3/3] drm/msm: Fix dpu build warnings

On 2018-04-03 01:40, Sean Paul wrote: A bunch of warning fixes, build is clean now. Some of the changes done in this patch are unique and were not present in previous patch series to fix dpu driver warnings. Please consider refactoring this patch a bit to include the remaining valid fixes.

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 04, 2018 at 07:40:32AM -0400, Rob Clark wrote: > On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: > >> On 04/04/2018 10:43 AM, Daniel Vetter wrote: > >> > On Wed, Apr 04, 2018 at 10:22:21AM

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 2:05 PM, Rob Clark wrote: > On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst > wrote: >> Op 04-04-18 om 13:37 schreef Rob Clark: >>> On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst >>>

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst wrote: > Op 04-04-18 om 13:37 schreef Rob Clark: >> On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst >> wrote: >>> Op 04-04-18 om 12:21 schreef Daniel Vetter: On Wed, Apr

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 04, 2018 at 01:46:37PM +0200, Thomas Hellstrom wrote: > On 04/04/2018 12:28 PM, Thomas Hellstrom wrote: > > On 04/04/2018 11:56 AM, Daniel Vetter wrote: > > > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: > > > > On 04/04/2018 10:43 AM, Daniel Vetter wrote: > > > >

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Op 04-04-18 om 14:05 schreef Rob Clark: > On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst > wrote: >> Op 04-04-18 om 13:37 schreef Rob Clark: >>> On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst >>> wrote: Op 04-04-18

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 3:24 PM, Rob Clark wrote: > On Wed, Apr 4, 2018 at 8:16 AM, Daniel Vetter wrote: >> On Wed, Apr 04, 2018 at 07:40:32AM -0400, Rob Clark wrote: >>> On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: >>> > On Wed, Apr

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

On Wed, Apr 04, 2018 at 04:53:51PM +0530, rya...@codeaurora.org wrote: > On 2018-04-04 15:56, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: > > > MSM display controller hardware (DPU) has an inbuilt RSC block > > > which can control power resources and bus

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 04, 2018 at 07:35:58AM -0400, Rob Clark wrote: > On Wed, Apr 4, 2018 at 6:21 AM, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: > >> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: > >> > Add an atomic helper to

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 8:16 AM, Daniel Vetter wrote: > On Wed, Apr 04, 2018 at 07:40:32AM -0400, Rob Clark wrote: >> On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: >> > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: >> >> On 04/04/2018

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Op 04-04-18 om 14:26 schreef Daniel Vetter: > On Wed, Apr 4, 2018 at 2:05 PM, Rob Clark wrote: >> On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst >> wrote: >>> Op 04-04-18 om 13:37 schreef Rob Clark: On Wed, Apr 4, 2018 at 6:36 AM,

Re: [Freedreno] [DPU PATCH 1/3] drm/msm: Remove unused variables

On Wed, Mar 28, 2018 at 11:47:46AM +0530, Rajesh Yadav wrote: > Fix compilation errors due to unused variables. > > Signed-off-by: Rajesh Yadav Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 2 +- >

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Den 04.04.2018 00.42, skrev Rob Clark: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely on pageflips to trigger a flush to the panel). To signal to the driver that the async atomic update needs to

[Freedreno] [PATCH v4 3/9] drm/msm: Don't subclass drm_atomic_state anymore

From: Archit Taneja With the addition of "private_objs" in drm_atomic_state, we no longer need to subclass drm_atomic_state to store state of share resources that don't perfectly fit within planes/crtc/connector state information. We can now save this state within

[Freedreno] [PATCH v4 5/9] drm/msm: Move implicit sync handling to prepare_fb

In preparation for moving to atomic helpers, move the implicit sync fence handling out of atomic commit and into the plane->prepare_fb() hook. While we're at it, de-duplicate the mdp*_prepare_fb functions. Changes in v4: - Added Reported-by: Rob Clark Signed-off-by: Sean

[Freedreno] [PATCH v4 9/9] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Cc: Abhinav Kumar Signed-off-by: Sean Paul

[Freedreno] [PATCH v4 8/9] drm/msm: Remove msm_commit/worker, use atomic helper commit

Moving further towards switching fully to the the atomic helpers, this patch removes the hand-rolled worker nonblock commit code and uses the atomic helpers commit_work model. Changes in v2: - Remove commit_destroy() - Shuffle order of commit_tail calls to further serialize commits - Use stall in

[Freedreno] [PATCH v4 7/9] drm/msm: Issue queued events when disabling crtc

Ensure that any queued events are issued when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Reviewed-by: Archit Taneja

[Freedreno] [PATCH v4 1/9] drm/msm/mdp5: Add global state as a private atomic object

From: Archit Taneja Global shared resources (hwpipes, hwmixers and SMP) for MDP5 are implemented as a part of atomic state by subclassing drm_atomic_state. The preferred approach is to use the drm_private_obj infrastructure available in the atomic core.

[Freedreno] [PATCH v4 2/9] drm/msm/mdp5: Use the new private_obj state

From: Archit Taneja This replaces the usage of the subclassed atomic state (mdp5_state) with a private_obj state embedded within drm_atomic_state. The latter method is the preferred approach, since it's simpler to implement and less prone to errors. The new API replaces

[Freedreno] [PATCH v4 6/9] drm/msm: Mark the crtc->state->event consumed

Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Cc: Jeykumar Sankaran Reviewed-by:

[Freedreno] [PATCH v4 4/9] drm/msm: Refactor complete_commit() to look more the helpers

Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Cc: Jeykumar Sankaran

Re: [Freedreno] [DPU PATCH 3/3] drm/msm/dsi-staging: Gate bus scale code

On Wed, Mar 28, 2018 at 11:48:48AM +0530, Rajesh Yadav wrote: > DSI driver relies on downstream bus scaling > driver (msm_bus) for bus bandwidth voting. > Gate the bus bandwidth voting code under > CONFIG_QCOM_BUS_SCALING. > > Signed-off-by: Rajesh Yadav Thank you for

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Den 04.04.2018 19.56, skrev Daniel Vetter: On Wed, Apr 4, 2018 at 7:41 PM, Noralf Trønnes wrote: Den 04.04.2018 00.42, skrev Rob Clark: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 1:41 PM, Noralf Trønnes wrote: > > > Den 04.04.2018 00.42, skrev Rob Clark: >> >> Add an atomic helper to implement dirtyfb support. This is needed to >> support DSI command-mode panels with x11 userspace (ie. when we can't >> rely on pageflips to

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: > MSM display controller hardware (DPU) has an inbuilt RSC block > which can control power resources and bus bandwidth voting > based on frame timing parameters w/o DPU driver intervention. > In absence of RSC HW, DPU driver controls

[Freedreno] [DPU PATCH v2 1/2] dt-bindings: msm/disp: Remove DPU RSC device bindings

Display controller's power resources and bus bandwidth voting is controlled by DPU device. Remove DPU RSC (hardware block for DPU power resource control) device support. Signed-off-by: Rajesh Yadav --- .../devicetree/bindings/display/msm/dpu-rsc.txt| 96

[Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

MSM display controller hardware (DPU) has an inbuilt RSC block which can control power resources and bus bandwidth voting based on frame timing parameters w/o DPU driver intervention. In absence of RSC HW, DPU driver controls these resources. Downstream driver relies on RSC driver for controlling

Re: [Freedreno] [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: > Add an atomic helper to implement dirtyfb support. This is needed to > support DSI command-mode panels with x11 userspace (ie. when we can't > rely on pageflips to trigger a flush to the panel). > > To signal to the driver