Re: [Freedreno] [PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-15 Thread Rob Clark
On Wed, Aug 14, 2019 at 11:51 PM Christoph Hellwig wrote: > > As said before I don't think these low-level helpers are the > right API to export, but even if they did you'd just cover a tiny > subset of the architectures. Are you thinking instead something like: void

Re: [Freedreno] [PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > When attempting to configure this driver on a Nexus 5 phone (msm8974), > setting up the dummy i2c bus for TX_P0 would fail due to an -EBUSY > error. The downstream MSM kernel sources [1] shows that the proper value > for TX_P0 is 0x78, not

Re: [Freedreno] [PATCH RFC 10/11] ARM: dts: qcom: msm8974: add HDMI nodes

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add HDMI tx and phy nodes to support an external display that can be > connected over the SlimPort. This is based on work from Jonathan Marek. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [Freedreno] [PATCH 03/11] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Silence two warning messages that occur due to -EPROBE_DEFER errors to > help cleanup the system boot log. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___

Re: [Freedreno] [PATCH 08/11] drm/msm/hdmi: silence -EPROBE_DEFER warning

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Silence a warning message due to an -EPROBE_DEFER error to help cleanup > the system boot log. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno

Re: [Freedreno] [PATCH 02/11] drm/bridge: analogix-anx78xx: add new variants

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add support for the 7808 variant. While we're here, the of match table > was missing support for the 7812 and 7818 variants, so add them as well. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [Freedreno] [PATCH 01/11] dt-bindings: drm/bridge: analogix-anx78xx: add new variants

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add support for the analogix,anx7808, analogix,anx7812, and > analogix,anx7818 variants. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing

Re: [Freedreno] [PATCH 04/11] drm/bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > The i2c_new_dummy() function is deprecated since it returns NULL on > error. Change this to use the recommended replacement > i2c_new_dummy_device() that returns an error code that can be read with > PTR_ERR() and friends. > > Signed-off-by:

Re: [Freedreno] [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add support for the avdd33 regulator to the analogix-anx78xx driver. > Note that the regulator is currently enabled during driver probe and > disabled when the driver is removed. This is currently how the > downstream MSM kernel sources do

Re: [Freedreno] [PATCH 07/11] ARM: qcom_defconfig: add CONFIG_DRM_ANALOGIX_ANX78XX

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add CONFIG_DRM_ANALOGIX_ANX78XX as a module so that the external display > can be used on the Nexus 5 phones. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___

Re: [Freedreno] [PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-15 Thread Christoph Hellwig
As said before I don't think these low-level helpers are the right API to export, but even if they did you'd just cover a tiny subset of the architectures. Also to distil the previous thread - if you remap memory to uncached the helper to use is arch_dma_prep_coherent, which does a writeback+

Re: [Freedreno] [PATCH RFC 11/11] ARM: dts: qcom: msm8974-hammerhead: add support for external display

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add HDMI nodes and other supporting infrastructure in order to support > the external display. This is based on work from Jonathan Marek. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [Freedreno] [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > pm8941 is missing the 5vs2 regulator node so let's add it since its > needed to get the external display working. This regulator was already > configured in the interrupts property on the parent node. > > Note that this regulator is referred

Re: [Freedreno] [PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-15 Thread Koenig, Christian
Am 15.08.19 um 19:53 schrieb Christoph Hellwig: > On Thu, Aug 15, 2019 at 06:54:39AM -0700, Rob Clark wrote: >> On Wed, Aug 14, 2019 at 11:51 PM Christoph Hellwig wrote: >>> As said before I don't think these low-level helpers are the >>> right API to export, but even if they did you'd just cover

Re: [Freedreno] [PATCH v3 0/2] iommu/arm-smmu: Split pagetable support

2019-08-15 Thread Jordan Crouse
On Wed, Aug 07, 2019 at 04:21:38PM -0600, Jordan Crouse wrote: > (Sigh, resend. I freaked out my SMTP server) > > This is part of an ongoing evolution for enabling split pagetable support for > arm-smmu. Previous versions can be found [1]. > > In the discussion for v2 Robin pointed out that this

Re: [PATCH v3 1/2] iommu/io-pgtable-arm: Add support for ARM_ADRENO_GPU_LPAE io-pgtable format

2019-08-15 Thread Jordan Crouse
On Wed, Aug 07, 2019 at 04:21:39PM -0600, Jordan Crouse wrote: > Add a new sub-format ARM_ADRENO_GPU_LPAE to set up TTBR0 and TTBR1 for > use by the Adreno GPU. This will allow The GPU driver to map global > buffers in the TTBR1 and leave the TTBR0 configured but unset and > free to be changed

Re: [Freedreno] [PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-15 Thread Christoph Hellwig
On Thu, Aug 15, 2019 at 06:54:39AM -0700, Rob Clark wrote: > On Wed, Aug 14, 2019 at 11:51 PM Christoph Hellwig wrote: > > > > As said before I don't think these low-level helpers are the > > right API to export, but even if they did you'd just cover a tiny > > subset of the architectures. > >

Re: [Freedreno] [PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-15 Thread Christoph Hellwig
On Thu, Aug 15, 2019 at 06:48:39PM +, Koenig, Christian wrote: > Well, for the graphics case I absolutely need to keep the linear kernel > mapping. Because for certain use cases the memory is accessed by the kernel > all the time as well. Then don't set DMA_ATTR_NO_KERNEL_MAPPING. At least

Re: [Freedreno] [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node

2019-08-15 Thread Brian Masney
On Thu, Aug 15, 2019 at 10:34:17AM +0200, Linus Walleij wrote: > On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > > > pm8941 is missing the 5vs2 regulator node so let's add it since its > > needed to get the external display working. This regulator was already > > configured in the

Re: [Freedreno] [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator

2019-08-15 Thread Brian Masney
On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote: > On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > > > Add support for the avdd33 regulator to the analogix-anx78xx driver. > > Note that the regulator is currently enabled during driver probe and > > disabled when the driver is

Re: [Freedreno] [PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-15 Thread Christoph Hellwig
On Thu, Aug 15, 2019 at 06:21:00PM +, Koenig, Christian wrote: > > (2) Add support for DMA_ATTR_NO_KERNEL_MAPPING to this new API instead > > of dma_alloc_attrs. The initial difference with that flag is just > > that we allow highmem, but in the future we could also unmap this >

Re: [Freedreno] [PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-15 Thread Koenig, Christian
Sorry if the style is messed up, replying from my phone. Am 15.08.2019 20:27 schrieb Christoph Hellwig : On Thu, Aug 15, 2019 at 06:21:00PM +, Koenig, Christian wrote: > > (2) Add support for DMA_ATTR_NO_KERNEL_MAPPING to this new API instead > > of dma_alloc_attrs. The initial