[Freedreno] [PATCH] gpu: Consistently use octal not symbolic permissions

2018-05-24 Thread Joe Perches
to open parenthesis o drivers/gpu/drm/msm/adreno/a5xx_debugfs.c has a world-writeable debug permission for "reset" - perhaps that should be modified Signed-off-by: Joe Perches <j...@perches.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c| 2 +- drivers/gp

Re: [Freedreno] [PATCH] gpu: Consistently use octal not symbolic permissions

2018-05-25 Thread Joe Perches
On Fri, 2018-05-25 at 09:41 +0300, Jani Nikula wrote: > On Thu, 24 May 2018, Joe Perches <j...@perches.com> wrote: > > There is currently a mixture of octal and symbolic permissions uses > > in files in drivers/gpu/drm and one file in drivers/gpu. > > > > T

[Freedreno] [PATCH] drm/msm: Add __printf verification

2019-01-17 Thread Joe Perches
Add a few __printf attribute specifiers to routines that could use them. Signed-off-by: Joe Perches --- drivers/gpu/drm/msm/msm_drv.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 9f51be5a637c..927e5d86f7c1 100644

[Freedreno] [PATCH -next 000/491] treewide: use fallthrough;

2020-03-10 Thread Joe Perches
ough.commit_msg") or die "$0: can't create temporary file: $!\n"; print $fh <https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git@perches.com/ EOF ; close $fh; `git commit -s -a -F cvt_fallthrough.commit_msg`; } Joe Perches (491): MELLANOX ETHERNET INNOV

Re: [Freedreno] [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-06 Thread Joe Perches
On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote: > A missing semicolon here causes my external display to stop working. > Indeed, missing the semicolon on the return statement leads to > dp_panel_update_tu_timings() not existing because the compiler thinks > it's part of the return statement

Re: [Freedreno] [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-12 Thread Joe Perches
On Mon, 2021-02-08 at 10:57 -0800, Stephen Boyd wrote: > Quoting Joe Perches (2021-02-06 21:06:54) > > Wow, that's really unfortunate that dp_panel_update_tu_timings > > is also void. > > > > Perhaps this as YA checkpatch warning: > > > > --- >

Re: [Freedreno] [PATCH] MAINTAINERS: update designated reviewer entry for MSM DRM driver

2021-11-19 Thread Joe Perches
On Fri, 2021-11-19 at 15:18 -0800, Abhinav Kumar wrote: > Adding myself as a designated reviewer to assist with the > code reviews for the changes coming into MSM DRM. > > Acked-by: Rob Clark > Signed-off-by: Abhinav Kumar [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -5938,6 +5938,7 @@

Re: [Freedreno] [PATCH v3 4/4] drm/msm/adreno: Fix up formatting

2022-05-28 Thread Joe Perches
On Sat, 2022-05-28 at 18:03 +0200, Konrad Dybcio wrote: > Leading spaces are not something checkpatch likes, and it says so when > they are present. Use tabs consistently to indent function body and > unwrap a 83-char-long line, as 100 is cool nowadays. unassociated trivia: > diff --git