Re: [Freedreno] [PATCH] drm: convert DT component matching to component_match_add_release()

On Wed, Oct 19, 2016 at 6:28 AM, Russell King wrote: > Convert DT component matching to use component_match_add_release(). > > Signed-off-by: Russell King > --- > Can we please get this patch from May merged into the drm-misc or > whatever

Re: [Freedreno] [PATCH 6/6] drm/msm/mdp5: add atomic_print_state support

On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark <robdcl...@gmail.com> wrote: > We subclass drm_plane_state, so add mdp5_plane_atomic_print_state() to > dump out our own driver specific plane state. > Reviewed-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Rob Cl

Re: [Freedreno] [PATCH 5/6] drm/atomic: add debugfs file to dump out atomic state

On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark <robdcl...@gmail.com> wrote: A short commit message detailing the change and info printed would probably be helpful. Aside from that, Reviewed-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Rob Clark <robdcl...@gmail.com>

Re: [Freedreno] [PATCH 2/6] drm: add helper for printing to log or seq_file

On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: > Sometimes it is nice not to duplicate equivalent printk() and > seq_printf() code. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/Makefile| 3 ++- > drivers/gpu/drm/drm_print.c | 54

Re: [Freedreno] [Intel-gfx] [PATCH 13/24] drm/msm: switch to postclose

m> > Cc: linux-arm-...@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> I think I've convinced myself that this is functionally equivalent (or at least if Bad Things could happen with postclose, they would also be Bad Things with pre

Re: [Freedreno] [PATCH 1/4] drm/msm/dsi: convert to msm_clk_get()

> in bindings while maintaing backwards compatibility. > > Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 8 > drivers/gpu/drm/msm/dsi/dsi_host.c| 30 ++

Re: [Freedreno] [PATCH 2/4] drm/msm/edp: convert to msm_clk_get()

> in bindings while maintaing backwards compatibility. > > Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/edp/edp_ctrl.c | 22 +++--- > 1 file changed, 11 insertions(+)

Re: [Freedreno] [PATCH 3/4] drm/msm/hdmi: convert to msm_clk_get()

> in bindings while maintaing backwards compatibility. > > Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 10 +- > drivers/gpu/drm/msm/hdmi/hdmi_phy.c

Re: [Freedreno] [DPU PATCH 03/11] drm/msm/dpu: add MDSS top level driver for dpu

t;qcom,mdp4", .data = (void *)KMS_MDP4 }, > { .compatible = "qcom,mdss", .data = (void *)KMS_MDP5 }, > #ifdef CONFIG_DRM_MSM_DPU > - { .compatible = "qcom,dpu-kms", .data = (void *)KMS_DPU }, > + { .compatible = "qcom,dpu-mdss", .data = (void *)KMS_DPU }, This requires a dt binding change. > #endif > {} > }; > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index 90a2521..e8e5e73 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -381,7 +381,7 @@ struct msm_drm_private { > /* subordinate devices, if present: */ > struct platform_device *gpu_pdev; > > - /* top level MDSS wrapper device (for MDP5 only) */ > + /* top level MDSS wrapper device (for MDP5/DPU only) */ > struct msm_mdss *mdss; > > /* possibly this should be in the kms component, but it is > diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h > index 9a7bc7d..8f50613 100644 > --- a/drivers/gpu/drm/msm/msm_kms.h > +++ b/drivers/gpu/drm/msm/msm_kms.h > @@ -145,6 +145,8 @@ struct msm_mdss { > > int mdp5_mdss_init(struct drm_device *dev); > Remove this line. > +int dpu_mdss_init(struct drm_device *dev); > + > /** > * Mode Set Utility Functions > */ > diff --git a/include/linux/dpu_io_util.h b/include/linux/dpu_io_util.h > index 7c73899..45e606f 100644 > --- a/include/linux/dpu_io_util.h > +++ b/include/linux/dpu_io_util.h > @@ -104,6 +104,8 @@ int msm_dss_config_vreg(struct device *dev, struct > dss_vreg *in_vreg, > void msm_dss_put_clk(struct dss_clk *clk_arry, int num_clk); > int msm_dss_clk_set_rate(struct dss_clk *clk_arry, int num_clk); > int msm_dss_enable_clk(struct dss_clk *clk_arry, int num_clk, int enable); > +int msm_dss_parse_clock(struct platform_device *pdev, > + struct dss_module_power *mp); > > int dpu_i2c_byte_read(struct i2c_client *client, uint8_t slave_addr, > uint8_t reg_offset, uint8_t *read_buf); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 07/11] drm/msm/dpu: remove clock management code from dpu_power_handle

err("device vreg supply parsing failed\n"); > - goto parse_vreg_err; > + goto end; Just return directly and remove the end label. > } > > rc = msm_dss_config_vreg(>dev, > @@ -700,18 +637,6 @@ int dpu_power_resource_init(struct platform_device *pdev, > goto vreg_err; > } > > - rc = msm_dss_get_clk(>dev, mp->clk_config, mp->num_clk); > - if (rc) { > - pr_err("clock get failed rc=%d\n", rc); > - goto clk_err; > - } > - > - rc = msm_dss_clk_set_rate(mp->clk_config, mp->num_clk); > - if (rc) { > - pr_err("clock set rate failed rc=%d\n", rc); > - goto bus_err; > - } > - > rc = dpu_power_reg_bus_parse(pdev, phandle); > if (rc) { > pr_err("register bus parse failed rc=%d\n", rc); > @@ -742,17 +667,11 @@ int dpu_power_resource_init(struct platform_device > *pdev, > dpu_power_data_bus_unregister(>data_bus_handle[i]); > dpu_power_reg_bus_unregister(phandle->reg_bus_hdl); > bus_err: > - msm_dss_put_clk(mp->clk_config, mp->num_clk); > -clk_err: > msm_dss_config_vreg(>dev, mp->vreg_config, mp->num_vreg, 0); > vreg_err: > if (mp->vreg_config) > devm_kfree(>dev, mp->vreg_config); > mp->num_vreg = 0; > -parse_vreg_err: > - if (mp->clk_config) > - devm_kfree(>dev, mp->clk_config); > - mp->num_clk = 0; > end: > return rc; > } -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 08/11] drm/msm/dpu: remove power management code from dpu_power_handle

f-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/dpu_power_handle.c | 190 > + > drivers/gpu/drm/msm/dpu_power_handle.h | 2 - > 2 files changed, 1 insertion(+), 191 d

Re: [Freedreno] [DPU PATCH 06/11] drm/msm/dpu: use runtime_pm calls on dpu device

or all child nodes > (mdp5/dpu, dsi, dp etc) is done by parent MDSS device/driver > via runtime_pm due to parent child relationship. > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/di

Re: [Freedreno] [DPU PATCH 09/11] drm/msm/dp: remove dpu_power_handle calls from dp driver

like DP device. > For same reason, clock and power management code is > removed from dpu_power_handle. Hence, remove the > dpu_power_handle calls from dp driver. > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> >

Re: [Freedreno] [DPU PATCH 11/11] drm/msm/dpu: move dpu_power_handle to dpu folder

(_kms->base, _funcs); > @@ -1876,6 +1882,7 @@ static int dpu_init(struct platform_device *pdev, > struct drm_device *dev) > > return ret; > > +power_init_fail: Nit: No need to add an empty label, just use clk_rate_error above. With that fixed, Reviewed-by: Sean

Re: [Freedreno] [DPU PATCH 10/11] drm/msm/dpu: use runtime_pm calls in dpu_dbg

t; > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 +--- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 > drivers/gpu/drm/msm/disp/dp

Re: [Freedreno] [DPU PATCH 04/11] drm/msm/dpu: create new platform driver for dpu device

a..5470529 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -1731,6 +1731,7 @@ static int __init msm_drm_register(void) > > DBG("init"); > msm_mdp_register(); > + msm_dpu_register(); > msm_dsi_register();

Re: [Freedreno] [DPU PATCH 01/11] drm/msm: remove redundant pm_runtime_enable call from msm_drv

le call from msm_drv. > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/msm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/

Re: [Freedreno] [DPU PATCH 05/11] drm/msm/dpu: update dpu sub-block offsets wrt dpu base address

; > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 68 > +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 18 +++--- > 2

Re: [Freedreno] [DPU PATCH v2 08/12] drm/msm/dpu: remove power management code from dpu_power_handle

> Changes in v2: > - resolved merge conflict in dpu_power_resource_init > - dropped (Reviewed-by: Sean Paul) due to above change > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> > --- > drivers/gpu/drm/msm/dpu_power_handle.c | 194 > +-

Re: [Freedreno] [DPU PATCH v2 10/12] drm/msm/dpu: use runtime_pm calls in dpu_dbg

er access). > > Changes in v2: > - resolved conflict in dpu_core_perf_init > - dropped (Reviewed-by: Sean Paul) due to above change Reviewed-by: Sean Paul <seanp...@chromium.org> > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> > --- > drivers/gpu/drm

Re: [Freedreno] [DPU PATCH v2 04/12] drm/msm/dpu: create new platform driver for dpu device

unctionality. > > The dpu driver implements runtime_pm support for managing clocks > and bus bandwidth etc. > > Changes in v2: > - remove redundant param check from _dpu_kms_hw_destroy (Sean Paul) > - remove explicit calls to devm_kfree (Sean Paul) > -

Re: [Freedreno] [DPU PATCH v2 11/12] drm/msm/dpu: move dpu_power_handle to dpu folder

lict in dpu_unbind > - dropped (Reviewed-by: Sean Paul) due to above change > Reviewed-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> > --- > drivers/gpu/drm/msm/Makefile | 2 +- > driver

Re: [Freedreno] [DPU PATCH v2 03/12] drm/msm/dpu: add MDSS top level driver for dpu

evices due to parent > child relationship defined in dt. > > Changes in v2: > - merge _dpu_mdss_hw_rev_init to dpu_mdss_init (Sean Paul) > - merge _dpu_mdss_get_intr_sources to dpu_mdss_irq (Sean Paul) > - fix indentation for irq_find_mapping call (Sean Paul) >

Re: [Freedreno] [DPU PATCH v2 07/12] drm/msm/dpu: remove clock management code from dpu_power_handle

> > Changes in v2: > - remove local variable to hold and return error code > in _dpu_core_perf_set_core_clk_rate() instead return > retcode directly from msm_dss_clk_set_rate() call (Sean Paul) > - dpu_core_perf_init() is called from dpu_kms_hw_init() and

Re: [Freedreno] [DPU PATCH v2 12/12] drm/msm/dpu: add error handling in dpu_core_perf_crtc_update

anks for doing this :-) Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 37 > ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 3 ++- > 2 files changed, 27 insertions(+), 13 deletions(-) > >

Re: [Freedreno] [DPU PATCH v2 03/12] drm/msm/dpu: add MDSS top level driver for dpu

; > > It implements runtime_pm support for resource management. > > Child nodes can control these resources via runtime_pm > > get/put calls on their corresponding devices due to parent > > child relationship defined in dt. > > > > Changes in v2: > >

Re: [Freedreno] [DPU PATCH v2 5/6] drm/msm: hook up DPU with upstream DSI

ack and display port drivers > - compile out dsi-staging driver (separate patch submitted to > remove the driver) > - adapt upstream device hierarchy > > changes in v2: > - remove files not applicable upstream (Sean Paul) > - remove compiled out non-dsi disp

Re: [Freedreno] [DPU PATCH v2 2/7] drm/msm/dpu: clean up dpu plane custom properties

On Tue, Jun 05, 2018 at 08:45:33PM -0700, Jeykumar Sankaran wrote: > This change removes all the dpu plane custom properties > and its handlers. > > changs in v2: > - remove stale code in blend config(Sean Paul) > - Makefile changes to remove warning flags(Sean Pau

Re: [Freedreno] [DPU PATCH 4/4] drm/msm/dpu: use private obj to track hw resources

s. With > the new state based RM, its very unlikely we hit this condition. > In this case, add a comment with "/* This should never happen */" I'm just kidding, that would virtually guarantee that it does happen and we certainly don't need that bad juju ar

Re: [Freedreno] [DPU PATCH 4/4] drm/msm/dpu: use private obj to track hw resources

; > mode = >base.adjusted_mode; > priv = crtc->dev->dev_private; > + dpu_kms = to_dpu_kms(priv->kms); > + > + /* accessing after swap state. piv_obj.state is the current state */ s/piv_obj/priv_obj/ > + dpu_priv_state = to_dpu_private_sta

Re: [Freedreno] [DPU PATCH v3 0/7] clean up DPU custom properties

4 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c > delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h > delete mode 100644 drivers/gpu/drm/msm/msm_prop.c > delete mode 100644 drivers/gpu/drm/msm/msm_prop.h > delete mode 100644 include/uapi/drm/dpu_drm.h > delete mode

Re: [Freedreno] [DPU PATCH 0/4] Atomic resource management

nsertions(+), 1659 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH] drm/msm: Fix NULL deref on bind/probe deferral

mit to ensure the arguments to msm_gem_put_iova() are correct (even though that function has been a stub for ~5 years). Correctness FTW! \o/ Fixes: b01884a286b0 drm/msm: use correct aspace pointer in msm_gem_put_iova() Cc: Daniel Mack Cc: Rob Clark Signed-off-by: Sean Paul --- drivers/gpu/drm/

Re: [Freedreno] [DPU PATCH 2/7] drm/msm/dpu: clean up dpu plane custom properties

ult to opaque blending */ > - fg_alpha = dpu_plane_get_property(pstate, PLANE_PROP_ALPHA); > + fg_alpha = 0XFF; > bg_alpha = 0xFF - fg_alpha; This goes to 0 and the fg_alpha != 0xff checks are always false. So let's clean the rest of the function to remove the dead code and

Re: [Freedreno] [DPU PATCH 5/7] drm/msm/dpu: clean up dpu crtc custom properties

On Wed, May 23, 2018 at 12:31:00PM -0700, Jeykumar Sankaran wrote: > Remove dpu crtc custom properties and its handlers. > > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/Makefile | 1 - > drivers/gpu/drm/msm/disp/dp

Re: [Freedreno] [DPU PATCH 4/7] drm/msm/dpu: switch to drm zpos property

; so > printing the return value isn't interesting. Also if I was reviewing or casual reading this without the ret print, I would probably leave a comment such as "print the return value" since I don't generally keep track of all possible return values. So printing the return value seems reasonable to me. Sean > > > /* success! finalize initialization */ > > drm_plane_helper_add(plane, _plane_helper_funcs); > > > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > > > > ___ > > Freedreno mailing list > > Freedreno@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/freedreno > > -- > The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 4/7] drm/msm/dpu: switch to drm zpos property

ax = DPU_STAGE_MAX - DPU_STAGE_0 - 1; > + } > + > + ret = drm_plane_create_zpos_property(plane, 0, 0, zpos_max); > + if (ret) > + DPU_ERROR("failed to install zpos property, rc = %d\n", ret); > + > /* success! finalize initialization */ > drm_plane_helper_add(plane, _plane_helper_funcs); > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 6/7] drm/msm: remove msm_prop files

On Wed, May 23, 2018 at 12:31:01PM -0700, Jeykumar Sankaran wrote: > Remove hand rolled msm property caching to handle DPU > custom properties. This change also cleans up all its > dependencies to cache and restore respective drm > states. > > Signed-off-by: Jeykumar Sankaran

[Freedreno] [DPU PATCH 03/19] drm/msm: dpu_plane: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_plane with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 44 +++ 2 files changed, 49 insertions

[Freedreno] [DPU PATCH 07/19] drm/msm: dpu_encoder_phys_vid: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_encoder_phys_vid with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 36 --- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 35 ++ 2 files

[Freedreno] [DPU PATCH 10/19] drm/msm: dpu_core_irq: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_core_irq with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 52 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h| 50 +++ 2 files changed, 71

[Freedreno] [DPU PATCH 00/19] drm/msm: dpu: Clean up dpu_dbg

dpu_dbg.[ch] a bit and removes the arbitrary register reads, and evtlog duplication. Finally, the dpu_dbg files are moved into the dpu1 directory. Sean Sean Paul (19): drm/msm: dpu_encoder: Replace DPU_EVT with tracepoints drm/msm: dpu_crtc: Replace DPU_EVT with tracepoints drm/msm: dpu_plane

[Freedreno] [DPU PATCH 02/19] drm/msm: dpu_crtc: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_crtc with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 122 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 166 ++ 2 files changed, 210

[Freedreno] [DPU PATCH 13/19] drm/msm: dpu: Remove dpu evtlog

Now that everything has been converted to tracepoints, remove the dpu evtlog. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 - drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 33 --- drivers/gpu/drm/msm/dpu_dbg.c

[Freedreno] [DPU PATCH 11/19] drm/msm: dpu_core_perf: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_core_perf with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 17 + 2 files changed, 18 insertions(+), 1

[Freedreno] [DPU PATCH 19/19] drm/msm: dpu: Move dpu_dbg into dpu1 directory

Now that dpu_dbg is cleaned up, move it into dpu directory with the rest of dpu things. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/{ => disp/dpu1}/dpu_dbg.c | 0 drivers/gpu/drm/msm/{ => disp/dpu1}/dpu_dbg.h | 0 3 files chan

[Freedreno] [DPU PATCH 15/19] drm/msm: dpu: Remove arbitrary register dumps

This can be achieved via /dev/mem. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c| 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c| 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 3 - .../gpu/drm

[Freedreno] [DPU PATCH 05/19] drm/msm: dpu_kms: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_kms with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 19 --- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 16 2 files changed, 28 insertions

[Freedreno] [DPU PATCH 16/19] drm/msm: dpu: Remove panic from dpu debug dump

Better not to allow arbitrary panics of the kernel when poking debugfs files. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- drivers/gpu/drm/msm

[Freedreno] [DPU PATCH 06/19] drm/msm: dpu_encoder_phys_cmd: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_encoder_phys_cmd with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 79 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 68 2 files

[Freedreno] [DPU PATCH 01/19] drm/msm: dpu_encoder: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_encoder with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 290 - drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 329 2 files changed, 464

[Freedreno] [DPU PATCH 09/19] drm/msm: dpu_pingpong: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_pingpong with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 3 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 14 ++ 2 files changed, 16 insertions

[Freedreno] [DPU PATCH 08/19] drm/msm: dpu_vbif: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_vbif with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 15 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 7 +++ 2 files changed, 18 insertions(+), 4 deletions

[Freedreno] [DPU PATCH 12/19] drm/msm: dpu_mdss: Replace DPU_EVT with DRM_ERROR

The events are only issued in error cases, so use DRM_ERROR instead. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [DPU PATCH 04/19] drm/msm: dpu_rm: Replace DPU_EVT with tracepoints

This patch converts all DPU_EVTs in dpu_rm with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c| 65 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 49 + 2 files changed, 78 insertions

[Freedreno] [DPU PATCH 17/19] drm/msm: dpu: Remove dsi debug block name

Leftover from dsi-staging, it looks like. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dpu_dbg.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dpu_dbg.c b/drivers/gpu/drm/msm/dpu_dbg.c index 2a9b8c732e33..51d46975cc27 100644 --- a/drivers/gpu/drm/msm/dpu_dbg.c

[Freedreno] [PATCH] drm/msm: Disable mdp5 crtc when there are no active planes

. Signed-off-by: Sean Paul --- Sorry for the wide distribution, I'm not 100% on whether this is the right place to fix this. Is this expected behavior from weston? Once we have solid fill support, it seems reasonable that a crtc might be left on if no planes are active (for blanking the screen, etc

Re: [Freedreno] [PATCH v5 1/4] drm/bridge: add support for sn65dsi86 bridge driver

iver and create a separate edp panel drivers to handle panel >specific mode information and HW resources (Sean Paul). > - Replace pr_* APIs to DRM_* APIs to log error or debug information >(Sean Paul). > - Remove some of the unnecessary structure/variable from driver (S

[Freedreno] [DPU PATCH] drm/msm: Remove msm_hdcp devicetree bindings

hdcp support was (temporarily) removed from msm. Signed-off-by: Sean Paul --- .../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 -- 1 file changed, 14 deletions(-) delete mode 100644 Documentation/devicetree/bindings/msm_hdcp/msm_hdcp.txt diff --git a/Documentation

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

On Wed, Feb 14, 2018 at 07:22:53AM -0500, Rob Clark wrote: > On Wed, Feb 14, 2018 at 3:30 AM, Daniel Stone <dan...@fooishbar.org> wrote: > > Hi Rob, > > > > On 13 February 2018 at 20:00, Rob Clark <robdcl...@gmail.com> wrote: > >> On Tue, Feb 13, 2018 at

[Freedreno] [PATCH RESEND 00/10] drm/msm: A handful of dpu fixes

/log/?h=for-next *** BLURB HERE *** Jeykumar Sankaran (1): drm/msm/dpu: Fix writeback compile macros Sean Paul (9): drm/msm: Add displayport files to Makefile drm/msm: Include the dpu_dbg header in msm_drv.c drm/msm: Change driver name back to msm drm/msm: Remove smmu driver init/cleanup

[Freedreno] [PATCH 04/10] drm/msm: Remove smmu driver init/cleanup from msm_drv

Leftover bits from the initial removal of smmu. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 106678a164c2..9532321a0e4f

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_plane_state->defer_prepare_fb

On Thu, Feb 22, 2018 at 03:02:44PM -0500, Rob Clark wrote: > On Wed, Feb 21, 2018 at 2:43 PM, Sean Paul <seanp...@chromium.org> wrote: > > It's never set to true, so none of this code is ever run. > > > > Signed-off-by: Sean Paul <seanp...@chromium.org> >

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

nuxgraphics/gfx-docs/drm/gpu/drm-kms.html?highlight=drm_hdmi_info#c.drm_hdmi_info Is this sufficient? Sean > > Thanks > > Abhinav > > > On 2018-02-23 11:15, Sean Paul wrote: > > Use drm_edid to parse the edid instead of the hand rolled dpu version. > > > >

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 04:48:58PM +, Liviu Dudau wrote: > On Fri, Feb 23, 2018 at 11:43:29AM -0500, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > > > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul <seanp...@chromium.org> wrote:

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul <seanp...@chromium.org> wrote: > > > > Have we considered hiding writeback behind a client cap instead? > > It is kinda *almost* unneeded, since the connector repor

Re: [Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

+ mdp5_wb = kzalloc(sizeof(*mdp5_wb), GFP_KERNEL); > + if (!mdp5_wb) > + return ERR_PTR(-ENOMEM); > + > + mdp5_wb->id = wb_id; > + mdp5_wb->ctl = ctl; > + > + /* construct a dummy intf for WB: */ > +// TODO un-inline this (and also in interface_init()) > + mdp5_wb->intf = kzalloc(sizeof(*mdp5_wb->intf), GFP_KERNEL); > + mdp5_wb->intf->num = -1; > + mdp5_wb->intf->type = INTF_WB; > + mdp5_wb->intf->mode = MDP5_INTF_WB_MODE_LINE; > + mdp5_wb->intf->idx = -1; > + > + mdp5_wb->wb_done.irq = mdp5_wb_done_irq; > +// TODO just register for all wb irq's until I figure out the mapping.. > + mdp5_wb->wb_done.irqmask = MDP5_IRQ_WB_0_DONE | MDP5_IRQ_WB_1_DONE | > MDP5_IRQ_WB_2_DONE; > + > + connector = _wb->base.base; > + > + drm_connector_helper_add(connector, _wb_connector_helper_funcs); > + > + mdp5_wb->nformats = mdp_get_formats(mdp5_wb->formats, > + ARRAY_SIZE(mdp5_wb->formats), false); > + > + drm_writeback_connector_init(dev, > + _wb->base, > + _wb_connector_funcs, > + _wb_encoder_helper_funcs, > + mdp5_wb->formats, > + mdp5_wb->nformats); > + > + connector->interlace_allowed = 0; > + connector->doublescan_allowed = 0; These are handled by drm_writeback_connector_init (and kzalloc) > + > + return _wb->base; > +} > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c > b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 7a03a9489708..422f524f7562 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -741,7 +741,7 @@ static void dsi_intr_ctrl(struct msm_dsi_host *msm_host, > u32 mask, int enable) > else > intr &= ~mask; > > - DBG("intr=%x enable=%d", intr, enable); > + VERB("intr=%x enable=%d", intr, enable); > > dsi_write(msm_host, REG_DSI_INTR_CTRL, intr); > spin_unlock_irqrestore(_host->intr_lock, flags); > @@ -1465,7 +1465,7 @@ static irqreturn_t dsi_host_irq(int irq, void *ptr) > dsi_write(msm_host, REG_DSI_INTR_CTRL, isr); > spin_unlock_irqrestore(_host->intr_lock, flags); > > - DBG("isr=0x%x, id=%d", isr, msm_host->id); > + VERB("isr=0x%x, id=%d", isr, msm_host->id); > > if (isr & DSI_IRQ_ERROR) > dsi_error(msm_host); > -- > 2.14.3 > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [RFC 2/4] drm: writeback: Add out-fences for writeback connectors

me.) > - Update documentation around WRITEBACK_OUT_FENCE_PTR > > Signed-off-by: Brian Starkey <brian.star...@arm.com> > [rebased and fixed conflicts] > Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> > Signed-off-by: Liviu Dudau <liviu.du...@arm.com>

[Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

Use drm_edid to parse the edid instead of the hand rolled dpu version. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/dp/dp_audio.c | 22 +- drivers/gpu/drm/msm/dp/dp_display.c | 7 - drivers/gpu/drm/

[Freedreno] [PATCH RESEND 10/10] drm/msm: Restore msm_atomic_check hook

Somehow this got lost, put it back. We might want to re-evaluate whether this is actually necessary, but for now let's actually use the thing. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Freedreno] [PATCH RESEND 06/10] drm/msm: Fix deadlock calling msm_gem_new()

msm_gem_new() acquires the struct_mutex, so surrounding this call with locks causes deadlocks all day long. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dis

[Freedreno] [PATCH RESEND 09/10] drm/msm/dpu: Fix writeback compile macros

d commit msg and reduced to one block inside the function] Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu

[Freedreno] [PATCH RESEND 01/10] drm/msm: Add displayport files to Makefile

Still behind a config flag, and ymmv when trying to build them, but they're present at least. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/Makefile | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/d

[Freedreno] [PATCH RESEND 00/10] drm/msm: A handful of dpu fixes

esktop.org/~seanpaul/dpu-staging/log/?h=for-next Jeykumar Sankaran (1): drm/msm/dpu: Fix writeback compile macros Sean Paul (9): drm/msm: Add displayport files to Makefile drm/msm: Include the dpu_dbg header in msm_drv.c drm/msm: Change driver name back to msm drm/msm: Remove smmu driver in

[Freedreno] [PATCH RESEND 02/10] drm/msm: Include the dpu_dbg header in msm_drv.c

We'll need to clean up these conditionals further, but at least fix the compilation error. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c

[Freedreno] [PATCH RESEND 04/10] drm/msm: Remove smmu driver init/cleanup from msm_drv

Leftover bits from the initial removal of smmu. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 106678a164c2..9532321a0e4f

[Freedreno] [PATCH RESEND 03/10] drm/msm: Change driver name back to msm

So userspace can find it again. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 6f2affe5ccff..106678a164c2

[Freedreno] [PATCH RESEND 07/10] drm/msm: Populate kms->irq for dpu

The irq wasn't actually getting installed b/c kms->irq was vacant. Fill it in. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gp

[Freedreno] [PATCH RESEND 08/10] drm/msm: Sprinkle pm_runtime calls around

Adding missing pm_runtime references where appropriate. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/g

[Freedreno] [DPU PATCH] drm: Remove duplicate ycbcr420 parsing

Introduced in the dpu patch series, this duplicaates the already existing do_y420vdb_modes function. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/drm_edid.c | 77 -- 1 file changed, 77 deletions(-) diff --git a/drivers/g

[Freedreno] [DPU PATCH] drm/mipi: Remove unused mipi/dsi packet types

These were added with the rest of the DPU patches, but they're unused. There's no reason to add them unless someone is actually interested in sending them. So for now, remove them. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/drm_mipi_dsi.c | 2 -- include

Re: [Freedreno] [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format

next-staging, and the patches which have been reviewed on list will go to the for-next branch. Sean > Thanks > > Abhinav > > -Original Message- > From: Rob Clark [mailto:robdcl...@gmail.com] > Sent: Thursday, February 22, 2018 11:49 AM > To: Sean Paul <seanp...@c

[Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

We already have CONFIG_DRM_MSM_HDMI_HDCP, with accompanying stubs in hdmi/hdmi.h. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c b/d

[Freedreno] [DPU PATCH 1/2] drm/msm: dpu: Remove dpu_format_populate_layout_with_roi()

It's unused, so let's get rid of it. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 31 - drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 16 --- 2 files changed, 47 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b

[Freedreno] [DPU PATCH 2/2] drm/msm: dpu: Remove dpu_rect

Well, that was a lot stickier than I thought it would be! This patch removes dpu_rect and its helpers in favor of drm_rect and its helpers. Signed-off-by: Sean Paul --- Based on my tracepoints set. drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 86 drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [DPU PATCH] drm/msm: Remove more dpu changes from msm core

This patch is removing a bunch more dpu changes that touch msm core. I'm pretty sure the event_thread stuff can go, but I might be wrong about that aspect. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 242 +--- drivers/gpu/drm/msm/disp/dpu1

Re: [Freedreno] [PATCH] drm/msm/dpu: enable cursor plane on dpu

VERLAY/CURSOR > * @possible_crtcs: bitmask of crtc that can be attached to the given pipe > * @master_plane_id: primary plane id of a multirect pipe. 0 value passed for > * a regular plane initialization. A non-zero primary plane &g

[Freedreno] [PATCH 1/3] drm/msm: dsi: Initialize msm_dsi->id to -1

ray. This patch initializes the id to -1 and checks for negative in the manager cleanup. Cc: Doug Anderson Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.c | 1 + drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/

[Freedreno] [PATCH 2/3] drm/msm: dsi: Return errors whan dt parsing fails

If dt parsing fails, we should return an error instead of pretending everything completed successfully. Cc: Doug Anderson Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm

[Freedreno] [PATCH 3/3] drm/msm: Don't fail bind if nothing connected to dsi

If there is no bridge or panel connected to a dsi node, don't fail the entire msm bind. Just ignore the dsi block and move on. Cc: Doug Anderson Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[Freedreno] [PATCH 0/3] drm/msm: dsi: Properly handle disconnected secondary dsi block

to anything. Sean Sean Paul (3): drm/msm: dsi: Initialize msm_dsi->id to -1 drm/msm: dsi: Return errors whan dt parsing fails drm/msm: Don't fail bind if nothing connected to dsi drivers/gpu/drm/msm/dsi/dsi.c | 10 -- drivers/gpu/drm/msm/dsi/dsi_host.c| 2 ++ driv

Re: [Freedreno] [PATCH][drm-next] drm/msm/disp/dpu: fix two spelling mistakes

On Mon, Jul 30, 2018 at 02:44:46PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error messages > "diable" -> "disable" > "cliend" -> "client" > > Signed-off-by: Colin Ian Kin

[Freedreno] [PATCH v4 03/19] drm: add msm compressed format modifiers

for DRM_FORMAT_MOD_QCOM_COMPRESSED (Rob Clark) Changes in v4: - Remove all modifiers aside from COMPRESSED, this includes tiled and 10-bit Signed-off-by: Jeykumar Sankaran Signed-off-by: Sean Paul Signed-off-by: Rob Clark --- include/uapi/drm/drm_fourcc.h | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dpu: add atomic private object to dpu kms

On Tue, Aug 14, 2018 at 05:38:31PM -0700, Jeykumar Sankaran wrote: > On 2018-08-14 13:26, Sean Paul wrote: > > On Tue, Aug 07, 2018 at 08:20:10PM -0700, Jeykumar Sankaran wrote: > > > Subclass drm private state for DPU for handling driver > > > specific data. Adds atomic

Re: [Freedreno] [PATCH v3 03/13] drm/msm/dpu: remove ping pong split topology variables

5 > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h > index e84da78..e

Re: [Freedreno] [PATCH v3 02/13] drm/msm/dpu: remove resource pool manager

se on [1] > > [1] https://gitlab.freedesktop.org/seanpaul/dpu-staging/commits/for-next > > Change-Id: Ib045f1c66269be650bce5896c459f59e1047a53f > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 205 > ---

Re: [Freedreno] [PATCH v3 10/13] drm/msm/dpu: remove topology name

u_rm.h > b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h > index ffd1841..de52c03 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h > @@ -187,13 +187,4 @@ void dpu_rm_init_hw_iter( > */ > int dpu_rm_check_property_topctl(uint64_t val); > >

Re: [Freedreno] [PATCH v3 13/13] drm/msm/dpu: use private obj to track hw resources

On Tue, Aug 07, 2018 at 08:20:11PM -0700, Jeykumar Sankaran wrote: > Switch to state based resource management. This patch > overhauls the resource manager and HW allocation methods by > maintaining the global resource pool and allocated hw > blocks in respective drm component states. > > Global

Re: [Freedreno] [PATCH v3 04/13] drm/msm/dpu: program master-slave encoders explicitly

;cur_master->ops.enable) > - dpu_enc->cur_master->ops.enable(dpu_enc->cur_master); > - There's a change in functionality here. Previously you could call setup_misr for slaves after they are enabled, but before master is enabled. Now you're calling it after all are enabled. I'm guessing it doesn't matter since it was previously called on master before it was enabled, but I figure I'd point this out. Sean > _dpu_encoder_virt_enable_helper(drm_enc); > } > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v3 11/13] drm/msm/dpu: remove display H_TILE from encoder

we need to remove the DPU_* messages in favor of DRM_*, so let's try not to go backwards in the meantime. Sean > + reqs->topology->num_lm, reqs->topology->num_ctl, > + reqs->topology->top_name, > + reqs->topology->needs_split_display); > > return 0; > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

  1   2   3   4   5   6   7   8   >