Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks for the comments. I will upload a new patch for this which will be dependent on https://patchwork.kernel.org/patch/10377537/ series. This series registers the backlight device we need. Thanks Abhinav On 2018-04-18 21:42, Bjorn Andersson wrote: On Wed 18 Apr 21:23 PDT

Re: [Freedreno] [DPU PATCH v2 1/2] drm/panel: Add Truly NT35597 panel

Thanks Archit for your comments. I have addressed all of them in V3 and added Theirry Reading and Rob Herring for reviews as well. Abhinav On 2018-04-19 10:44, Archit Taneja wrote: Hi, On Saturday 14 April 2018 12:55 PM, Abhinav Kumar wrote: From: Archit Taneja

Re: [Freedreno] [DPU PATCH] drm/msm/dsi: add only dsi nodes with a valid device to list

Hi Jordan Thanks for the review. Comments inline. Abhinav On 2018-06-18 07:23, Jordan Crouse wrote: On Fri, Jun 15, 2018 at 11:05:57PM -0700, Abhinav Kumar wrote: Before adding a DSI node to the private list check if the node has a valid device connected to it through an endpoint. This is

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

The bitmaps in drm_hdmi_info dont seem to be exposed to userspace. Our mode selection logic is in userspace at the moment which means its better userspace knows which modes support what. If we decide to move mode validation entirely to the driver, we can use these bitmaps to validate. But

Re: [Freedreno] [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format

Alright, found it https://cgit.freedesktop.org/~seanpaul/dpu-staging/commit/?h=mtp-testing=34906195473f9e04601c49a45e3fedce0132eb7e Thanks Abhinav On 2018-02-23 07:06, Sean Paul wrote: On Thu, Feb 22, 2018 at 9:28 PM, Abhinav Kumar wrote: Looks good. Can you point us

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

I am OK with removing some parts of the parser but not entirely. Fundamentally, we went ahead with the parser for a couple of reasons: -> We would like to be able to associate the color format with the mode. This helps us decide that if the same mode supports both RGB/YUV then which one we

Re: [Freedreno] [PATCH 2/3] drm/msm: dsi: Return errors whan dt parsing fails

On 2018-07-30 08:26, Sean Paul wrote: If dt parsing fails, we should return an error instead of pretending everything completed successfully. Cc: Doug Anderson Signed-off-by: Sean Paul Thanks for fixing this ! Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1

Re: [Freedreno] [PATCH 3/3] drm/msm: Don't fail bind if nothing connected to dsi

On 2018-07-30 08:26, Sean Paul wrote: If there is no bridge or panel connected to a dsi node, don't fail the entire msm bind. Just ignore the dsi block and move on. Cc: Doug Anderson Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 9 +++-- 1

Re: [Freedreno] [PATCH 1/3] drm/msm: dsi: Initialize msm_dsi->id to -1

On 2018-07-30 08:26, Sean Paul wrote: Currently msm_dsi->id is initialized to 0 during kzalloc. If bind fails for a secondary dsi device before its id can be properly set (such as during dt parsing), the id will point to the primary dsi device, causing its reference to be removed from

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

On 2018-03-12 13:11, Sean Paul wrote: On Mon, Feb 26, 2018 at 02:23:40PM -0800, abhin...@codeaurora.org wrote: On 2018-02-26 07:36, Sean Paul wrote: > On Fri, Feb 23, 2018 at 05:48:48PM -0500, Rob Clark wrote: > > On Fri, Feb 23, 2018 at 5:31 PM, wrote: > > > The

Re: [Freedreno] [DPU PATCH 10/11] drm/msm: Switch to atomic_helper_commit()

On 2018-03-12 13:32, Sean Paul wrote: On Thu, Mar 08, 2018 at 07:28:08PM -0800, abhin...@codeaurora.org wrote: On 2018-02-28 11:19, Sean Paul wrote: > Now that all of the msm-specific goo is tucked safely away we can switch > over to using the atomic helper commit directly. \o/ > [Abhinav] Can

Re: [Freedreno] [DPU PATCH] drm: Remove duplicate ycbcr420 parsing

On 2018-03-08 16:48, Jeykumar Sankaran wrote: On 2018-02-21 10:30, Sean Paul wrote: Introduced in the dpu patch series, this duplicaates the already existing do_y420vdb_modes function. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran

Re: [Freedreno] [DPU PATCH 09/11] drm/msm: Remove prepare_fence kms_function

On 2018-02-28 11:19, Sean Paul wrote: This is the last piece that is keeping us from matching the atomic helper commit function. By removing this (now unused) hook, we can switch to drm_atomic_helper_commit() Change-Id: I081056a6e1689807871f5deedc76499bb91b6969 Signed-off-by: Sean Paul

Re: [Freedreno] [DPU PATCH 10/11] drm/msm: Switch to atomic_helper_commit()

On 2018-02-28 11:19, Sean Paul wrote: Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ [Abhinav] Can we say something like "Move remaining msm-specific operations to private handles and switch to atomic helper commit

Re: [Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

On 2018-03-12 13:12, Sean Paul wrote: On Tue, Feb 27, 2018 at 11:24:31AM -0500, Sean Paul wrote: On Mon, Feb 26, 2018 at 03:01:14PM -0800, abhin...@codeaurora.org wrote: > The change itself is okay. So, Reviewed-by? Sean > However I am planning to do a bigger cleanup here > ( removing the

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

Hi Sean Thanks for the review. Reply inline. On 2018-04-13 13:26, Sean Paul wrote: On Tue, Apr 10, 2018 at 06:54:06PM -0700, Abhinav Kumar wrote: Make sure the video mode engine is on before waiting for the video done interrupt. Otherwise it leads to silent timeouts increasing display turn

Re: [Freedreno] [DPU PATCH v2 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

On 2018-04-13 13:29, Sean Paul wrote: On Tue, Apr 10, 2018 at 06:54:07PM -0700, Abhinav Kumar wrote: Currently the DSI PHY timings are hard-coded for a specific panel for the 10nm PHY. Replace this with the auto PHY timing calculator which can calculate the PHY timings for any panel. Any

Re: [Freedreno] [DPU PATCH 1/2] drm/panel: Add Truly Dual DSI video mode panel

On 2018-04-08 09:36, Archit Taneja wrote: Hi Abhinav, Thanks for posting this driver. Some comments below. On Saturday 07 April 2018 12:36 PM, Abhinav Kumar wrote: From: Archit Taneja Add support for truly dual DSI video mode panel panel used in MSM reference

Re: [Freedreno] [DPU PATCH] drm/msm: dpu: Fix build warnings

On 2018-04-20 09:07, Sean Paul wrote: Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 5 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++--

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks very much for the detailed response. Yes, we decided that userspace hardcoding this node name is not a strong enough reason to register as another backlight device. Had one follow up question though. The QC WLED driver, drivers/leds/leds-qpnp-wled.c is not registering

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

Hi Sean Thanks for reviewing. Reply inline. On 2018-04-16 10:07, Sean Paul wrote: On Fri, Apr 13, 2018 at 03:04:48PM -0700, abhin...@codeaurora.org wrote: On 2018-04-13 14:10, abhin...@codeaurora.org wrote: > Hi Sean > > Thanks for the review. > > Reply inline. > > On 2018-04-13 13:26, Sean

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks for the review. Reply inline. On 2018-04-16 09:41, Bjorn Andersson wrote: On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar wrote: Register truly panel as a backlight led device and provide methods to control its backlight operation. Changes in v2: - Removed redundant NULL checks

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks for the comments. Reply inline. On 2018-04-16 23:13, Bjorn Andersson wrote: On Mon 16 Apr 15:45 PDT 2018, abhin...@codeaurora.org wrote: Hi Bjorn Thanks for the review. Reply inline. On 2018-04-16 09:41, Bjorn Andersson wrote: > On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Apologies if the prev reply wasnt clear. Hope this one is. reply inline. On 2018-04-17 14:29, Bjorn Andersson wrote: On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: On 2018-04-16 23:13, Bjorn Andersson wrote: [..] > If the panel isn't actually a piece of backlight

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Adding another point. On 2018-04-17 17:04, abhin...@codeaurora.org wrote: Hi Bjorn Apologies if the prev reply wasnt clear. Hope this one is. reply inline. On 2018-04-17 14:29, Bjorn Andersson wrote: On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: On 2018-04-16 23:13, Bjorn

Re: [Freedreno] [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format

On 2018-02-23 13:34, abhin...@codeaurora.org wrote: Alright, found it https://cgit.freedesktop.org/~seanpaul/dpu-staging/commit/?h=mtp-testing=34906195473f9e04601c49a45e3fedce0132eb7e Thanks Abhinav Reviewed-by: Abhinav Kumar On 2018-02-23 07:06, Sean Paul wrote:

Re: [Freedreno] [DPU PATCH] drm: Remove unused drm_connector fields.

On 2018-03-02 12:06, jsa...@codeaurora.org wrote: On 2018-02-26 08:49, Sean Paul wrote: They're not used, so let's get rid of them. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran --- include/drm/drm_connector.h | 19

Re: [Freedreno] [DPU PATCH] drm: Remove unused drm_connector fields.

On 2018-03-02 12:17, abhin...@codeaurora.org wrote: On 2018-03-02 12:06, jsa...@codeaurora.org wrote: On 2018-02-26 08:49, Sean Paul wrote: They're not used, so let's get rid of them. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran

Re: [Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

The change itself is okay. However I am planning to do a bigger cleanup here ( removing the entire hdmi_hdcp.c ). We dont use this file as we have our equivalent sde_hdcp_1x.c. Was planning this cleanup as part of the HDCP 1x requirements. If we want to push this as as separate change, I am

Re: [Freedreno] [PATCH] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation

On 2020-04-07 10:07, Roy Spliet wrote: When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined behaviour, likely a nullptr exception or use-after-free troubles. Signed-off-by: Roy Spliet Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 3 ++-

Re: [Freedreno] [PATCH] drm/msm: Fix typo

On 2020-04-12 07:35, Christophe JAILLET wrote: Duplicated 'we' Signed-off-by: Christophe JAILLET Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: move vblank events to complete_commit()

On 2020-09-07 10:04, Rob Clark wrote: From: Rob Clark We could get a vblank event racing with the current atomic commit, resulting in sending the pageflip event to userspace early, causing tearing. On the other hand, complete_commit() ensures that the pending flush is complete.

Re: [Freedreno] [PATCH v12 0/5] Add support for DisplayPort driver on SnapDragon

Thanks Rob for pushing the changes. I confirm that the versions which you have pushed are the latest ones. I have rebased audio changes on top of the latest DP changes and posted them here https://patchwork.freedesktop.org/series/81612/. The other DP change which is missing is the video pattern

Re: [Freedreno] [PATCH 1/2] drm/msm: Avoid div-by-zero in dpu_crtc_atomic_check()

On 2020-09-01 14:59, Stephen Boyd wrote: The cstate->num_mixers member is only set to a non-zero value once dpu_encoder_virt_mode_set() is called, but the atomic check function can be called by userspace before that. Let's avoid the div-by-zero here and inside _dpu_crtc_setup_lm_bounds() by

Re: [Freedreno] [PATCH 2/2] drm/msm: Drop debug print in _dpu_crtc_setup_lm_bounds()

On 2020-09-01 14:59, Stephen Boyd wrote: This function is called quite often if you have a blinking cursor on the screen, hello page flip. Let's drop this debug print here because it means enabling the print via the module parameter starts to spam the debug console. Cc: Abhinav Kumar Cc:

Re: [Freedreno] [PATCH 2/2] drm/msm/dpu: clean up some impossibilities

On 2020-09-07 10:04, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 81 1 file changed, 12 insertions(+), 69 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

Re: [Freedreno] [PATCH 2/2] drm/msm/dpu: clean up some impossibilities

On 2020-09-08 13:11, Rob Clark wrote: On Tue, Sep 8, 2020 at 12:44 PM wrote: On 2020-09-07 10:04, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 81 > 1 file

Re: [Freedreno] [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get()

Hi Stephen Thanks for the review. On 2020-09-23 23:32, Stephen Boyd wrote: Quoting Abhinav Kumar (2020-09-23 16:24:48) Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning. Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to

Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks

On 2020-09-28 12:16, Stephen Boyd wrote: Printk messages need newlines. Add it here. Cc: Abhinav Kumar Cc: Jeykumar Sankaran Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Stephen Boyd Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4

Re: [Freedreno] [PATCH] drm/msm: fix 32b build warns

On 2020-09-28 17:19, Rob Clark wrote: From: Rob Clark Neither of these code-paths apply to older 32b devices, but it is rude to introduce warnings. Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-

Re: [Freedreno] [PATCH] drm/msm/dpu: fix clock scaling on non-sc7180 board

On 2020-10-27 03:23, Dmitry Baryshkov wrote: c33b7c0389e1 ("drm/msm/dpu: add support for clk and bw scaling for display") has added support for handling bandwidth voting in kms path in addition to old mdss path. However this broke all other platforms since _dpu_core_perf_crtc_update_bus() will

Re: [Freedreno] [PATCH 3/4] drm/msm: fix -Woverride-init warning

On 2020-10-26 12:41, Arnd Bergmann wrote: From: Arnd Bergmann There is one harmless duplicate initialization that causes a warning with 'make W=1': drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:122:19: warning: initialized field overwritten [-Woverride-init] 122 | .max_linewidth = 4096,

Re: [Freedreno] [PATCH] drm/msm: ratelimit crtc event overflow error

On 2020-07-01 13:36, Rob Clark wrote: From: Rob Clark This can happen a lot when things go pear shaped. Lets not flood dmesg when this happens. Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Freedreno] [PATCH 20/40] drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse

On 2020-11-23 03:18, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function parameter or member 'ctx' not described in 'dpu_hw_sspp_setup_format' drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function

Re: [Freedreno] [PATCH 35/40] drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function param descriptions

On 2020-11-23 03:19, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function parameter or member 'plane' not described in '_dpu_plane_calc_bw' drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function parameter

Re: [Freedreno] [PATCH 19/40] drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx'

On 2020-11-23 03:18, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c:55: warning: Function parameter or member 'ctx' not described in '_stage_offset' drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c:55: warning: Excess function parameter

Re: [Freedreno] [PATCH 18/40] drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues

On 2020-11-23 03:18, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function parameter or member 'cur_slave' not described in 'dpu_encoder_virt' drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function

Re: [Freedreno] [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues

On 2020-11-23 03:18, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:31: warning: Enum value 'DPU_PERF_MODE_MAX' not described in enum 'dpu_perf_mode' drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:34: warning: Cannot understand

Re: [Freedreno] [PATCH 12/40] drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header

On 2020-11-23 03:18, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'fmt' not described in 'INTERLEAVED_RGB_FMT' drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter

Re: [Freedreno] [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description

On 2020-11-23 03:19, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:247: warning: Excess function parameter 'Return' description in '_dpu_rm_check_lm_peer' drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Function parameter or

Re: [Freedreno] [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static

On 2020-11-23 03:19, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/msm_drv.c:124:15: warning: no previous prototype for ‘_msm_ioremap’ [-Wmissing-prototypes] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc:

Re: [Freedreno] [PATCH 14/40] drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used

On 2020-11-23 03:18, Lee Jones wrote: These tables are not large or overbearing, so moving them into the source file seems like the right thing to do. The alternative is to use __maybe_unused, which is undesirable. Fixes the following W=1 kernel build warning(s): In file included from

Re: [Freedreno] [PATCH] drm/msm/dpu: update the qos remap only if the client type changes

Hi Rob On 2020-11-23 15:18, Rob Clark wrote: On Thu, Nov 19, 2020 at 1:41 PM Abhinav Kumar wrote: Update the qos remap only if the client type changes for the plane. This will avoid unnecessary register programming and also avoid log spam from the dpu_vbif_set_qos_remap() function.

Re: [Freedreno] [PATCH 15/40] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote kernel-doc formatting misuse

On 2020-11-26 05:42, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:246: error: Cannot parse struct or union! drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:756: error: Cannot parse struct or union! Cc: Rob Clark Cc:

Re: [Freedreno] [PATCH] msm/mdp5: Fix some kernel-doc warnings

On 2020-11-29 10:12, Rob Clark wrote: From: Rob Clark Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function parameter or member 'ctl' not described in 'mdp5_ctl_set_encoder_state' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227:

Re: [Freedreno] [PATCH 34/40] drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers

On 2020-11-13 05:49, Lee Jones wrote: Very little attempt has been made to document these functions. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function parameter or member 'ctl' not described in 'mdp5_ctl_set_encoder_state'

Re: [Freedreno] [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en, dis}able()' static

On 2020-11-13 05:49, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:299:5: warning: no previous prototype for ‘mdp5_disable’ [-Wmissing-prototypes] drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:319:5: warning: no previous prototype for

Re: [Freedreno] [PATCH 38/40] drm/msm/disp/dpu1/dpu_core_perf: Remove set but unused variable 'dpu_cstate'

On 2020-11-13 05:49, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c: In function ‘_dpu_core_perf_calc_crtc’: drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:113:25: warning: variable ‘dpu_cstate’ set but not used

Re: [Freedreno] [PATCH 39/40] drm/msm/disp/dpu1/dpu_encoder: Remove a bunch of unused variables

On 2020-11-13 05:49, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function ‘dpu_encoder_virt_mode_set’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:981:31: warning: variable ‘num_dspp’ set but not used

Re: [Freedreno] [PATCH 32/40] drm/msm/disp/mdp5/mdp5_crtc: Make local function 'mdp5_crtc_setup_pipeline()' static

On 2020-11-13 05:49, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:581:5: warning: no previous prototype for ‘mdp5_crtc_setup_pipeline’ [-Wmissing-prototypes] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc:

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

On 2020-11-18 12:03, abhin...@codeaurora.org wrote: Hi Stephen On 2020-11-18 07:49, Rob Clark wrote: On Tue, Nov 17, 2020 at 2:53 PM Stephen Boyd wrote: Quoting abhin...@codeaurora.org (2020-11-17 12:34:56) > On 2020-11-17 09:26, Stephen Boyd wrote: > > I don't know what this debug print is

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

Hi Stephen On 2020-11-18 07:49, Rob Clark wrote: On Tue, Nov 17, 2020 at 2:53 PM Stephen Boyd wrote: Quoting abhin...@codeaurora.org (2020-11-17 12:34:56) > On 2020-11-17 09:26, Stephen Boyd wrote: > > I don't know what this debug print is for but it is super chatty, > > throwing 8 lines of

Re: [Freedreno] [PATCH] drm/msm: Fix error return code in msm_drm_init()

On 2020-11-16 18:36, Wei Li wrote: When it fail to create crtc_event kthread, it just jump to err_msm_uninit, while the 'ret' is not updated. So assign the return code before that. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Hulk Robot Signed-off-by: Wei Li

Re: [Freedreno] [PATCH] drm/msm/dpu: Fix error return code in dpu_mdss_init()

On 2020-11-16 18:56, Chen Zhou wrote: Fix to return a negative error code from the error handling case instead of 0 in function dpu_mdss_init(), as done elsewhere in this function. Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") Reported-by: Hulk Robot Signed-off-by: Chen

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

On 2020-11-17 09:26, Stephen Boyd wrote: I don't know what this debug print is for but it is super chatty, throwing 8 lines of debug prints in the logs every time we update a plane. It looks like it has no value. Let's nuke it so we can get better logs. Cc: Sean Paul Cc: Abhinav Kumar

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

Hi Stephen On 2020-11-02 15:06, Stephen Boyd wrote: Quoting abhin...@codeaurora.org (2020-11-02 14:43:33) Hi Stephen Thanks for the review. On 2020-11-02 13:19, Stephen Boyd wrote: > Quoting Abhinav Kumar (2020-10-29 13:55:09) >> For sinks that do not support audio, there is no need to

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

Hi Stephen Thanks for the review. On 2020-11-02 13:19, Stephen Boyd wrote: Quoting Abhinav Kumar (2020-10-29 13:55:09) For sinks that do not support audio, there is no need to notify audio subsystem of the connection event. This will make sure that audio routes only to the primary display

Re: [Freedreno] [PATCH] drm/msm/atomic: Drop per-CRTC locks in reverse order

On 2020-10-20 15:26, Rob Clark wrote: From: Rob Clark lockdep dislikes seeing locks unwound in a non-nested fashion. Fixes: 37c2016e3608 ("drm/msm: Fix race condition in msm driver with async layer updates") Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar ---

Re: [Freedreno] [PATCH 1/4] drm: allow drm_atomic_print_state() to accept any drm_printer

Hi Daniel On 2020-10-22 03:38, Daniel Vetter wrote: On Wed, Oct 21, 2020 at 10:01:45PM -0700, Abhinav Kumar wrote: Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm

Re: [Freedreno] [PATCH 1/4] drm/msm/dp: Simplify the mvid/nvid calculation

Hi Bjorn On 2021-06-08 13:13, Bjorn Andersson wrote: On Fri 28 May 18:11 CDT 2021, abhin...@codeaurora.org wrote: Hi Bjorn On 2021-05-10 21:20, Bjorn Andersson wrote: > In the search for causes to timing issues seen during implementation of > eDP support for SC8180x a fair amount of time was

Re: [Freedreno] [PATCH v3] drm/msm/dsi: add continuous clock support for 7nm PHY

On 2021-06-07 16:00, Dmitry Baryshkov wrote: Unlike previous generations, 7nm PHYs are required to collaborate with the host for conitnuos clock mode. Add changes neccessary to enable "the host for continuous clock mode" continuous clock mode in the 7nm DSI PHYs. Signed-off-by: Dmitry

Re: [Freedreno] [PATCH 0/8] dsi: rework clock parents and timing handling

Hi Dmitry I will take a look at this next week for sure. Thanks Abhinav On 2021-06-10 06:48, Dmitry Baryshkov wrote: On 15/05/2021 16:12, Dmitry Baryshkov wrote: This patch series brings back several patches targeting assigning dispcc clock parents, that were removed from the massive dsi

Re: [Freedreno] [PATCH 0/8] dsi: rework clock parents and timing handling

On 2021-05-15 06:12, Dmitry Baryshkov wrote: This patch series brings back several patches targeting assigning dispcc clock parents, that were removed from the massive dsi rework patchset earlier. Few notes: - assign-clock-parents is a mandatory proprety according to the current dsi.txt

Re: [Freedreno] [PATCH 6/8] drm/msm/dsi: phy: use of_device_get_match_data

On 2021-05-15 06:12, Dmitry Baryshkov wrote: Use of_device_get_match-data() instead of of_match_node(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

Re: [Freedreno] [PATCH 7/8] drm/msm/dsi: drop msm_dsi_phy_get_shared_timings

On 2021-05-15 06:12, Dmitry Baryshkov wrote: Instead of fetching shared timing through an extra function call, get them directly from msm_dsi_phy_enable. This would allow removing phy timings from the struct msm_dsi_phy in the next patch. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav

Re: [Freedreno] [PATCH 5/8] drm/msm/dsi: stop setting clock parents manually

On 2021-05-15 06:12, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to move registration of hw clock providers to generic place.

Re: [Freedreno] [PATCH 1/8] arm64: dts: qcom: sc7180: assign DSI clock source parents

On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sdm845: assign DSI clock source parents

On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi

Re: [Freedreno] [PATCH 4/8] arm64: dts: qcom: sm8250: assign DSI clock source parents

On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Can you please confirm if you have validated dual DSI with this change? With that, Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 ++

Re: [Freedreno] [PATCH 3/8] arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents

On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Freedreno] [PATCH 8/8] drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy

On 2021-05-15 06:12, Dmitry Baryshkov wrote: Remove struct msm_dsi_dphy_timing field from the struct msm_dsi_phy. There is no need to store them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 18 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h

Re: [Freedreno] [PATCH] drm/msm/dp: Add missing drm_device backpointer

On 2021-06-24 20:47, Bjorn Andersson wrote: '6cba3fe43341 ("drm/dp: Add backpointer to drm_device in drm_dp_aux")' introduced a mandator drm_device backpointer in struct drm_dp_aux, but mandatory missed the msm DP driver. Fix this. Fixes: 6cba3fe43341 ("drm/dp: Add backpointer to drm_device

Re: [Freedreno] [PATCH 0/4] drm/msm/dp: Add support for SC8180x eDP controller

Hi Bjorn I had a quick glance on the series and before getting to other things wanted to know how you are initializing two different connectors for DP & EDP resp. The connector type for DP should be DRM_MODE_CONNECTOR_DisplayPort and eDP should be DRM_MODE_CONNECTOR_eDP. We need both to be

Re: [Freedreno] [PATCH v2 2/6] drm/msm/dpu: hw_intr: always call dpu_hw_intr_clear_intr_status_nolock

On 2021-05-16 13:29, Dmitry Baryshkov wrote: Always call dpu_hw_intr_clear_intr_status_nolock() from the dpu_hw_intr_dispatch_irqs(). This simplifies the callback function (which call clears the interrupts anyway) and enforces clearing the hw interrupt status. In the subject line you can

Re: [Freedreno] [PATCH v2 4/6] drm/msm/dpu: replace IRQ lookup with the data in hw catalog

On 2021-05-16 13:29, Dmitry Baryshkov wrote: The IRQ table in the dpu_hw_interrupts.h is big, ugly, and hard to maintain. There are only few interrupts used from that table. Newer generations use different IRQ locations. Move this data to hw catalog. I think you can drop the line that "only few

Re: [Freedreno] [PATCH v2 6/6] drm/msm/dpu: simplify IRQ enabling/disabling

On 2021-05-16 13:29, Dmitry Baryshkov wrote: Merge dpu_core_irq_enable() into dpu_core_irq_register_callback() and dpu_core_irq_disable() into dpu_core_irq_unregister_callback(), because they are called in pairs. There is no need to have separate enable/disable pair, we can enable hardware IRQ

Re: [Freedreno] [PATCH v2 1/6] drm/msm/dpu: merge dpu_hw_intr_get_interrupt_statuses into dpu_hw_intr_dispatch_irqs

On 2021-05-16 13:29, Dmitry Baryshkov wrote: There is little sense in reading interrupt statuses and right after that going after the array of statuses to dispatch them. Merge both loops into single function doing read and dispatch. Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson

Re: [Freedreno] [PATCH v2 3/6] drm/msm/dpu: define interrupt register names

On 2021-05-16 13:29, Dmitry Baryshkov wrote: In order to make mdss_irqs readable (and error-prone) define names for I think you meant "less error-prone" here. interrupt register indices. Signed-off-by: Dmitry Baryshkov With that nit fixed, Reviewed-by: Abhinav Kumar ---

Re: [Freedreno] [PATCH 1/4] drm/msm/dp: Simplify the mvid/nvid calculation

Hi Bjorn On 2021-05-10 21:20, Bjorn Andersson wrote: In the search for causes to timing issues seen during implementation of eDP support for SC8180x a fair amount of time was spent concluding why the calculated mvid/nvid values where wrong. The overall conclusion is that the ratio of MVID/NVID

Re: [Freedreno] [PATCH 4/4] drm/msm/dp: Add support for SC8180x eDP

On 2021-05-10 21:20, Bjorn Andersson wrote: The eDP controller found in SC8180x is at large compatible with the current implementation, but has its register blocks at slightly different offsets. Add the compatible and the new register layout. I am not able to completely recall the history of

Re: [Freedreno] [RFC PATCH 11/13] drm/msm/disp/dpu1: Add support for DSC in topology

On 2021-05-28 03:39, Dmitry Baryshkov wrote: On 21/05/2021 15:49, Vinod Koul wrote: For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions upto 4k. For more resolutions like 8k this won't work. Furthermore, we can use 1 DSC encoder in lesser resulutions,

Re: [Freedreno] [PATCH 0/4] drm/msm/dp: Add support for SC8180x eDP controller

Hi Bjorn On 2021-05-19 07:51, Bjorn Andersson wrote: On Tue 18 May 22:41 CDT 2021, abhin...@codeaurora.org wrote: Hi Bjorn I had a quick glance on the series and before getting to other things wanted to know how you are initializing two different connectors for DP & EDP resp. The

Re: [Freedreno] [PATCH 2/4] drm/msm/dp: Store each subblock in the io region

On 2021-05-10 21:20, Bjorn Andersson wrote: Not all platforms has DP_P0 at offset 0x1000 from the beginning of the DP block. So move the offsets into dss_io_data, to make it possible in the next patch to specify alternative offsets and sizes of these segments. Signed-off-by: Bjorn Andersson

Re: [Freedreno] [PATCH 3/4] drm/msm/dp: Initialize the INTF_CONFIG register

On 2021-05-10 21:20, Bjorn Andersson wrote: Some bootloaders set the widebus enable bit in the INTF_CONFIG register, but configuration of widebus isn't yet supported ensure that the register has a known value, with widebus disabled. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver

Re: [Freedreno] [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues

On 2021-06-02 07:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:373: warning: expecting prototype for _dpu_plane_set_panic_lut(). Prototype was for _dpu_plane_set_danger_lut() instead

Re: [Freedreno] [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses

On 2021-06-02 07:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: expecting prototype for Register offsets in MDSS register file for the interrupt registers(). Prototype was for MDP_SSPP_TOP0_OFF() instead

Re: [Freedreno] [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'

On 2021-06-02 07:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Function parameter or member 'dp_catalog' not described in 'dp_catalog_aux_reset' drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Excess function

Re: [Freedreno] [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot

On 2021-06-02 07:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_link.c:374: warning: expecting prototype for dp_parse_video_pattern_params(). Prototype was for dp_link_parse_video_pattern_params() instead drivers/gpu/drm/msm/dp/dp_link.c:573:

Re: [Freedreno] [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc'

On 2021-06-02 07:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function ‘dpu_encoder_phys_cmd_wait_for_commit_done’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: variable ‘cmd_enc’ set

Re: [Freedreno] [PATCH] drm/msm: fix display snapshotting if DP or DSI is disabled

On 2021-05-27 15:03, Dmitry Baryshkov wrote: Fix following warnings generated when either DP or DSI support is disabled: drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c:141:3: error: implicit declaration of function 'msm_dp_snapshot'; did you mean 'msm_dsi_snapshot'?

  1   2   3   >