URL: https://github.com/freeipa/freeipa/pull/1914
Author: felipevolpone
 Title: #1914: Fixing DNSSEC tests with restarting named
Action: opened

PR body:
"""
This commit fixes:
- TestInstallDNSSECLast::test_disable_reenable_signing_master
- TestInstallDNSSECLast::test_disable_reenable_signing_replica
- TestInstallDNSSECFirst::test_chain_of_trust

https://pagure.io/freeipa/issue/5670
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1914/head:pr1914
git checkout pr1914
From f61929cf00bd63f63487dff882b0c981203fad71 Mon Sep 17 00:00:00 2001
From: Felipe Barreto <fbarr...@redhat.com>
Date: Wed, 9 May 2018 11:44:19 -0300
Subject: [PATCH 1/2] Fixing DNSSEC tests with restarting named

This commit fixes:
- TestInstallDNSSECLast::test_disable_reenable_signing_master
- TestInstallDNSSECLast::test_disable_reenable_signing_replica
- TestInstallDNSSECFirst::test_chain_of_trust

https://pagure.io/freeipa/issue/5670
---
 ipatests/test_integration/test_dnssec.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/ipatests/test_integration/test_dnssec.py b/ipatests/test_integration/test_dnssec.py
index 40b4e1b356..111256adde 100644
--- a/ipatests/test_integration/test_dnssec.py
+++ b/ipatests/test_integration/test_dnssec.py
@@ -187,6 +187,8 @@ def test_disable_reenable_signing_master(self):
             self.replicas[0].ip, test_zone, timeout=200
         ), "DNS zone %s is not signed (replica)" % test_zone
 
+        tasks.restart_named(self.master)
+
         dnskey_new = resolve_with_dnssec(self.master.ip, test_zone,
                                          rtype="DNSKEY").rrset
         assert dnskey_old != dnskey_new, "DNSKEY should be different"
@@ -234,6 +236,8 @@ def test_disable_reenable_signing_replica(self):
             self.replicas[0].ip, test_zone_repl, timeout=200
         ), "DNS zone %s is not signed (replica)" % test_zone_repl
 
+        tasks.restart_named(self.master)
+
         dnskey_new = resolve_with_dnssec(self.replicas[0].ip, test_zone_repl,
                                          rtype="DNSKEY").rrset
         assert dnskey_old != dnskey_new, "DNSKEY should be different"
@@ -327,6 +331,8 @@ def test_chain_of_trust(self):
             "--ns-rec=" + self.master.hostname
         ]
         self.master.run_command(args)
+        tasks.restart_named(self.master)
+
         # wait until zone is signed
         assert wait_until_record_is_signed(
             self.master.ip, example_test_zone, timeout=100

From f14d941a8202cd1b67b7e68d3f5eb3fc067d2736 Mon Sep 17 00:00:00 2001
From: Felipe Barreto <fbarr...@redhat.com>
Date: Wed, 9 May 2018 11:49:19 -0300
Subject: [PATCH 2/2] temp commit: adding test_dnssec to run

---
 .freeipa-pr-ci.yaml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml
index a16b388695..3a945f236f 100644
--- a/.freeipa-pr-ci.yaml
+++ b/.freeipa-pr-ci.yaml
@@ -11,6 +11,10 @@ topologies:
     name: master_1repl_1client
     cpu: 4
     memory: 6700
+  master_2repl_1client: &master_2repl_1client
+    name: master_2repl_1client
+    cpu: 5
+    memory: 9100
 
 jobs:
   fedora-27/build:
@@ -207,3 +211,14 @@ jobs:
         timeout: 3600
         topology: *master_1repl_1client
 
+  fedora-27/test_dnssec:
+    requires: [fedora-27/build]
+    priority: 50
+    job:
+      class: RunPytest
+      args:
+        build_url: '{fedora-27/build_url}'
+        test_suite: test_integration/test_dnssec.py
+        template: *ci-master-f27
+        timeout: 8000
+        topology: *master_2repl_1client
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to