URL: https://github.com/freeipa/freeipa/pull/2282 Author: flo-renaud Title: #2282: [Backport][ipa-4-7] DS replication settings: fix regression with <3.3 master Action: opened
PR body: """ This PR was opened automatically because PR #2263 was pushed to master and backport to ipa-4-7 is required. """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/2282/head:pr2282 git checkout pr2282
From bb60786f62fac509e44acdff40a2ab727fc07901 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Tue, 21 Aug 2018 11:37:17 +0200 Subject: [PATCH] DS replication settings: fix regression with <3.3 master Commit 811b0fdb4620938963f1a29d3fdd22257327562c introduced a regression when configuring replication with a master < 3.3 Even if 389-ds schema is extended with nsds5ReplicaReleaseTimeout, nsds5ReplicaBackoffMax and nsDS5ReplicaBindDnGroupCheckInterval attributes, it will return UNWILLING_TO_PERFORM when a mod operation is performed on the cn=replica entry. This patch ignores the error and logs a debug msg. See: https://pagure.io/freeipa/issue/7617 --- ipaserver/install/replication.py | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py index 78c4a43cc9..92a99cd948 100644 --- a/ipaserver/install/replication.py +++ b/ipaserver/install/replication.py @@ -22,6 +22,7 @@ import logging import itertools +import re import six import time import datetime @@ -600,7 +601,20 @@ def finalize_replica_config(self, r_hostname, r_binddn=None, r_conn.simple_bind(r_binddn, r_bindpw) else: r_conn.gssapi_bind() - self._finalize_replica_settings(r_conn) + # If the remote server has 389-ds < 1.3, it does not + # support the attributes we are trying to set. + # Find which 389-ds is installed + rootdse = r_conn.get_entry(DN(''), ['vendorVersion']) + version = rootdse.single_value.get('vendorVersion') + mo = re.search(r'(\d+)\.(\d+)\.(\d+)[\.\d]*', version) + vendor_version = tuple(int(v) for v in mo.groups()) + if vendor_version >= (1, 3, 0): + # 389-ds understands the replication attributes, + # we can safely modify them + self._finalize_replica_settings(r_conn) + else: + logger.debug("replication attributes not supported " + "on remote master, skipping update.") r_conn.close() def setup_chaining_backend(self, conn):
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/SFNHJHJ7TRIXKJXIASBHXIYNILZ7GIHO/
