URL: https://github.com/freeipa/freeipa/pull/1412
Author: tiran
 Title: #1412: Use pylint 1.7.5 with fix for bad python3 import
Action: opened

PR body:
"""
Closes: https://pagure.io/freeipa/issue/7315
Signed-off-by: Christian Heimes <chei...@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1412/head:pr1412
git checkout pr1412
From b33dfc98fbce68c6d2d73c4561dc37cbe4fb8ba0 Mon Sep 17 00:00:00 2001
From: Christian Heimes <chei...@redhat.com>
Date: Tue, 19 Dec 2017 09:48:29 +0100
Subject: [PATCH] Use pylint 1.7.5 with fix for bad python3 import

Closes: https://pagure.io/freeipa/issue/7315
Signed-off-by: Christian Heimes <chei...@redhat.com>
---
 .wheelconstraints.in              | 4 ++--
 ipapython/certdb.py               | 2 +-
 ipaserver/install/installutils.py | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.wheelconstraints.in b/.wheelconstraints.in
index d462303833..fda153176f 100644
--- a/.wheelconstraints.in
+++ b/.wheelconstraints.in
@@ -9,5 +9,5 @@ ipapython == @VERSION@
 ipaserver == @VERSION@
 ipatests == @VERSION@
 
-# we include some checks available only in pylint-1.7 and on
-pylint >= 1.7
+# upstream pylint 1.7.5 fixed bad python3 import of stat module
+pylint >= 1.7.5
diff --git a/ipapython/certdb.py b/ipapython/certdb.py
index 6d4415b53b..4b93e77d26 100644
--- a/ipapython/certdb.py
+++ b/ipapython/certdb.py
@@ -25,7 +25,7 @@
 import pwd
 import grp
 import re
-import stat  # pylint: disable=bad-python3-import
+import stat
 import tempfile
 from tempfile import NamedTemporaryFile
 import shutil
diff --git a/ipaserver/install/installutils.py b/ipaserver/install/installutils.py
index 83ae8033f1..db7181ce07 100644
--- a/ipaserver/install/installutils.py
+++ b/ipaserver/install/installutils.py
@@ -33,7 +33,7 @@
 import sys
 import tempfile
 import shutil
-import stat  # pylint: disable=bad-python3-import
+import stat
 import traceback
 import textwrap
 from contextlib import contextmanager
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to