[Freeipa-devel] [freeipa PR#818][comment] Avoid possible endless recursion in RPC call from client

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client MartinBasti commented: """ master: * 81a808caeb5676427610e113b5a259511c2835d6 Avoid possible endless recursion in RPC call * 79d1752577e8fcb568b701509fe5b52f949d5e4b rpc: prep

[Freeipa-devel] [freeipa PR#818][comment] Avoid possible endless recursion in RPC call from client

2017-06-01 Thread flo-renaud via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client flo-renaud commented: """ Hi @stlaz Thank you, the patch looks good to me. """ See the full comment at https://github.com/freeipa/freeipa/pull/818#issuecomment-305470664

[Freeipa-devel] [freeipa PR#818][comment] Avoid possible endless recursion in RPC call from client

2017-06-01 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client stlaz commented: """ The tests passed, I am just adding a minor comment typo fixup. """ See the full comment at https://github.com/freeipa/freeipa/pull/818#issuecomment-305423

[Freeipa-devel] [freeipa PR#818][comment] Avoid possible endless recursion in RPC call from client

2017-06-01 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client stlaz commented: """ Thanks for the good catch, @flo-renaud. While the recursion in the `forward()` method was quite easy to fix, it was not so in the `create_connection()`. I

[Freeipa-devel] [freeipa PR#818][comment] Avoid possible endless recursion in RPC call from client

2017-05-30 Thread flo-renaud via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client flo-renaud commented: """ Hi @stlaz, thank you for the patch. The fix will avoid recursion in forward(), but I think that the same type of recursion could happen in create_conn