Re: [Freeipa-devel] Re: [PATCH] Add --all to LDAPCreate and make LDAP commands always display default attributes.

2009-11-17 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: And here's the actual patch. :) Pavel Zuna wrote: This should fix the issue: Rob Crittenden wrote: Michael Gregg wrote: Rob, did the support for posix groups change? If I create a group specifying "--posix" the cli does create the

Re: [Freeipa-devel] [PATCH] Fix a bunch of unit tests.

2009-11-17 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: Only pwpolicy test is still broken - I'm looking into it. Pavel This brings up the return values question again. I thought we had decided that any attribute that had only one value would be returned as a scalar. In this case userCer

[Freeipa-devel] [PATCH] 285 CRL publishing

2009-11-17 Thread Rob Crittenden
This enables CRL publishing by dogtag to a place where Apache can get the files. I have to do a couple of tricks here because dogtag is an optional component. This is why in the installer I first see if the dogtag SELinux policy is installed and if not add it. Similarly the installer will rem

Re: [Freeipa-devel] [PATCH] 309 make exception from ipautil.run() optional

2009-11-17 Thread Rob Crittenden
Jason Gerard DeRose wrote: On Wed, 2009-11-11 at 11:41 -0500, Rob Crittenden wrote: Rob Crittenden wrote: There are probably occasions where a caller will want more control over what happens when running a command fails. I've added an optional argument to run where it will not raise an excepti

Re: [Freeipa-devel] [PATCH] 309 make exception from ipautil.run() optional

2009-11-17 Thread Jason Gerard DeRose
On Wed, 2009-11-11 at 11:41 -0500, Rob Crittenden wrote: > Rob Crittenden wrote: > > There are probably occasions where a caller will want more control over > > what happens when running a command fails. I've added an optional > > argument to run where it will not raise an exception on errors. >

Re: [Freeipa-devel] [PATCH] 308 manage arbitrary attributes

2009-11-17 Thread Jason Gerard DeRose
On Tue, 2009-11-10 at 12:28 -0500, Rob Crittenden wrote: > Jason Gerard DeRose wrote: > > Oops, was this missing the attachment? ;) > > Bah, here it is. > > rob ack. pushed to master. > > > > On Wed, 2009-11-04 at 16:04 -0500, Rob Crittenden wrote: > >> This adds 2 new parameters, --setattr

Re: [Freeipa-devel] [PATCH] 307 enforce scalar

2009-11-17 Thread Jason Gerard DeRose
On Wed, 2009-11-04 at 09:46 -0500, Rob Crittenden wrote: > _convert_scalar() should not handle tuples/lists (by definition). A > parameter may be mutivalued but even then _convert_scalar() gets the > values one at a time. > > rob ack. pushed to master.

Re: [Freeipa-devel] Return values, CRUD, webUI

2009-11-17 Thread Rob Crittenden
Jason Gerard DeRose wrote: The vast majority of our Command plugins subclass from one of the CRUD base classes, so in terms of return value consistency and API style, we need to focus most on them (and then adapt their style to the few non-CRUD commands). While hooking up the webUI there have be