Re: [Freeipa-devel] [PATCH] 324 add errors.NotImplementedError

2009-12-01 Thread Jason Gerard DeRose
On Tue, 2009-12-01 at 17:23 -0500, Rob Crittenden wrote: > This deprecates a similar patch from John last month. The server-side > baseclass rabase defines a framework for CA plugins. When I added this > code I set it up to return errors.NotImplementedError but didn't > actually include that err

Re: [Freeipa-devel] [PATCH] 323 type argument for x509.load_certificate()

2009-12-01 Thread Jason Gerard DeRose
On Tue, 2009-12-01 at 17:20 -0500, Rob Crittenden wrote: > Add a type argument (PEM or DER) for x509.load_certificate(). Certs are > coming out of LDAP as binary so we need to be able to handle that too. > Seems more sane to add an argument that to base64-encode it. > > rob ack. pushed to mast

Re: [Freeipa-devel] [PATCH] 322 set minimum level of python-pyasn1

2009-12-01 Thread Jason Gerard DeRose
On Tue, 2009-12-01 at 14:04 -0500, Rob Crittenden wrote: > Update the spec to set minimum version of python-pyasn1 to 0.0.9a so we > can have the ASN.1 Any type needed by the PKCS#10 parser. > > rob nack. This introduces a bug in the spec: error: line 89: Unknown tag: pequires: libcap __

[Freeipa-devel] [PATCH] 325 test for cert plugin

2009-12-01 Thread Rob Crittenden
An extremely basic test for the cert plugin. Only tests the cert-request command but it's a start. rob freeipa-325-certtest.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/lis

[Freeipa-devel] [PATCH] 324 add errors.NotImplementedError

2009-12-01 Thread Rob Crittenden
This deprecates a similar patch from John last month. The server-side baseclass rabase defines a framework for CA plugins. When I added this code I set it up to return errors.NotImplementedError but didn't actually include that error class in the commit. I'm adding that in now, favoring it ove

[Freeipa-devel] [PATCH] 323 type argument for x509.load_certificate()

2009-12-01 Thread Rob Crittenden
Add a type argument (PEM or DER) for x509.load_certificate(). Certs are coming out of LDAP as binary so we need to be able to handle that too. Seems more sane to add an argument that to base64-encode it. rob freeipa-323-cert.patch Description: application/mbox

Re: [Freeipa-devel] [PATCH] Ask the user before overwriting /etc/named.conf

2009-12-01 Thread Rob Crittenden
Martin Nagy wrote: On Tue, 2009-12-01 at 10:15 -0500, Rob Crittenden wrote: Martin Nagy wrote: Martin ack. As an aside, it might be nice if the actual package name(s) were used to make it easier for the user to know exactly what they are missing for BIND and the BIND LDAP plug-in. Yeah,

Re: [Freeipa-devel] [PATCH] Add idnsUpdatePolicy into the dns plug-in

2009-12-01 Thread Rob Crittenden
Martin Nagy wrote: On Tue, 2009-12-01 at 10:17 -0500, Rob Crittenden wrote: Martin Nagy wrote: Martin Should there be a validator on idnsUpdatePolicy to ensure that each policy is terminated by a ;? If one wants to have multiple policies is it set with idnspolicy="policy1;policy2;policy3;"?

[Freeipa-devel] [PATCH] 322 set minimum level of python-pyasn1

2009-12-01 Thread Rob Crittenden
Update the spec to set minimum version of python-pyasn1 to 0.0.9a so we can have the ASN.1 Any type needed by the PKCS#10 parser. rob freeipa-322-pyasn1.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 321 better LDAP error handling in client

2009-12-01 Thread Jason Gerard DeRose
On Mon, 2009-11-30 at 15:50 -0500, Rob Crittenden wrote: > This improves the LDAP exception handling in the client. The existing > code spit out a slew of deprecation errors because of the use of the > message attribute. > > rob ack. pushed to master. _

Re: [Freeipa-devel] [PATCH] 320 remove /etc/ipa/ipa.conf

2009-12-01 Thread Jason Gerard DeRose
On Tue, 2009-12-01 at 10:36 -0500, Rob Crittenden wrote: > Jason Gerard DeRose wrote: > > On Wed, 2009-11-25 at 17:43 -0500, Rob Crittenden wrote: > >> The configuration file /etc/ipa/ipa.conf was used by the v1 clients and > >> servers to manually set realm, domain and server(s). This has been >

Re: [Freeipa-devel] [PATCH] Ask the user before overwriting /etc/named.conf

2009-12-01 Thread Martin Nagy
On Tue, 2009-12-01 at 10:15 -0500, Rob Crittenden wrote: > Martin Nagy wrote: > > Martin > > > > ack. > > As an aside, it might be nice if the actual package name(s) were used to > make it easier for the user to know exactly what they are missing for > BIND and the BIND LDAP plug-in. Yeah, I

Re: [Freeipa-devel] [PATCH] Change object_class of group object.

2009-12-01 Thread Rob Crittenden
Pavel Zůna wrote: Rob Crittenden wrote: Pavel Zuna wrote: Some groups created by default don't have ipaUserGroup and won't show up in searches. Pavel nack, isn't the better approach to fix up the groups that are created by default without the ipaUserGroup objectclass? It is. Fixed patch

Re: [Freeipa-devel] [PATCH] Add {user, host, sourcehost}Category to HBAC and make accessTime multivalue.

2009-12-01 Thread Rob Crittenden
Pavel Zůna wrote: Rob Crittenden wrote: Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: Due to the format of accessTime (it has commas and spaces in it), we can't use the List parameter type. I made it so that accessTime values have to be entered one by one using new commands. We

Re: [Freeipa-devel] [PATCH] Add idnsUpdatePolicy into the dns plug-in

2009-12-01 Thread Martin Nagy
On Tue, 2009-12-01 at 10:17 -0500, Rob Crittenden wrote: > Martin Nagy wrote: > > Martin > > > > Should there be a validator on idnsUpdatePolicy to ensure that each > policy is terminated by a ;? If one wants to have multiple policies is > it set with idnspolicy="policy1;policy2;policy3;"? > >

Re: [Freeipa-devel] [PATCH] 320 remove /etc/ipa/ipa.conf

2009-12-01 Thread Rob Crittenden
Jason Gerard DeRose wrote: On Wed, 2009-11-25 at 17:43 -0500, Rob Crittenden wrote: The configuration file /etc/ipa/ipa.conf was used by the v1 clients and servers to manually set realm, domain and server(s). This has been renamed to /etc/ipa/default.conf in v2. Some old utilities still refer

Re: [Freeipa-devel] [PATCH] Add idnsUpdatePolicy into the dns plug-in

2009-12-01 Thread Rob Crittenden
Martin Nagy wrote: Martin Should there be a validator on idnsUpdatePolicy to ensure that each policy is terminated by a ;? If one wants to have multiple policies is it set with idnspolicy="policy1;policy2;policy3;"? Should the formatting be included in the doc message, or an example of us

Re: [Freeipa-devel] [PATCH] Ask the user before overwriting /etc/named.conf

2009-12-01 Thread Rob Crittenden
Martin Nagy wrote: Martin ack. As an aside, it might be nice if the actual package name(s) were used to make it easier for the user to know exactly what they are missing for BIND and the BIND LDAP plug-in. rob ___ Freeipa-devel mailing list Fre

Re: [Freeipa-devel] [PATCH] Remove unnecessary "error: " prefixes

2009-12-01 Thread Rob Crittenden
Martin Nagy wrote: Martin ack ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Add idnsUpdatePolicy into the dns plug-in

2009-12-01 Thread Martin Nagy
Martin >From 2831a904c8ab270e1f326ae300dc373361dcc8a4 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Tue, 10 Nov 2009 13:12:21 +0100 Subject: [PATCH] Add idnsUpdatePolicy into the dns plug-in The idnsUpdatePolicy takes a list of BIND dynamic update policies, each of which must be terminated by

[Freeipa-devel] [PATCH] Ask the user before overwriting /etc/named.conf

2009-12-01 Thread Martin Nagy
Martin >From 2ecd67588206abadeb992360c3cd6f0c31938edc Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Fri, 13 Nov 2009 16:57:51 +0100 Subject: [PATCH] Ask the user before overwriting /etc/named.conf --- install/tools/ipa-replica-install |6 ++ install/tools/ipa-server-install |6 ++

[Freeipa-devel] [PATCH] Remove unnecessary "error: " prefixes

2009-12-01 Thread Martin Nagy
Martin >From 96c64ff2a1051c1e8bdcad9e8aef9488f0e26e87 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Mon, 23 Nov 2009 08:42:30 +0100 Subject: [PATCH] Remove unnecessary "error: " prefixes The parser.error() method prepends the "error: " prefix itself. Adding it to the error string is not necess

Re: [Freeipa-devel] [PATCH] jderose 027 Extensible return values

2009-12-01 Thread Pavel Zůna
Rob Crittenden wrote: Jason Gerard DeRose wrote: On Wed, 2009-11-25 at 12:05 -0500, Rob Crittenden wrote: This is purely from reading the patch, I haven't applied and tested it yet. ipalib/output.py: +primary_key = Output('primary_key', unicode, +'The primary key of the deleted entry' +)

Re: [Freeipa-devel] [PATCH] Change object_class of group object.

2009-12-01 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zuna wrote: Some groups created by default don't have ipaUserGroup and won't show up in searches. Pavel nack, isn't the better approach to fix up the groups that are created by default without the ipaUserGroup objectclass? It is. Fixed patch attached. rob P

Re: [Freeipa-devel] [PATCH] Add {user, host, sourcehost}Category to HBAC and make accessTime multivalue.

2009-12-01 Thread Pavel Zůna
Rob Crittenden wrote: Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: Due to the format of accessTime (it has commas and spaces in it), we can't use the List parameter type. I made it so that accessTime values have to be entered one by one using new commands. We also agreed, that