Re: [Freeipa-devel] [PATCH] 042 Password policy commands do not include cospriority

2011-04-11 Thread Martin Kosek
On Fri, 2011-04-08 at 10:29 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2011-04-01 at 13:51 -0400, Rob Crittenden wrote: Martin Kosek wrote: Target branches: master, ipa-2-0 --- Most of the pwpolicy_* commands do include cospriority in the result and potentially in the

Re: [Freeipa-devel] [PATCH] 046 Improve DNS PTR record validation

2011-04-11 Thread Martin Kosek
On Fri, 2011-04-08 at 14:42 -0400, Rob Crittenden wrote: Martin Kosek wrote: Current PTR validation is unclear and may misled the user. This patch improves the validation process so that the eventual exception is clearer. New check that the PTR record is fully qualified has been added to

Re: [Freeipa-devel] [PATCH] 764 update ipa-client-install man page

2011-04-11 Thread Martin Kosek
On Fri, 2011-04-08 at 13:07 -0400, Rob Crittenden wrote: Martin Kosek wrote: I don't think it is a good idea to have this option in ipa-client-install --help at all. Since it is not intended to be used by the user and we just use it in our scripts why would we want to have it in

Re: [Freeipa-devel] [PATCH] 6 Add lint script for static code analysis

2011-04-11 Thread Martin Kosek
On Thu, 2011-04-07 at 17:00 +0200, Jan Cholasta wrote: This patch adds a script based on pylint for static code analysis during build. https://fedorahosted.org/freeipa/ticket/867 Good work, works for me. Enabling static analysis for our IPA framework will improve the code base and could

Re: [Freeipa-devel] [PATCH] Fix lint false positives

2011-04-11 Thread Martin Kosek
On Thu, 2011-04-07 at 17:03 +0200, Jan Cholasta wrote: Added changes to the code necesarry for removal of false positives reported by the lint script (see my previous patch). ACK. Along with the previous patch suppressing false positives shows some real issues in the framework. We should

Re: [Freeipa-devel] [PATCH] Fix lint false positives

2011-04-11 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/11/2011 01:38 PM, Martin Kosek wrote: On Thu, 2011-04-07 at 17:03 +0200, Jan Cholasta wrote: Added changes to the code necesarry for removal of false positives reported by the lint script (see my previous patch). ACK. Along with the

[Freeipa-devel] [PATCH] 9 Fix unitialized variables

2011-04-11 Thread Jan Cholasta
Fixed unitialized variables in makeapi validate_api. -- Jan Cholasta From 9f7357597d1121b9128cfd467c4a8e48c06f9ef8 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 11 Apr 2011 14:41:10 +0200 Subject: [PATCH] Fix uninitialized variables. --- makeapi |7 +++ 1

[Freeipa-devel] [PATCH] 10 Fix double definition

2011-04-11 Thread Jan Cholasta
Fixed double definition of Command.output_for_cli. -- Jan Cholasta From 609a8de7a0b6139c6971645360831df505180910 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 11 Apr 2011 14:45:56 +0200 Subject: [PATCH] Fix double definition of output_for_cli. ---

[Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-11 Thread Jan Cholasta
Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, ipalib.text.LazyText, ipaserver.install.service.Service and ipaserver.rpcserver.WSGIExecutioner. -- Jan Cholasta From 4e6a5de5a1fbf308873f491b0a8e3c270f264ff6 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com

Re: [Freeipa-devel] [PATCH] 6 Add lint script for static code analysis

2011-04-11 Thread Jan Cholasta
On 7.4.2011 17:00, Jan Cholasta wrote: This patch adds a script based on pylint for static code analysis during build. https://fedorahosted.org/freeipa/ticket/867 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 131 Refactored action panel and client area.

2011-04-11 Thread Adam Young
On 04/08/2011 03:12 PM, Endi Sukma Dewata wrote: To improve code readability and extensibility the containers for action panel and client area are now created in IPA.entity.setup(). The 'client area' has been renamed into 'content'. The IPA.facet.create() has been renamed to

Re: [Freeipa-devel] [PATCH] 132 Refactored builder interface.

2011-04-11 Thread Adam Young
On 04/08/2011 03:13 PM, Endi Sukma Dewata wrote: The IPA.entity_builder has been modified to take a 'factory' parameter in custom facet's and custom dialog's spec. The IPA.dialog has been modified to take an array of fields in the spec. The IPA.search_facet has been modified to take an array of

Re: [Freeipa-devel] [PATCH] 133 Refactored search facet.

2011-04-11 Thread Adam Young
On 04/08/2011 03:14 PM, Endi Sukma Dewata wrote: To simplify customization, the add(), remove(), and refresh() methods have been moved from IPA.search_widget into IPA.search_facet. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 134 Entitlements.

2011-04-11 Thread Endi Sukma Dewata
On 4/9/2011 9:05 PM, Adam Young wrote: On 04/08/2011 03:14 PM, Endi Sukma Dewata wrote: Initial implementation of Entitlements. Needs to be added to makefile.am and jsl.conf Fixed in the new patch. -- Endi S. Dewata From b8186363753d5764937f88e2e92ce6b0becd1752 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 131 Refactored action panel and client area.

2011-04-11 Thread Endi Sukma Dewata
On 4/11/2011 10:03 AM, Adam Young wrote: On 04/08/2011 03:12 PM, Endi Sukma Dewata wrote: To improve code readability and extensibility the containers for action panel and client area are now created in IPA.entity.setup(). The 'client area' has been renamed into 'content'. The

Re: [Freeipa-devel] [PATCH] 132 Refactored builder interface.

2011-04-11 Thread Endi Sukma Dewata
On 4/11/2011 10:05 AM, Adam Young wrote: On 04/08/2011 03:13 PM, Endi Sukma Dewata wrote: The IPA.entity_builder has been modified to take a 'factory' parameter in custom facet's and custom dialog's spec. The IPA.dialog has been modified to take an array of fields in the spec. The

Re: [Freeipa-devel] [PATCH] 133 Refactored search facet.

2011-04-11 Thread Endi Sukma Dewata
On 4/11/2011 10:23 AM, Adam Young wrote: On 04/08/2011 03:14 PM, Endi Sukma Dewata wrote: To simplify customization, the add(), remove(), and refresh() methods have been moved from IPA.search_widget into IPA.search_facet. ACK. Follow on work required to make add and delte avaialbel from

Re: [Freeipa-devel] [PATCH] 134 Entitlements.

2011-04-11 Thread Endi Sukma Dewata
On 4/11/2011 10:23 AM, Endi Sukma Dewata wrote: On 4/9/2011 9:05 PM, Adam Young wrote: On 04/08/2011 03:14 PM, Endi Sukma Dewata wrote: Initial implementation of Entitlements. Needs to be added to makefile.am and jsl.conf Fixed in the new patch. ACKed on IRC and pushed to master. --

Re: [Freeipa-devel] [PATCH] 135 Updated Selenium tests.

2011-04-11 Thread Endi Sukma Dewata
On 4/8/2011 2:15 PM, Endi Sukma Dewata wrote: The Selenium tests have been updated to improve robustness. ACKed on IRC and pushed to master. This still requires further improvements. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 767 fix ipa-nis-manage

2011-04-11 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 08 Apr 2011 13:12:22 -0400 Rob Crittendenrcrit...@redhat.com wrote: JR Aquino wrote: Does the limitation of autobind with root mean that all of the tools that use ldapi need to be revisited and turned back to 389? ipa-host-net-manage and ipa-compat-manage work

Re: [Freeipa-devel] [Freeipa-users] Auto membership plugin

2011-04-11 Thread Nathan Kinder
On 04/11/2011 10:25 AM, Dmitri Pal wrote: On 04/11/2011 11:27 AM, Nathan Kinder wrote: On 04/08/2011 09:07 AM, Dmitri Pal wrote: On 04/08/2011 11:49 AM, JR Aquino wrote: Is there any way to capture a description associated with the regex - group mapping? I was thinking that after time, it

Re: [Freeipa-devel] [PATCH] 764 update ipa-client-install man page

2011-04-11 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2011-04-08 at 13:07 -0400, Rob Crittenden wrote: Martin Kosek wrote: I don't think it is a good idea to have this option in ipa-client-install --help at all. Since it is not intended to be used by the user and we just use it in our scripts why would we want to have

Re: [Freeipa-devel] [PATCH] 767 fix ipa-nis-manage

2011-04-11 Thread Simo Sorce
On Mon, 11 Apr 2011 13:51:31 -0400 Rob Crittenden rcrit...@redhat.com wrote: Add a new option to ipa-ldap-updater to prompt for the DM password. Remove restriction to be run as root except when doing an upgrade. Ack if you rename the new option variable from dm_password to something like

Re: [Freeipa-devel] [Freeipa-users] Auto membership plugin

2011-04-11 Thread Nathan Kinder
On 04/11/2011 10:58 AM, Nathan Kinder wrote: On 04/11/2011 10:25 AM, Dmitri Pal wrote: On 04/11/2011 11:27 AM, Nathan Kinder wrote: On 04/08/2011 09:07 AM, Dmitri Pal wrote: On 04/08/2011 11:49 AM, JR Aquino wrote: Is there any way to capture a description associated with the regex - group

Re: [Freeipa-devel] [Freeipa-users] Auto membership plugin

2011-04-11 Thread Dmitri Pal
On 04/11/2011 02:32 PM, Nathan Kinder wrote: On 04/11/2011 10:58 AM, Nathan Kinder wrote: On 04/11/2011 10:25 AM, Dmitri Pal wrote: On 04/11/2011 11:27 AM, Nathan Kinder wrote: On 04/08/2011 09:07 AM, Dmitri Pal wrote: On 04/08/2011 11:49 AM, JR Aquino wrote: Is there any way to capture a

Re: [Freeipa-devel] [PATCH] 767 fix ipa-nis-manage

2011-04-11 Thread Rob Crittenden
Simo Sorce wrote: On Mon, 11 Apr 2011 13:51:31 -0400 Rob Crittendenrcrit...@redhat.com wrote: Add a new option to ipa-ldap-updater to prompt for the DM password. Remove restriction to be run as root except when doing an upgrade. Ack if you rename the new option variable from dm_password to

[Freeipa-devel] [PATCH] 769 enable SSL hostname checking

2011-04-11 Thread Rob Crittenden
Enable 389-ds SSL host checking by defauilt Enforce that the remote hostname matches the remote SSL server certificate when 389-ds operates as an SSL client. Also add an update file to turn this off for existing installations. ticket 1069 rob freeipa-rcrit-769-ssl.patch Description:

Re: [Freeipa-devel] [Freeipa-users] Auto membership plugin

2011-04-11 Thread Nathan Kinder
On 04/11/2011 11:59 AM, Dmitri Pal wrote: On 04/11/2011 02:32 PM, Nathan Kinder wrote: On 04/11/2011 10:58 AM, Nathan Kinder wrote: On 04/11/2011 10:25 AM, Dmitri Pal wrote: On 04/11/2011 11:27 AM, Nathan Kinder wrote: On 04/08/2011 09:07 AM, Dmitri Pal wrote: On 04/08/2011 11:49 AM, JR

Re: [Freeipa-devel] [Freeipa-users] Auto membership plugin

2011-04-11 Thread Dmitri Pal
On 04/11/2011 05:21 PM, Nathan Kinder wrote: On 04/11/2011 11:59 AM, Dmitri Pal wrote: On 04/11/2011 02:32 PM, Nathan Kinder wrote: On 04/11/2011 10:58 AM, Nathan Kinder wrote: On 04/11/2011 10:25 AM, Dmitri Pal wrote: On 04/11/2011 11:27 AM, Nathan Kinder wrote: On 04/08/2011 09:07 AM,

Re: [Freeipa-devel] [Freeipa-users] Auto membership plugin

2011-04-11 Thread Nathan Kinder
On 04/11/2011 02:53 PM, Dmitri Pal wrote: On 04/11/2011 05:21 PM, Nathan Kinder wrote: On 04/11/2011 11:59 AM, Dmitri Pal wrote: On 04/11/2011 02:32 PM, Nathan Kinder wrote: On 04/11/2011 10:58 AM, Nathan Kinder wrote: On 04/11/2011 10:25 AM, Dmitri Pal wrote: On 04/11/2011 11:27 AM, Nathan