Re: [Freeipa-devel] [PATCH, 2.1] 0021 Fedora 16 and systemd support

2011-10-18 Thread Martin Kosek
On Mon, 2011-10-17 at 14:21 +0300, Alexander Bokovoy wrote: On Fri, 14 Oct 2011, Simo Sorce wrote: Attached a rebased patch with the modifications needed to apply it on master. Everything seem to work on master but I haven't tested ipa-2-1 so this is a partial ACK of the

Re: [Freeipa-devel] [PATCH, 2.1] 0021 Fedora 16 and systemd support

2011-10-18 Thread Alexander Bokovoy
On Tue, 18 Oct 2011, Martin Kosek wrote: I tested our most recent master with simo's rebased patch and your patch 0004-Spin-for-connection-success-also-when-socket-is-not-.patch. It looks very good, I hit just few issues: 1) ipa service reports inactive (dead) status even though LDAP server

Re: [Freeipa-devel] [PATCH, 2.1] 0021 Fedora 16 and systemd support

2011-10-18 Thread Alexander Bokovoy
On Tue, 18 Oct 2011, Alexander Bokovoy wrote: ipa.init was removed from the git, but it was never moved to init/SystemV/. It should have been moved (rm+new file). I'll check what's happening there, maybe Simo's patch omitted that one?

Re: [Freeipa-devel] [PATCH] 023 Circular entity dependency

2011-10-18 Thread Petr Vobornik
Comments in text. Also attached git diff for convenience. On 10/17/2011 10:39 PM, Endi Sukma Dewata wrote: On 10/10/2011 10:13 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1531 (3.0 Core Effort Iteration 01 September Y11 Release) Implemented solution: * all entities

Re: [Freeipa-devel] [PATCH, 2.1] 0021 Fedora 16 and systemd support

2011-10-18 Thread Simo Sorce
On Tue, 2011-10-18 at 14:27 +0300, Alexander Bokovoy wrote: On Tue, 18 Oct 2011, Martin Kosek wrote: ipa.init was removed from the git, but it was never moved to init/SystemV/. It should have been moved (rm+new file). I'll check what's happening there, maybe Simo's patch omitted that one?

Re: [Freeipa-devel] [PATCH, 2.1] 0021 Fedora 16 and systemd support

2011-10-18 Thread Martin Kosek
On Tue, 2011-10-18 at 15:48 +0300, Alexander Bokovoy wrote: On Tue, 18 Oct 2011, Alexander Bokovoy wrote: ipa.init was removed from the git, but it was never moved to init/SystemV/. It should have been moved (rm+new file). I'll check what's happening there, maybe Simo's patch omitted

Re: [Freeipa-devel] [PATCH, 2.1] 0021 Fedora 16 and systemd support

2011-10-18 Thread Alexander Bokovoy
On Tue, 18 Oct 2011, Martin Kosek wrote: 1) When ipa is not configured, it is ok that ipa.service status returns error. However, I still got ipa.service status error after the ipa was configured: # systemctl status ipa.service ipa.service - Identity, Policy, Audit Loaded: loaded

[Freeipa-devel] [PATCH] Fix help system

2011-10-18 Thread Rob Crittenden
Forgive me for not having this in git format. This patch fixes a couple of problems in the help system: 1. If all commands in an object are disabled the object is still visible as a topic, see ipa help aci as an example 2. ipa help will show you that show-mappings help is broken 3. You

Re: [Freeipa-devel] [PATCH] Fix help system

2011-10-18 Thread Martin Kosek
On Tue, 2011-10-18 at 12:13 -0400, Rob Crittenden wrote: Forgive me for not having this in git format. This patch fixes a couple of problems in the help system: 1. If all commands in an object are disabled the object is still visible as a topic, see ipa help aci as an example 2. ipa

Re: [Freeipa-devel] [PATCH] 023 Circular entity dependency

2011-10-18 Thread Endi Sukma Dewata
On 10/18/2011 10:52 AM, Petr Vobornik wrote: 3. Another goal is to replace entity names used in spec (see other_entity nested_entity spec properties) with the actual entity objects. In this case it might be better to use the loops described in #2. This can be done separately. Wouldn't

Re: [Freeipa-devel] [PATCH] 023 Circular entity dependency

2011-10-18 Thread Adam Young
On 10/18/2011 02:25 PM, Endi Sukma Dewata wrote: On 10/18/2011 10:52 AM, Petr Vobornik wrote: 3. Another goal is to replace entity names used in spec (see other_entity nested_entity spec properties) with the actual entity objects. In this case it might be better to use the loops described