Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Alexander Bokovoy
On Mon, 31 Oct 2011, Jan Cholasta wrote: Dne 31.10.2011 13:19, Alexander Bokovoy napsal(a): On Mon, 31 Oct 2011, Jan Cholasta wrote: Added finalization for __call__ and the check for CLI. Patch attached. ACK from my side but see below. +def __getattribute__(self, name): +if not

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-02 Thread Petr Vobornik
On 11/01/2011 11:31 PM, Endi Sukma Dewata wrote: On 11/1/2011 7:37 AM, Petr Vobornik wrote: 1. The new clear() method is called during refresh(), so the facet with the old data is still shown for a brief moment before it's cleared. The clear() should be called before show(). However, if the

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Martin Kosek
On Wed, 2011-11-02 at 12:42 +0200, Alexander Bokovoy wrote: On Mon, 31 Oct 2011, Jan Cholasta wrote: Dne 31.10.2011 13:19, Alexander Bokovoy napsal(a): On Mon, 31 Oct 2011, Jan Cholasta wrote: Added finalization for __call__ and the check for CLI. Patch attached. ACK from my side but see

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Alexander Bokovoy
On Wed, 02 Nov 2011, Martin Kosek wrote: Hmm, this looks impressive! It would brings us considerably faster CLI calls. And again, I would feel much safer if we do these optimizations only for CLI and let server do all the initialization right on start. Well, that could be done in

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Jan Cholasta
Dne 2.11.2011 11:42, Alexander Bokovoy napsal(a): On Mon, 31 Oct 2011, Jan Cholasta wrote: Dne 31.10.2011 13:19, Alexander Bokovoy napsal(a): On Mon, 31 Oct 2011, Jan Cholasta wrote: Added finalization for __call__ and the check for CLI. Patch attached. ACK from my side but see below. +

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Alexander Bokovoy
On Wed, 02 Nov 2011, Jan Cholasta wrote: I see a number of problems with the patch: * Only Command subclasses are finalized (that might be the reason why it is so fast) * You assume that the first operation on a plugin instance is a call on the args/options/params namespaces, but there

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Jan Cholasta
Dne 2.11.2011 16:11, Alexander Bokovoy napsal(a): On Wed, 02 Nov 2011, Jan Cholasta wrote: I see a number of problems with the patch: * Only Command subclasses are finalized (that might be the reason why it is so fast) * You assume that the first operation on a plugin instance is a call

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-02 Thread Endi Sukma Dewata
On 11/2/2011 8:33 AM, Petr Vobornik wrote: On the second thought, this might not be sufficient to detect the changes in the list page. Try changing an attribute in an entry, then go back to the list page, the list page will not show the updated attribute because the filter is not changed. I

Re: [Freeipa-devel] Nesting widgets

2011-11-02 Thread Adam Young
This sounds pretty good. I think it is the right approach. On 11/01/2011 09:11 PM, Endi Sukma Dewata wrote: So I decided to try to get an IP Address widget working. See the attached patch. It was fairly trivial. However, this widget is not really all that useful by itself. It would

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-02 Thread Petr Vobornik
On 11/02/2011 04:41 PM, Endi Sukma Dewata wrote: On 11/2/2011 8:33 AM, Petr Vobornik wrote: Question about this one: 4) Changed direct/indirect radio names in association facets - radios form different facets were interfering. Did you notice any problem with the old radio name? The name was

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Alexander Bokovoy
On Wed, 02 Nov 2011, Jan Cholasta wrote: Callable instances are a consequence of the above -- Command.__call__() does use properties that are changed due to finalize() being run. In fact, there are so many places in FreeIPA where we simply expect that foo.args/params/output_params/output is

Re: [Freeipa-devel] [PATCH] 1 Do lazy initializiation ipalib

2011-11-02 Thread Alexander Bokovoy
(actual patch attached!) On Wed, 02 Nov 2011, Alexander Bokovoy wrote: On Wed, 02 Nov 2011, Jan Cholasta wrote: Callable instances are a consequence of the above -- Command.__call__() does use properties that are changed due to finalize() being run. In fact, there are so many places in

Re: [Freeipa-devel] Unifying the PKI and IPA Directory Server instances

2011-11-02 Thread Nathan Kinder
On 11/01/2011 10:08 AM, Ade Lee wrote: On Tue, 2011-11-01 at 12:49 -0400, Simo Sorce wrote: On Tue, 2011-11-01 at 12:40 -0400, Richard Megginson wrote: - Original Message - We had a brief discussion on unifying the PKI and IPA Directory Server instances. Here are my notes from it.

Re: [Freeipa-devel] Unifying the PKI and IPA Directory Server instances

2011-11-02 Thread Adam Young
To clarify: there are two types of Data stored in the PKI CA DS instances. One is Users and groups (IdM), and the other is certificates and requests. The CA currently administers its own users: creates, add deletes, add privs and so forth. If we extract the IdM objects from the CA

Re: [Freeipa-devel] Unifying the PKI and IPA Directory Server instances

2011-11-02 Thread Ade Lee
On Wed, 2011-11-02 at 16:03 -0400, Adam Young wrote: To clarify: there are two types of Data stored in the PKI CA DS instances. One is Users and groups (IdM), and the other is certificates and requests. The CA currently administers its own users: creates, add deletes, add privs and

Re: [Freeipa-devel] Unifying the PKI and IPA Directory Server instances

2011-11-02 Thread Simo Sorce
On Wed, 2011-11-02 at 16:44 -0400, Ade Lee wrote: On Wed, 2011-11-02 at 16:03 -0400, Adam Young wrote: [...] So, a user becomes an agent on the ca by having a certificate in the user record and being a member of the relevant admin, agent or auditor group. I see this as follows: 1. ipa

Re: [Freeipa-devel] Unifying the PKI and IPA Directory Server instances

2011-11-02 Thread Rob Crittenden
Simo Sorce wrote: On Wed, 2011-11-02 at 16:44 -0400, Ade Lee wrote: On Wed, 2011-11-02 at 16:03 -0400, Adam Young wrote: [...] So, a user becomes an agent on the ca by having a certificate in the user record and being a member of the relevant admin, agent or auditor group. I see this as

Re: [Freeipa-devel] Unifying the PKI and IPA Directory Server instances

2011-11-02 Thread Adam Young
On 11/02/2011 06:19 PM, Rob Crittenden wrote: Simo Sorce wrote: On Wed, 2011-11-02 at 16:44 -0400, Ade Lee wrote: On Wed, 2011-11-02 at 16:03 -0400, Adam Young wrote: [...] So, a user becomes an agent on the ca by having a certificate in the user record and being a member of the relevant

Re: [Freeipa-devel] Unifying the PKI and IPA Directory Server instances

2011-11-02 Thread Simo Sorce
On Wed, 2011-11-02 at 20:25 -0400, Adam Young wrote: On 11/02/2011 06:19 PM, Rob Crittenden wrote: Simo Sorce wrote: On Wed, 2011-11-02 at 16:44 -0400, Ade Lee wrote: On Wed, 2011-11-02 at 16:03 -0400, Adam Young wrote: [...] So, a user becomes an agent on the ca by having a certificate