Re: [Freeipa-devel] [PATCH] 348 Sort LDAP updates properly

2013-01-14 Thread Martin Kosek
On 01/11/2013 01:51 PM, Martin Kosek wrote: LDAP updates were sorted by number of RDNs in DN. This, however, sometimes caused updates to be executed before cn=schema updates. If the update required an objectClass or attributeType added during the cn=schema update, the update operation failed.

Re: [Freeipa-devel] Redesigning LDAP code

2013-01-14 Thread Jan Cholasta
On 11.1.2013 16:20, Petr Viktorin wrote: On 01/11/2013 03:55 PM, Rob Crittenden wrote: John Dennis wrote: On 01/11/2013 09:10 AM, Rob Crittenden wrote: Petr Viktorin wrote: We had a small discussion off-list about how we want IPA's LDAP handling to look in the future. To continue the

Re: [Freeipa-devel] [PATCH] 89 Raise ValidationError on invalid CSV values

2013-01-14 Thread Petr Viktorin
On 01/09/2013 06:11 PM, Jan Cholasta wrote: Hi, this patch fixes https://fedorahosted.org/freeipa/ticket/3323. Honza The patch works well, but could you also add a test to ensure we don't regress in the future? -- PetrĀ³ ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] 0001 Raise ValidationError for incorrect subtree option

2013-01-14 Thread Martin Kosek
On 01/04/2013 12:26 PM, Petr Viktorin wrote: On 01/03/2013 02:55 PM, Ana Krivokapic wrote: On 01/03/2013 01:42 PM, Petr Viktorin wrote: On 01/03/2013 12:56 PM, Ana Krivokapic wrote: Using incorrect input for --subtree option of ipa permission-add command now raises a ValidationError.

Re: [Freeipa-devel] [PATCH] convert the base platform modules into packages

2013-01-14 Thread Martin Kosek
On 12/12/2012 01:35 PM, Petr Viktorin wrote: On 12/06/2012 02:49 PM, Petr Viktorin wrote: On 12/05/2012 04:06 PM, Timo Aaltonen wrote: On 05.12.2012 15:01, Timo Aaltonen wrote: On 17.10.2012 16:43, Petr Viktorin wrote: On 09/21/2012 04:57 PM, Timo Aaltonen wrote: Ok, so this is the first

Re: [Freeipa-devel] [PATCH] 1079 address CA subsystem renewal issues

2013-01-14 Thread Petr Viktorin
On 01/12/2013 12:49 AM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 01/07/2013 05:42 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 01/07/2013 03:09 PM, Rob Crittenden wrote: Petr Viktorin wrote: [...] Works for me, but I have some questions (this is an area I

Re: [Freeipa-devel] [PATCH 0107] Don't fail if idnsSOAserial attribute is missing in LDAP

2013-01-14 Thread Adam Tkac
On Fri, Jan 11, 2013 at 06:47:52PM +0100, Petr Spacek wrote: Hello, Don't fail if idnsSOAserial attribute is missing in LDAP. DNS zones created on remote IPA 3.0 server don't have idnsSOAserial attribute present in LDAP. https://bugzilla.redhat.com/show_bug.cgi?id=894131

[Freeipa-devel] [PATCH 0026] Prevent integer overflow when setting krbPasswordExpiration

2013-01-14 Thread Tomas Babej
Hi, Since in Kerberos V5 are used 32-bit unix timestamps, setting maxlife in pwpolicy to values such as days would cause integer overflow in krbPasswordExpiration attribute. This would result into unpredictable behaviour such as users not being able to log in after password expiration if

[Freeipa-devel] Command instantiation

2013-01-14 Thread Petr Viktorin
IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the thread-local context. For an example see dnsrecord_del, which sets a del_all flag in pre_callback and then checks it in execute. While that works for now, it's far from best

[Freeipa-devel] Refactorings wiki page

2013-01-14 Thread Petr Viktorin
Hello, I've created a Wiki page to list our infrastructure improvement efforts/proposals: http://freeipa.org/page/V3/Refactorings Please add your own. -- PetrĀ³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread John Dennis
On 01/14/2013 11:06 AM, Petr Viktorin wrote: IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the thread-local context. For an example see dnsrecord_del, which sets a del_all flag in pre_callback and then checks it in execute.

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread Jan Cholasta
On 14.1.2013 17:06, Petr Viktorin wrote: IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the thread-local context. For an example see dnsrecord_del, which sets a del_all flag in pre_callback and then checks it in execute. While

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread Petr Viktorin
On 01/14/2013 05:48 PM, John Dennis wrote: On 01/14/2013 11:06 AM, Petr Viktorin wrote: IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the thread-local context. For an example see dnsrecord_del, which sets a del_all flag in

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread Petr Viktorin
On 01/14/2013 06:31 PM, Alexander Bokovoy wrote: On Mon, 14 Jan 2013, Jan Cholasta wrote: On 14.1.2013 17:06, Petr Viktorin wrote: IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the thread-local context. For an example see

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread Jan Cholasta
On 14.1.2013 18:50, Petr Viktorin wrote: On 01/14/2013 06:31 PM, Alexander Bokovoy wrote: On Mon, 14 Jan 2013, Jan Cholasta wrote: On 14.1.2013 17:06, Petr Viktorin wrote: IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread Rob Crittenden
Petr Viktorin wrote: On 01/14/2013 05:48 PM, John Dennis wrote: On 01/14/2013 11:06 AM, Petr Viktorin wrote: IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the thread-local context. For an example see dnsrecord_del, which sets a

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread Petr Viktorin
On 01/14/2013 07:17 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 01/14/2013 05:48 PM, John Dennis wrote: On 01/14/2013 11:06 AM, Petr Viktorin wrote: IPA Command objects sometimes need to pass some data between their various methods. Currently that's done using the thread-local context.

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread John Dennis
On 01/14/2013 01:17 PM, Rob Crittenden wrote: Petr Viktorin wrote: As for clearing the state, you already can't rely on that: the batch plugin doesn't do it. Yes, speaking of bolted on, that defines the batch plugin pretty well. It should be fairly straightforward to clear the state

Re: [Freeipa-devel] Command instantiation

2013-01-14 Thread John Dennis
On 01/14/2013 12:56 PM, Jan Cholasta wrote: On 14.1.2013 18:50, Petr Viktorin wrote: Ah, yes, you've discovered my ultimate goal: rewriting the whole framefork :) It would seem we share the same ultimate goal, sir! :-) Well it's reassuring I'm not alone in my frustration with elements of

Re: [Freeipa-devel] [PATCH] 1079 address CA subsystem renewal issues

2013-01-14 Thread Rob Crittenden
Petr Viktorin wrote: On 01/12/2013 12:49 AM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 01/07/2013 05:42 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 01/07/2013 03:09 PM, Rob Crittenden wrote: Petr Viktorin wrote: [...] Works for me, but I have some

Re: [Freeipa-devel] [PATCH] 1079 address CA subsystem renewal issues

2013-01-14 Thread Nalin Dahyabhai
On Fri, Jan 11, 2013 at 06:49:08PM -0500, Rob Crittenden wrote: Revised patch that takes advantage of new version of certmonger. certmonger-0.65 adds locking from the time renewal begins to the end of the post_save_command. A note: the lock isn't obtained until after we've obtained a