Re: [Freeipa-devel] [PATCH 130] extdom: add support for new version

On 09/29/2014 07:01 PM, Jakub Hrozek wrote: > On Mon, Sep 29, 2014 at 06:16:30PM +0200, Sumit Bose wrote: >>> Hi, >>> >>> Jakub found another issue which is fixed with this new version. >>> >>> bye, >>> Sumit >> >> and now with patch ... > > Thank you, > > ACK Pushed to: master: 3c75b9171e572109

Re: [Freeipa-devel] [PATCH 0067] Use stack allocation when writing values during otp auth

On 09/29/2014 06:01 PM, thierry bordaz wrote: > On 09/29/2014 05:45 PM, Nathaniel McCallum wrote: >> On Thu, 2014-09-25 at 13:45 +0200, thierry bordaz wrote: >>> On 09/19/2014 07:49 PM, Nathaniel McCallum wrote: >>> This is an optimization from patch 0062 (rescinded) which I think is wort

Re: [Freeipa-devel] [PATCH 0033] Remove trivial path constants

Updated patch to fix merge conflicts from recent changes. On Wed, Sep 24, 2014 at 8:34 PM, Gabe Alford wrote: > Hello, > > Patch for https://fedorahosted.org/freeipa/ticket/4399. Let me know if I > missed any. > > Thanks, > > Gabe > From 51ea42d4ecb16a425ea4ff6871ed9e0d5ce67327 Mon Sep 17 00:00:

Re: [Freeipa-devel] [PATCHES] 336-339 Installer certificate options usability fixes

On 09/29/2014 04:32 PM, Jan Cholasta wrote: Dne 26.9.2014 v 19:40 Jan Cholasta napsal(a): Dne 26.9.2014 v 17:37 Rob Crittenden napsal(a): Petr Viktorin wrote: On 09/24/2014 06:13 PM, Jan Cholasta wrote: Hi, the attached patches fix and

Re: [Freeipa-devel] [PATCH 0068] Move OTP synchronization step to after counter writeback

On Thu, 2014-09-25 at 15:15 +0200, thierry bordaz wrote: > On 09/19/2014 07:53 PM, Nathaniel McCallum wrote: > > > This prevents synchronization when an authentication collision occurs. > > > > https://fedorahosted.org/freeipa/ticket/4493 > > > > NOTE: this patch is related to the above ticket,

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

On Mon, 2014-09-22 at 09:32 -0400, Simo Sorce wrote: > On Sun, 21 Sep 2014 22:33:47 -0400 > Nathaniel McCallum wrote: > > Comments inline. > > > + > > +#define ch_malloc(type) \ > > +(type*) slapi_ch_malloc(sizeof(type)) > > +#define ch_calloc(count, type) \ > > +(type*) slapi_ch_calloc(

Re: [Freeipa-devel] [PATCH 130] extdom: add support for new version

On Mon, Sep 29, 2014 at 06:16:30PM +0200, Sumit Bose wrote: > > Hi, > > > > Jakub found another issue which is fixed with this new version. > > > > bye, > > Sumit > > and now with patch ... Thank you, ACK ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCH 130] extdom: add support for new version

On Mon, Sep 29, 2014 at 06:15:21PM +0200, Sumit Bose wrote: > On Thu, Sep 25, 2014 at 01:46:00PM +0200, Sumit Bose wrote: > > On Wed, Sep 24, 2014 at 03:23:54PM +0200, Jakub Hrozek wrote: > > > On Tue, Sep 23, 2014 at 05:11:01PM +0200, Sumit Bose wrote: > > > > Hi, > > > > > > > > this patch shoul

Re: [Freeipa-devel] [PATCH 130] extdom: add support for new version

On Thu, Sep 25, 2014 at 01:46:00PM +0200, Sumit Bose wrote: > On Wed, Sep 24, 2014 at 03:23:54PM +0200, Jakub Hrozek wrote: > > On Tue, Sep 23, 2014 at 05:11:01PM +0200, Sumit Bose wrote: > > > Hi, > > > > > > this patch should fix https://fedorahosted.org/freeipa/ticket/4031 and > > > with the co

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

Jan Cholasta wrote: > Dne 29.9.2014 v 15:05 Rob Crittenden napsal(a): >> Jan Cholasta wrote: >>> Dne 26.9.2014 v 17:13 Rob Crittenden napsal(a): Jan Cholasta wrote: > Dne 23.9.2014 v 20:39 Rob Crittenden napsal(a): >> Jan Cholasta wrote: >>> Hi, >>> >>> the attached patches

Re: [Freeipa-devel] [PATCH 0067] Use stack allocation when writing values during otp auth

On 09/29/2014 05:45 PM, Nathaniel McCallum wrote: On Thu, 2014-09-25 at 13:45 +0200, thierry bordaz wrote: On 09/19/2014 07:49 PM, Nathaniel McCallum wrote: This is an optimization from patch 0062 (rescinded) which I think is worth keeping. There is no ticket for this. __

Re: [Freeipa-devel] [PATCH 0067] Use stack allocation when writing values during otp auth

On Thu, 2014-09-25 at 13:45 +0200, thierry bordaz wrote: > On 09/19/2014 07:49 PM, Nathaniel McCallum wrote: > > > This is an optimization from patch 0062 (rescinded) which I think is > > worth keeping. There is no ticket for this. > > > > > > ___ > >

Re: [Freeipa-devel] [PATCH 0067] Use stack allocation when writing values during otp auth

On Thu, 2014-09-25 at 13:45 +0200, thierry bordaz wrote: > On 09/19/2014 07:49 PM, Nathaniel McCallum wrote: > > > This is an optimization from patch 0062 (rescinded) which I think is > > worth keeping. There is no ticket for this. > > > > > > ___ > >

[Freeipa-devel] [PATCH] 0018 Check that port 8443 is available when installing PKI.

https://fedorahosted.org/freeipa/ticket/4564 -- David Kupka From d5748822b8fac3cde01670507f80bfa9c4c04ede Mon Sep 17 00:00:00 2001 From: David Kupka Date: Mon, 29 Sep 2014 04:27:30 -0400 Subject: [PATCH] Check that port 8443 is available when installing PKI. https://fedorahosted.org/freeipa/tick

Re: [Freeipa-devel] [PATCH] 757 webui: do not offer ipa-ad-winsync and ipa-ipa-trust range types

On 29.9.2014 16:19, Endi Sukma Dewata wrote: On 9/29/2014 2:40 AM, Petr Vobornik wrote: On 24.9.2014 12:17, Petr Vobornik wrote: webui: do not offer ipa-ad-winsync and ipa-ipa-trust range types They are not supported by API. Forgot to attach patch... ACK. Pushed to: ipa-4-1: d84b8fe8e3eb

Re: [Freeipa-devel] [PATCHES] 336-339 Installer certificate options usability fixes

Dne 26.9.2014 v 19:40 Jan Cholasta napsal(a): Dne 26.9.2014 v 17:37 Rob Crittenden napsal(a): Petr Viktorin wrote: On 09/24/2014 06:13 PM, Jan Cholasta wrote: Hi, the attached patches fix and . (Note

Re: [Freeipa-devel] [PATCH] 757 webui: do not offer ipa-ad-winsync and ipa-ipa-trust range types

On 9/29/2014 2:40 AM, Petr Vobornik wrote: On 24.9.2014 12:17, Petr Vobornik wrote: webui: do not offer ipa-ad-winsync and ipa-ipa-trust range types They are not supported by API. Forgot to attach patch... ACK. -- Endi S. Dewata ___ Freeipa-deve

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

Dne 29.9.2014 v 15:05 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 26.9.2014 v 17:13 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 23.9.2014 v 20:39 Rob Crittenden napsal(a): Jan Cholasta wrote: Hi, the attached patches fix various bugs and shortcomings in the CA management and ren

Re: [Freeipa-devel] [PATCH 0271] baseldap: Properly handle the case of renaming object to the

On 09/29/2014 02:44 PM, Jan Cholasta wrote: > Dne 29.9.2014 v 13:52 Tomas Babej napsal(a): >> On 09/18/2014 02:10 AM, Rob Crittenden wrote: >>> Tomas Babej wrote: Hi, When renaming a object to the same name, errors.EmptyModList is raised. This is not properly handled, and can ca

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

Jan Cholasta wrote: > Dne 26.9.2014 v 17:13 Rob Crittenden napsal(a): >> Jan Cholasta wrote: >>> Dne 23.9.2014 v 20:39 Rob Crittenden napsal(a): Jan Cholasta wrote: > Hi, > > the attached patches fix various bugs and shortcomings in the CA > management and renewal code. Related

Re: [Freeipa-devel] [PATCH] 314 Allow specifying key algorithm of the IPA CA cert in ipa-server-install

On Mon, 29 Sep 2014 13:16:07 +1000 Fraser Tweedale wrote: > On Fri, Sep 26, 2014 at 10:44:16AM -0400, Simo Sorce wrote: > > On Fri, 26 Sep 2014 13:54:34 +0200 > > Martin Kosek wrote: > > > > > >> I tested the patch (it works fine with Dogtag 10), but I got > > > >> very confused. > > > >> > > >

Re: [Freeipa-devel] [PATCH 0271] baseldap: Properly handle the case of renaming object to the

Dne 29.9.2014 v 13:52 Tomas Babej napsal(a): On 09/18/2014 02:10 AM, Rob Crittenden wrote: Tomas Babej wrote: Hi, When renaming a object to the same name, errors.EmptyModList is raised. This is not properly handled, and can cause other modifications in the LDAPUpdate command to be ignored. ht

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

Dne 26.9.2014 v 19:54 Jan Cholasta napsal(a): Dne 26.9.2014 v 17:13 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 23.9.2014 v 20:39 Rob Crittenden napsal(a): Jan Cholasta wrote: Hi, the attached patches fix various bugs and shortcomings in the CA management and renewal code. Related tick

Re: [Freeipa-devel] [PATCH 0271] baseldap: Properly handle the case of renaming object to the

On 09/18/2014 02:10 AM, Rob Crittenden wrote: > Tomas Babej wrote: >> Hi, >> >> When renaming a object to the same name, errors.EmptyModList is raised. >> This is not properly handled, and can cause other modifications in the >> LDAPUpdate command to be ignored. >> >> https://fedorahosted.org/freei

Re: [Freeipa-devel] [PATCH] 314 Allow specifying key algorithm of the IPA CA cert in ipa-server-install

On 09/29/2014 01:13 PM, Jan Cholasta wrote: > Dne 29.9.2014 v 12:20 Martin Kosek napsal(a): >> On 09/29/2014 11:11 AM, Jan Cholasta wrote: >>> Dne 29.9.2014 v 05:16 Fraser Tweedale napsal(a): On Fri, Sep 26, 2014 at 10:44:16AM -0400, Simo Sorce wrote: > On Fri, 26 Sep 2014 13:54:34 +0200 >

Re: [Freeipa-devel] [PATCH] 314 Allow specifying key algorithm of the IPA CA cert in ipa-server-install

Dne 29.9.2014 v 12:20 Martin Kosek napsal(a): On 09/29/2014 11:11 AM, Jan Cholasta wrote: Dne 29.9.2014 v 05:16 Fraser Tweedale napsal(a): On Fri, Sep 26, 2014 at 10:44:16AM -0400, Simo Sorce wrote: On Fri, 26 Sep 2014 13:54:34 +0200 Martin Kosek wrote: I tested the patch (it works fine wit

Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

On 09/29/2014 11:04 AM, David Kupka wrote: > On 09/29/2014 10:22 AM, Martin Kosek wrote: >> On 09/29/2014 10:09 AM, David Kupka wrote: >>> https://fedorahosted.org/freeipa/ticket/4387 >> >> The changes look OK so far, except the test fix. >> >> The test_batch_plugin.py test is apparently testing th

Re: [Freeipa-devel] [PATCH] 314 Allow specifying key algorithm of the IPA CA cert in ipa-server-install

On 09/29/2014 11:11 AM, Jan Cholasta wrote: > Dne 29.9.2014 v 05:16 Fraser Tweedale napsal(a): >> On Fri, Sep 26, 2014 at 10:44:16AM -0400, Simo Sorce wrote: >>> On Fri, 26 Sep 2014 13:54:34 +0200 >>> Martin Kosek wrote: >>> >> I tested the patch (it works fine with Dogtag 10), but I got very

Re: [Freeipa-devel] [PATCH] 314 Allow specifying key algorithm of the IPA CA cert in ipa-server-install

Dne 29.9.2014 v 05:16 Fraser Tweedale napsal(a): On Fri, Sep 26, 2014 at 10:44:16AM -0400, Simo Sorce wrote: On Fri, 26 Sep 2014 13:54:34 +0200 Martin Kosek wrote: I tested the patch (it works fine with Dogtag 10), but I got very confused. What CA option are we setting? Signing algorithm or

Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

On 09/29/2014 10:22 AM, Martin Kosek wrote: On 09/29/2014 10:09 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4387 The changes look OK so far, except the test fix. The test_batch_plugin.py test is apparently testing that batch command behaves well in RequirementError for opti

Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

On 09/29/2014 10:09 AM, David Kupka wrote: > https://fedorahosted.org/freeipa/ticket/4387 The changes look OK so far, except the test fix. The test_batch_plugin.py test is apparently testing that batch command behaves well in RequirementError for options. Thus, we should not remove it, we should

[Freeipa-devel] [PATCH] 0017 Do not require description in UI.

https://fedorahosted.org/freeipa/ticket/4387 -- David Kupka From 8a0ac7417e904c21946e08bbdd759550bffab5ad Mon Sep 17 00:00:00 2001 From: David Kupka Date: Fri, 26 Sep 2014 02:54:28 -0400 Subject: [PATCH] Do not require description in UI. Description attribute is not required in LDAP schema so th

Re: [Freeipa-devel] Continuous Integration & dependency tree testing

On 29.9.2014 08:31, Jan Pazdziora wrote: On Wed, Sep 24, 2014 at 08:47:57AM +0200, Martin Kosek wrote: There is a good question though how the test should be triggered when our dependency changes and the code does not (especially in stable branches). This may be the part where the mechanism you

Re: [Freeipa-devel] [PATCH] 757 webui: do not offer ipa-ad-winsync and ipa-ipa-trust range types

On 24.9.2014 12:17, Petr Vobornik wrote: webui: do not offer ipa-ad-winsync and ipa-ipa-trust range types They are not supported by API. Forgot to attach patch... -- Petr Vobornik From b9edc41752d173b36c52923634b33028064180ed Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 3 Sep 2014

Re: [Freeipa-devel] Continuous Integration & dependency tree testing

On 09/29/2014 08:31 AM, Jan Pazdziora wrote: > On Wed, Sep 24, 2014 at 08:47:57AM +0200, Martin Kosek wrote: >> >> There is a good question though how the test should be triggered when our >> dependency changes and the code does not (especially in stable branches). >> This >> may be the part where