On 01/26/2015 05:46 PM, Martin Basti wrote:
On 26/01/15 14:05, Martin Babinsky wrote:
On 01/26/2015 01:59 PM, Martin Babinsky wrote:
On 01/23/2015 05:56 PM, Martin Basti wrote:
On 22/01/15 15:03, Martin Babinsky wrote:
On 01/22/2015 12:38 PM, Martin Babinsky wrote:
On 01/22/2015 12:19 PM,
On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote:
On 27.1.2015 17:56, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Martin Babinsky wrote:
From 23a823c3c5933d5c14342e15c00599af74b84118
On Tue, 27 Jan 2015, Petr Spacek wrote:
I don't know this piece of code so I can't say anything in particular.
Are you 100 % sure that it will not cause any harm in future? I'm hesitant to
introduce a goto branching which is not testable nowadays.
Personally I would prefer either assert() or
On 01/27/2015 07:59 PM, Rob Crittenden wrote:
Martin Kosek wrote:
On 01/27/2015 08:40 AM, Jan Cholasta wrote:
Hi,
the attached patch fixes https://fedorahosted.org/freeipa/ticket/4857.
Honza
Works like a charm, ACK.
Pushed to:
master: deb70d5b13ce0e7ec77debb4aa17d75df4c1dedd
ipa-4-1:
Martin Kosek wrote:
On 01/27/2015 08:40 AM, Jan Cholasta wrote:
Hi,
the attached patch fixes https://fedorahosted.org/freeipa/ticket/4857.
Honza
Works like a charm, ACK.
Pushed to:
master: deb70d5b13ce0e7ec77debb4aa17d75df4c1dedd
ipa-4-1: 74853b66f092a057c22ee811e945f631e6d65059
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote:
On 27.1.2015 17:56, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Martin Babinsky wrote:
From
The attached patch is related to
https://fedorahosted.org/freeipa/ticket/4795 and fixes (hopefully) some
of the defects reported by subsequent scans.
There are also 21 defects reported in asn1/asn1c/*.c files
On Tue, 27 Jan 2015, Martin Babinsky wrote:
The attached patch is related to
https://fedorahosted.org/freeipa/ticket/4795 and fixes (hopefully)
some of the defects reported by subsequent scans.
NACK overall. If you want to provide fixes, make them separate of each
other and explain each fix.
On 26/01/15 17:36, Martin Babinsky wrote:
See attached patch related to
https://fedorahosted.org/freeipa/ticket/4863.
Martin^3
Thank for your patch,
IMO client is not dependent on dbus module, but ipapython requires dbus
module.
We should add this dependency to ipapython package, because
On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote:
On 27.1.2015 17:56, Alexander Bokovoy
On Tue, 2015-01-27 at 23:04 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote:
On 27.1.2015 17:56, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Martin Babinsky wrote:
From 23a823c3c5933d5c14342e15c00599af74b84118 Mon Sep 17 00:00:00 2001
From: Martin Babinsky
On 01/27/2015 10:15 PM, Simo Sorce wrote:
On Tue, 2015-01-27 at 23:04 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Simo Sorce wrote:
On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy
On 27.1.2015 17:56, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Martin Babinsky wrote:
From 23a823c3c5933d5c14342e15c00599af74b84118 Mon Sep 17 00:00:00 2001
From: Martin Babinsky mbabi...@redhat.com
Date: Tue, 27 Jan 2015 13:21:33 +0100
Subject: [PATCH 3/7] proposed fix fo a defect
On 01/26/2015 04:33 PM, Tomas Babej wrote:
Hi,
the following two patches make sure that sshpubkeys work both with -mod and
-add commands of ipaoverrideuser objects. Also covers the use cases with unit
tests.
https://fedorahosted.org/freeipa/ticket/4868
Tomas
On 01/27/2015 08:40 AM, Jan Cholasta wrote:
Hi,
the attached patch fixes https://fedorahosted.org/freeipa/ticket/4857.
Honza
Works like a charm, ACK.
Pushed to:
master: deb70d5b13ce0e7ec77debb4aa17d75df4c1dedd
ipa-4-1: 74853b66f092a057c22ee811e945f631e6d65059
Martin
Dne 27.1.2015 v 16:22 David Kupka napsal(a):
On 01/26/2015 04:33 PM, Tomas Babej wrote:
Hi,
the following two patches make sure that sshpubkeys work both with
-mod and -add commands of ipaoverrideuser objects. Also covers the use
cases with unit tests.
On 01/27/2015 06:05 PM, Petr Spacek wrote:
On 27.1.2015 18:02, Alexander Bokovoy wrote:
-slapi_search_internal_get_entry(sdn, attrs, entry,
-otp_config_plugin_id(otp_config));
+search_result = slapi_search_internal_get_entry(sdn, attrs, entry,
+
On 27.1.2015 18:23, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Petr Spacek wrote:
On 27.1.2015 17:56, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Martin Babinsky wrote:
From 23a823c3c5933d5c14342e15c00599af74b84118 Mon Sep 17 00:00:00 2001
From: Martin Babinsky mbabi...@redhat.com
Date:
This series of patches is related to
https://fedorahosted.org/freeipa/ticket/4795.
The attached patches attempt to address some of the defects encountered
during running covscan on freeipa-master branch.
The complete list is here:
On 27.1.2015 18:02, Alexander Bokovoy wrote:
-slapi_search_internal_get_entry(sdn, attrs, entry,
-otp_config_plugin_id(otp_config));
+search_result = slapi_search_internal_get_entry(sdn, attrs, entry,
+otp_config_plugin_id(otp_config));
On 01/27/2015 10:41 AM, Martin Basti wrote:
On 26/01/15 17:36, Martin Babinsky wrote:
See attached patch related to
https://fedorahosted.org/freeipa/ticket/4863.
Martin^3
Thank for your patch,
IMO client is not dependent on dbus module, but ipapython requires dbus
module.
We should add
On 27.1.2015 18:41, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Petr Spacek wrote:
On 27.1.2015 18:23, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Petr Spacek wrote:
On 27.1.2015 17:56, Alexander Bokovoy wrote:
On Tue, 27 Jan 2015, Martin Babinsky wrote:
From
24 matches
Mail list logo
