Re: [Freeipa-devel] [PATCH 0024] do not log BINDs to non-existent users as errors

2015-04-02 Thread Jan Cholasta
Dne 30.3.2015 v 14:10 Petr Spacek napsal(a): On 25.3.2015 17:07, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/4889 ACK Pushed to: master: 4192cce80eb22172696b11bf24457f7467b711fc ipa-4-1: ede3298fdf8092567b7cfec4053c0db45725f882 -- Jan Cholasta -- Manage your

Re: [Freeipa-devel] [PATCH 0222] DNSSEC: do not log into files

2015-04-02 Thread Jan Cholasta
Dne 30.3.2015 v 13:55 Petr Spacek napsal(a): On 26.3.2015 16:33, Martin Basti wrote: We want to log DNSSEC daemons only into console (journald). This patch also fixes unexpected log file in /var/lib/softhsm/.ipa/log/default.log Patch attached. ACK Pushed to: master:

Re: [Freeipa-devel] [PATCH] 809 speed up convert_attribute_members

2015-04-02 Thread Jan Cholasta
Hi, Dne 31.3.2015 v 12:11 Petr Vobornik napsal(a): A workaround to avoid usage of slow LDAPEntry._sync_attr #4946. I originally wanted to avoid DN processing as well but we can't do that because of DNs which are encoded - e.g. contains '+' or ','. Therefore patch 811 - faster DN implementation

Re: [Freeipa-devel] [PATCH] 811 performance: faster DN implementation

2015-04-02 Thread Petr Viktorin
On 03/31/2015 12:11 PM, Petr Vobornik wrote: The only different thing is a lack of utf-8 encoded str support(as input). I don't know how much important the support is. I don't think that support is too important (assuming IPA doesn't use it!). However, the behavior with this patch is

Re: [Freeipa-devel] [PATCH 0212] Server Upgrade: Fix comments

2015-04-02 Thread Jan Cholasta
Dne 24.3.2015 v 14:23 David Kupka napsal(a): On 03/24/2015 12:04 PM, Martin Basti wrote: On 24/03/15 09:54, Martin Basti wrote: On 23/03/15 15:36, Martin Basti wrote: Attached patch fixes comments which I forgot to edit in 'make upgrade deterministic' patchset I missed some dictionaries

Re: [Freeipa-devel] [PATCH] 0001-2 ipatests: SOA record Maintenance tests

2015-04-02 Thread Jan Cholasta
Dne 27.3.2015 v 16:54 Martin Basti napsal(a): On 27/03/15 16:34, Aleš Mareček wrote: Greetings! Martin, thanks for your review and comments! I changed the name of the patch and setup my git variables properly. I also re-tested it and got all passed. I'm sending a new patch that is attached.

Re: [Freeipa-devel] [PATCH 0021] fix improper handling of boolean option during KRA install

2015-04-02 Thread Jan Cholasta
Dne 25.3.2015 v 16:48 Martin Basti napsal(a): On 17/03/15 17:51, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/4530 ACK -- Martin Basti Pushed to master: c311af06f60cfdb73be9c0aecb9ddc559db1a055 -- Jan Cholasta -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0223] Fix ldap2 do not create shared instance by default

2015-04-02 Thread Martin Basti
On 02/04/15 14:11, Jan Cholasta wrote: Hi, Dne 1.4.2015 v 17:16 Martin Basti napsal(a): Since API is not singleton anymore, ldap2 instance should not be shared between all APIs. Patch attached. Works for me. However, it's not the ldap2 instance that was shared, but rather the underlying

Re: [Freeipa-devel] [PATCH 0223] Fix ldap2 do not create shared instance by default

2015-04-02 Thread Jan Cholasta
Dne 2.4.2015 v 14:18 Martin Basti napsal(a): On 02/04/15 14:11, Jan Cholasta wrote: Hi, Dne 1.4.2015 v 17:16 Martin Basti napsal(a): Since API is not singleton anymore, ldap2 instance should not be shared between all APIs. Patch attached. Works for me. However, it's not the ldap2 instance

[Freeipa-devel] [PATCH] 0688 rename_managed: Remove use of EditableDN

2015-04-02 Thread Petr Viktorin
This removes the last use of dn.Editable* from IPA code. For cases where an EditableDN was used, lists/generators of RDNs tend to work better IMO. When this is merged, Editable* can be removed (which I don't want to do right now since there's a patch on review that would conflict). -- Petr

Re: [Freeipa-devel] [PATCH 0045] Add message for skipping NTP configuration during client install

2015-04-02 Thread Gabe Alford
On Thu, Apr 2, 2015 at 8:59 AM, Martin Basti mba...@redhat.com wrote: On 30/03/15 15:25, Gabe Alford wrote: Hello, With the merging of ticket 4842 https://fedorahosted.org/freeipa/ticket/4842, I believe that half of ticket 3092 https://fedorahosted.org/freeipa/ticket/3092 has been

Re: [Freeipa-devel] [PATCH 0045] Add message for skipping NTP configuration during client install

2015-04-02 Thread Martin Basti
On 30/03/15 15:25, Gabe Alford wrote: Hello, With the merging of ticket 4842 https://fedorahosted.org/freeipa/ticket/4842, I believe that half of ticket 3092 https://fedorahosted.org/freeipa/ticket/3092 has been done. This patch just adds a message that says that NTP configuration was