Re: [Freeipa-devel] [PATCH 0331, 0337] User plugin: allow multiple managers per user - CLI part

On 12.11.2015 12:39, Martin Basti wrote: On 27.10.2015 14:59, Martin Basti wrote: On 20.10.2015 18:46, Martin Basti wrote: On 20.10.2015 16:07, Martin Basti wrote: On 20.10.2015 15:57, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5344 Patch attached. Test are

Re: [Freeipa-devel] Caching ldap limits for whole connection (performance)

On 18.11.2015 17:34, Martin Basti wrote: On 18.11.2015 14:25, Petr Vobornik wrote: On 11/17/2015 10:37 AM, Martin Basti wrote: On 16.11.2015 20:18, Rob Crittenden wrote: Martin Basti wrote: On 16.11.2015 18:57, Martin Basti wrote: How does this code work (IMO it doesn't), ldap2.py

Re: [Freeipa-devel] Caching ldap limits for whole connection (performance)

On 18.11.2015 18:01, Martin Basti wrote: On 18.11.2015 17:58, Rob Crittenden wrote: Martin Basti wrote: On 18.11.2015 17:34, Martin Basti wrote: On 18.11.2015 14:25, Petr Vobornik wrote: On 11/17/2015 10:37 AM, Martin Basti wrote: On 16.11.2015 20:18, Rob Crittenden wrote: Martin

Re: [Freeipa-devel] [PATCH 0344] Use absolute domain name in detection of A/AAAA records

On 12.11.2015 13:58, Martin Basti wrote: > > > On 09.11.2015 08:47, Petr Spacek wrote: >> On 4.11.2015 16:16, Martin Basti wrote: >>> Patch attached. >>> >>> https://fedorahosted.org/freeipa/ticket/5421 >> I'm not entirely sure how this patch will interact with magic included in >>

Re: [Freeipa-devel] Caching ldap limits for whole connection (performance)

Martin Basti wrote: > > > On 18.11.2015 17:34, Martin Basti wrote: >> >> >> On 18.11.2015 14:25, Petr Vobornik wrote: >>> On 11/17/2015 10:37 AM, Martin Basti wrote: On 16.11.2015 20:18, Rob Crittenden wrote: > Martin Basti wrote: >> >> >> On 16.11.2015 18:57,

Re: [Freeipa-devel] Caching ldap limits for whole connection (performance)

On 18.11.2015 17:58, Rob Crittenden wrote: Martin Basti wrote: On 18.11.2015 17:34, Martin Basti wrote: On 18.11.2015 14:25, Petr Vobornik wrote: On 11/17/2015 10:37 AM, Martin Basti wrote: On 16.11.2015 20:18, Rob Crittenden wrote: Martin Basti wrote: On 16.11.2015 18:57, Martin

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

On 09.11.2015 15:09, Oleg Fayans wrote: Hi guys, Here are first two automated testcases from this (so far incomplete) testplan: http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan Testplan review is highly appreciated PATCH 16: NACK 1) What is the reason to add an unused

Re: [Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

On 11/18/2015 02:16 PM, Lenka Doudova wrote: Hi, here's a patch that adds a few comments to stageuser tests in order to allow easier determining of a problem when tests fail. Lenka Hi Lenka, Firstly a technical detail: Python indexes lists from 0, so the comments in 'options_ok' do not

Re: [Freeipa-devel] Caching ldap limits for whole connection (performance)

On 18.11.2015 14:25, Petr Vobornik wrote: On 11/17/2015 10:37 AM, Martin Basti wrote: On 16.11.2015 20:18, Rob Crittenden wrote: Martin Basti wrote: On 16.11.2015 18:57, Martin Basti wrote: How does this code work (IMO it doesn't), ldap2.py def find_entries(self, filter=None,

Re: [Freeipa-devel] [PATCH 506] cert renewal: make renewal of ipaCert atomic

On 10.11.2015 19:19, Rob Crittenden wrote: Jan Cholasta wrote: On 9.11.2015 16:51, Rob Crittenden wrote: Jan Cholasta wrote: Hi, the attached patch fixes . Honza There be a note in renew_ra_cert that the lock is obtained in advance by

[Freeipa-devel] [PATCHES 151-153] ipasam: fix wrong usage of talloc_new()

Hi, please find attached 3 small patches for ipasam. The first fixes https://fedorahosted.org/freeipa/ticket/5457 . The second is related because if the compat tree is enabled the lookup will still fails because the group is found twice. The third patch fixes an issue valgrind found while I was

Re: [Freeipa-devel] [PATCH] BUILD: provide check target in custom Makefiles

On 13.11.2015 09:36, Lukas Slebodnik wrote: ehlo, The automake generated makefiles have already a target check. We need to provide this target also to non-generated Makefiles so we can recursively call make check from top level Makefile. LS ACK Pushed to master:

[Freeipa-devel] [PATCH 0350] raise time limit for ldapsearch in upgrade

https://fedorahosted.org/freeipa/ticket/5267 Patch attached. From 02de683d938d4d81466af862f17d7412511eb1c2 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 18 Nov 2015 10:31:05 +0100 Subject: [PATCH] Upgrade: increase time limit for upgrades Default ldap search limit

Re: [Freeipa-devel] [PATCH 0350] raise time limit for ldapsearch in upgrade

On 11/18/2015 01:30 PM, Martin Basti wrote: > +DEFAULT_TIME_LIMIT = -1.0 > +DEFAULT_SIZE_LIMIT = 0 ... > if time_limit is None or time_limit == 0: > -time_limit = -1.0 > +if self.time_limit is not None and self.time_limit != 0: > +time_limit

[Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

Hi, here's a patch that adds a few comments to stageuser tests in order to allow easier determining of a problem when tests fail. Lenka From a1ec552f27eeb05f5f9c41d59e076aa6ef7601db Mon Sep 17 00:00:00 2001 From: Lenka Doudova Date: Wed, 18 Nov 2015 09:11:29 +0100

Re: [Freeipa-devel] [PATCHES 151-153] ipasam: fix wrong usage of talloc_new()

On Wed, 18 Nov 2015, Sumit Bose wrote: Hi, please find attached 3 small patches for ipasam. The first fixes https://fedorahosted.org/freeipa/ticket/5457 . The second is related because if the compat tree is enabled the lookup will still fails because the group is found twice. The third patch

Re: [Freeipa-devel] [PATCH 0348] CI: fix KRA installation with domain level>0

On 16.11.2015 17:33, Aleš Mareček wrote: ACK. Pushed to master: e56a1535b041c1ca1f398b54eda6bf04f1c1e33b - Original Message - From: "Martin Basti" To: "freeipa-devel" Sent: Monday, November 16, 2015 4:06:51 PM Subject: [Freeipa-devel]

Re: [Freeipa-devel] [PATCH] cmocka_tests: Do not use deprecated cmocka interface

On 13.11.2015 09:33, Lukas Slebodnik wrote: ehlo, The cmocka-1.0 introduced new interface for tests which is not compatible with the old one. And the old interface is deprecated which caused compiled warnings. LS ACK Pushed to master: 75c26f9ec8d69af88bbf1d07b2c7b38d08e8d67d -- Manage

Re: [Freeipa-devel] [PATCH] ipa_kdb_tests: Fix test with default krb5.conf

On 13.11.2015 09:29, Lukas Slebodnik wrote: ehlo, ipa_kdb_tests test failed for me on minimal f23. LS ACK Pushed to master: 73058af717b1ab470858be9273d38ff27d35002a -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0347] Fix CI tests domain_level ENV config

On 16.11.2015 17:32, Aleš Mareček wrote: ACK. Pushed to master: 79f7c71e61698457ae63b4f67bf296859e3f12d1 - Original Message - From: "Martin Basti" To: "freeipa-devel" Sent: Friday, November 13, 2015 7:39:00 PM Subject: [Freeipa-devel]

[Freeipa-devel] [PATCH 0096] check whether replica exists before executing the domain level 1 deletion code

Additional fix for https://fedorahosted.org/freeipa/ticket/5424 In current implementation the topology suffices are checked first and after that the error about non-existent host is raised. This does not make much sense to me, we should check for host existence before any work is done. --

Re: [Freeipa-devel] [PATCH] SPEC: Run cmocka based uni test in %check phase

On 13.11.2015 12:04, Lukas Slebodnik wrote: On (13/11/15 09:37), Lukas Slebodnik wrote: ehlo, this patch depends on freeipa-lslebodn-0007-BUILD-provide-check-target-in-custom-Makefile.patch LS >From 507b57b4a166b0490d4217a9603a67577bb36036 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik

Re: [Freeipa-devel] [PATCH 0350] raise time limit for ldapsearch in upgrade

On 18.11.2015 13:55, Martin Kosek wrote: On 11/18/2015 01:30 PM, Martin Basti wrote: +DEFAULT_TIME_LIMIT = -1.0 +DEFAULT_SIZE_LIMIT = 0 ... if time_limit is None or time_limit == 0: -time_limit = -1.0 +if self.time_limit is not None and

Re: [Freeipa-devel] [PATCH 0350] raise time limit for ldapsearch in upgrade

On 18.11.2015 14:24, Martin Kosek wrote: On 11/18/2015 02:18 PM, Martin Basti wrote: On 18.11.2015 13:55, Martin Kosek wrote: On 11/18/2015 01:30 PM, Martin Basti wrote: +DEFAULT_TIME_LIMIT = -1.0 +DEFAULT_SIZE_LIMIT = 0 ... if time_limit is None or time_limit == 0: -

Re: [Freeipa-devel] Caching ldap limits for whole connection (performance)

On 11/17/2015 10:37 AM, Martin Basti wrote: On 16.11.2015 20:18, Rob Crittenden wrote: Martin Basti wrote: On 16.11.2015 18:57, Martin Basti wrote: How does this code work (IMO it doesn't), ldap2.py def find_entries(self, filter=None, attrs_list=None, base_dn=None,

Re: [Freeipa-devel] [PATCH 0350] raise time limit for ldapsearch in upgrade

On 11/18/2015 02:18 PM, Martin Basti wrote: > > > On 18.11.2015 13:55, Martin Kosek wrote: >> On 11/18/2015 01:30 PM, Martin Basti wrote: >>> +DEFAULT_TIME_LIMIT = -1.0 >>> +DEFAULT_SIZE_LIMIT = 0 >> ... >>> if time_limit is None or time_limit == 0: >>> -time_limit

Re: [Freeipa-devel] [PATCH] 0748 Handle encoding for ipautil.run

On 11/03/2015 02:39 PM, Petr Viktorin wrote: > Hello, > Python 3's strings are Unicode, so data coming to or leaving a Python > program needs to be decoded/encoded if it's to be handled as a string. > One of the boundaries where encoding is necessary is external programs, > specifically,